D25484: Enable closing a tab by middle click

bdbai abandoned this revision. bdbai added a comment. Moved to https://invent.kde.org/kde/okular/merge_requests/69 . REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25484 To: bdbai, #vdg Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, and

D25484: Enable closing a tab by middle click

bdbai marked 6 inline comments as done. bdbai added a comment. An MR is drafted at invent, see https://invent.kde.org/kde/okular/merge_requests/69 . REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25484 To: bdbai, #vdg Cc: aacid, davidhurka, ngraham, romangg, ndavis,

D25484: Enable closing a tab by middle click

bdbai updated this revision to Diff 70387. bdbai added a comment. Fixed code styles REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25484?vs=70349&id=70387 REVISION DETAIL https://phabricator.kde.org/D25484 AFFECTED FILES autotests/mainshelltest.cpp s

D25484: Enable closing a tab by middle click

bdbai updated this revision to Diff 70349. bdbai added a comment. - Added "undo tab close" - Added a test REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25484?vs=70197&id=70349 REVISION DETAIL https://phabricator.kde.org/D25484 AFFECTED FILES autotes

D25484: Enable closing a tab by middle click

bdbai added a comment. In D25484#567258 , @ngraham wrote: > Yes this helps the case that @pino brings up, but it handles a different use case. Most of the time a tab won't have unsaved changes because Okular is primarily a reading app. An "Undo

D25484: Enable closing a tab by middle click

bdbai added a comment. In D25484#566490 , @pino wrote: > ... > > In D25484#566483 , @romangg wrote: > > > The solution to accidentally clicks is not disabling it by default and making it configu

D25484: Enable closing a tab by middle click

bdbai added a comment. In D25484#567076 , @aacid wrote: > ... > Also please remember to use invent.kde.org and not phabricator for okular merge requests May I know what the difference is between posting a diff patch here and making a

D25484: Enable closing a tab by middle click

bdbai added a comment. In D25484#566993 , @ngraham wrote: > @bdbai, to move this forward, do you think you could also make tab closing undoable? It is possible. However, before getting down to implement it, I am not sure if anyone else a

D25484: Enable closing a tab by middle click

bdbai created this revision. bdbai added a reviewer: VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. bdbai requested review of this revision. REVISION SUMMARY In some applications like Chromium or Dolphin, it is possible to use middle click to close a tab. This pat