D21363: Fix build with poppler < 0.51

2019-06-24 Thread Alexander Volkov
volkov abandoned this revision. volkov added a comment. It's specific only for AstraLinux. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21363 To: volkov, #okular, sander Cc: yurchor, aacid, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen

D17481: Use lambdas instead of QSignalMapper

2019-06-10 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D17481 To: volkov, #okular, aacid Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21363: Fix build with poppler < 0.51

2019-05-25 Thread Alexander Volkov
volkov added a comment. My OS (AstraLinux) is based on Debian stretch and has poppler 0.48, Qt 5.11, KF5 5.46. And probably it will be a headache to update poppler on it, cause it's rather low-level library (cups-filters depends on it). REPOSITORY R223 Okular REVISION DETAIL https://p

D21363: Fix build with poppler < 0.51

2019-05-23 Thread Alexander Volkov
volkov added reviewers: Okular, sander. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21363 To: volkov, #okular, sander Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21320: Fix build with poppler < 0.51

2019-05-23 Thread Alexander Volkov
volkov added a comment. Sorry. I didn't add #include to formfields.h. Correct fix: D21363 . REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: aacid, joaonetto, okular-devel, tfella, ngraham, da

D21363: Fix build with poppler < 0.51

2019-05-23 Thread Alexander Volkov
volkov created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. volkov requested review of this revision. REPOSITORY R223 Okular BRANCH Applications/19.04 REVISION DETAIL https://phabricator.kde.org/D21363 AFFECTED FILES generators/poppler/formfiel

D21320: Fix build with poppler < 0.51

2019-05-22 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21320: Fix build with poppler < 0.51

2019-05-21 Thread Alexander Volkov
volkov added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21320: Fix build with poppler < 0.51

2019-05-21 Thread Alexander Volkov
volkov created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. volkov requested review of this revision. REPOSITORY R223 Okular BRANCH Applications/19.04 REVISION DETAIL https://phabricator.kde.org/D21320 AFFECTED FILES generators/poppler/formfiel

D14655: Reimplement signature form field and related utility classes in poppler generator

2019-05-21 Thread Alexander Volkov
volkov added inline comments. INLINE COMMENTS > formfields.h:134 > +private: > +Poppler::FormFieldSignature * m_field; > +mutable PopplerSignatureInfo *m_info; It's available since poppler 0.51, so this change broke build with older versions. REPOSITORY R223 Okular REVIS

D17481: Use lambdas instead of QSignalMapper

2018-12-10 Thread Alexander Volkov
volkov added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D17481 To: volkov, #okular Cc: okular-devel, ngraham, darcyshen, aacid

D17481: Use lambdas instead of QSignalMapper

2018-12-10 Thread Alexander Volkov
volkov created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. volkov requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D17481 AFFECTED FILES core/audioplayer.cpp core/audioplayer