Re: Review Request 130022: Remove kactivities on windows, Part II

2017-03-17 Thread Albert Vaca Cintora
27;ve added it an pushed on your behalf. - Albert Vaca Cintora On March 17, 2017, 5:58 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 130022: Remove kactivities on windows, Part II

2017-03-17 Thread Albert Vaca Cintora
lbert Vaca Cintora On mar. 16, 2017, 1:23 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126378: remove kactivities on windows

2017-03-16 Thread Albert Vaca Cintora
gt; +#endif > m_recent->addUrl( url ); > } > else > > Albert Astals Cid wrote: > Oliver please open a new review request if you think this is worthwhile. > > Oliver Sander wrote: >

Re: Review Request 126378: remove kactivities on windows

2017-03-16 Thread Albert Vaca Cintora
> On mar. 11, 2017, 9:53 a.m., Albert Astals Cid wrote: > > Patch doesn't apply to master. > > Oliver Sander wrote: > Updated patch: (sorry for posting as text; I am not allowed to do a real > patch update) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 2f75a9f1..c08f

Re: [Okular-devel] Review Request 127042: Fix QUrl string encoding

2016-02-26 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127042/#review92804 --- Ship it! Looks good to me. - Albert Vaca Cintora On