D20405: Make preview(dashed rectangle) of rectangle annotation colorful

ahmedbilal added a reviewer: sander. REPOSITORY R223 Okular BRANCH make_preview_rect_colorful REVISION DETAIL https://phabricator.kde.org/D20405 To: ahmedbilal, ngraham, sander Cc: ngraham, sander, okular-devel, joaonetto, tfella, darcyshen, aacid

D20405: Make preview(dashed rectangle) of rectangle annotation colorful

ahmedbilal removed a reviewer: sander. REPOSITORY R223 Okular BRANCH make_preview_rect_colorful REVISION DETAIL https://phabricator.kde.org/D20405 To: ahmedbilal, ngraham Cc: ngraham, sander, okular-devel, joaonetto, tfella, darcyshen, aacid

D20437: Make selection scrolling go at 60 fps

ahmedbilal added a comment. Selection scrolling look super cool. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular Cc: ahmedbilal, okular-devel, kezik, joaonetto, tfella, ngraham, darcyshen, aacid

D20351: Improve Legibility of preview of rectangle annotation

ahmedbilal abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular-devel, ngraham Cc: sander, aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen

D20351: Improve Legibility of preview of rectangle annotation

ahmedbilal retitled this revision from "Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle" to "Improve Legibility of preview of rectangle annotation". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal,

D20405: Make preview(dashed rectangle) of rectangle annotation colorful

ahmedbilal added a comment. @sander I have added you as reviewer and subscriber. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20405 To: ahmedbilal, sander Cc: sander, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20405: Make preview(dashed rectangle) of rectangle annotation colorful

ahmedbilal edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20405 To: ahmedbilal Cc: sander, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20405: Make preview(dashed rectangle) of rectangle annotation colorful

ahmedbilal added a reviewer: sander. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20405 To: ahmedbilal, sander Cc: sander, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20405: Make preview(dashed rectangle) of rectangle annotation colorful

ahmedbilal added subscribers: sander, Okular. Herald removed a subscriber: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20405 To: ahmedbilal Cc: sander, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20405: Make preview(dashed rectangle) of rectangle annotation colorful

ahmedbilal created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ahmedbilal requested review of this revision. REPOSITORY R223 Okular BRANCH make_preview_rect_colorful REVISION DETAIL https://phabricator.kde.org/D20405 AFFECTED FILES ui/pageview

D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

ahmedbilal added a comment. In D20351#446620 , @sander wrote: > Consider splitting the color change into a separate patch. That part seems to be uncontroversial. > > The problem with the '3' is that its perceived thickness depends on your s

D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

ahmedbilal added a comment. In D20351#446498 , @sander wrote: > I like the color part of this patch. > > As for the line width: As mentioned, '3' is arbitrary. You need to find a width that takes current dpi into account. Ideally, the widt

D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

ahmedbilal added a comment. In D20351#445682 , @ngraham wrote: > In D20351#445664 , @aacid wrote: > > > 3 is an arbitrary width, so -1 for this change > > > I'm not a huge fan either, but not be

D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

ahmedbilal retitled this revision from "Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen." to "Improve Legibility of preview of rectangle annotation and make it same color as resul

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal added a comment. Before F6758346: image.png After F6758354: image.png Result in both cases F6758349: image.png Note, that the preview of rectangle is the

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal added a reviewer: ngraham. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular-devel, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular-devel Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal added reviewers: Okular, okular-devel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular-devel Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ahmedbilal requested review of this revision. REPOSITORY R223 Okular BRANCH rectangle_preview_improved REVISION DETAIL https://phabricator.kde.org/D20351 AFFECTED FILES ui/pageview

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal removed a reviewer: Okular. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal removed a reviewer: okular-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular, okular-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added reviewers: Okular, okular-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular, okular-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns