[frameworks-kguiaddons] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

https://bugs.kde.org/show_bug.cgi?id=424961 Ahmad Samir changed: What|Removed |Added Assignee|okular-devel@kde.org|kdelibs-b...@kde.org Component|general

[okular] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

https://bugs.kde.org/show_bug.cgi?id=424961 Ahmad Samir changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[okular] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

https://bugs.kde.org/show_bug.cgi?id=424961 Ahmad Samir changed: What|Removed |Added Version Fixed In||5.84 Latest Commit

[okular] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

https://bugs.kde.org/show_bug.cgi?id=424961 Ahmad Samir changed: What|Removed |Added CC||sergioaovale...@gmail.com --- Comment #5 from

[okular] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

https://bugs.kde.org/show_bug.cgi?id=424961 Ahmad Samir changed: What|Removed |Added Status|REPORTED|ASSIGNED CC

[okular] [Bug 436808] Okular crashes when closing it.

https://bugs.kde.org/show_bug.cgi?id=436808 Ahmad Samir changed: What|Removed |Added Resolution|--- |FIXED Latest Commit

[okular] [Bug 426976] Okular mangles url fragment if the it contains a '.'

https://bugs.kde.org/show_bug.cgi?id=426976 --- Comment #2 from Ahmad Samir --- Is the anchor part of a url only relevant to pdf's? if that is the case then we could check for the index of ".pdf" and if the # is before it, it's part of the filename otherwise is a legit url fr

[okular] [Bug 426976] Okular mangles url fragment if the it contains a '.'

https://bugs.kde.org/show_bug.cgi?id=426976 Ahmad Samir changed: What|Removed |Added Summary|kioclient5 exec / kde-open5 |Okular mangles url fragment

[okular] [Bug 426976] kioclient5 exec / kde-open5 with URL fragment on PDF

https://bugs.kde.org/show_bug.cgi?id=426976 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Status|REPORTED

[okular] [Bug 421469] [Regression] Slow search in the contents pane

https://bugs.kde.org/show_bug.cgi?id=421469 --- Comment #8 from Ahmad Samir --- It turns out that the issue was in how itemMatches() was being called; it was being called too many times. A proposed fix: https://invent.kde.org/kde/okular/-/merge_requests/166 -- You are receiving this mail

[okular] [Bug 421469] [Regression] Slow search in the contents pane

https://bugs.kde.org/show_bug.cgi?id=421469 --- Comment #7 from Ahmad Samir --- Indeed it is slower... reverting the changes in KTreeViewSearchLine::itemMatches() restores the old behaviour. I am looking at it, so far I don't see anything obvious, other than that QRegExp::FixedString has

D25684: [core/*] replace foreach, deprecated, with range-for

ahmadsamir abandoned this revision. ahmadsamir added a comment. Created a pull request on invent.kde.org. https://invent.kde.org/kde/okular/merge_requests/73 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25684 To: ahmadsamir, aacid Cc: okular-devel, johnzh, andisa,

D25684: [core/*] replace foreach, deprecated, with range-for

ahmadsamir added a comment. Trying to land this diff I get these errors: remote: FATAL: W refs/heads/master okular ahmadsamir DENIED by refs/.* remote: error: hook declined to update refs/heads/master To git.kde.org:okular ! [remote rejected] c63256c8d18f7f2798019554d62e

D25684: [core/*] replace foreach, deprecated, with range-for

ahmadsamir added a comment. Ping REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25684 To: ahmadsamir, aacid Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25684: [core/*] replace foreach, deprecated, with range-for

ahmadsamir updated this revision to Diff 70945. ahmadsamir added a comment. Rebase. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25684?vs=70874&id=70945 BRANCH l-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D25684 AFFEC

D25684: [core/*] replace foreach, deprecated, with range-for

ahmadsamir added a comment. In D25684#572361 , @aacid wrote: > Please rebase your patch on current master, since it will fail to merge properly, i prefer you do the work and not me ^_^ FWIW, I always 'git pull --rebase' on the branch righ

D25684: [core/*] replace foreach, deprecated, with range-for

ahmadsamir added inline comments. INLINE COMMENTS > aacid wrote in document.cpp:3920 > don't do const & for basic types, it's cheaper to copy them than to reference > them Thanks. Noted. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25684 To: ahmadsamir, aacid Cc: o

D25684: [core/*] replace foreach, deprecated, with range-for

ahmadsamir updated this revision to Diff 70874. ahmadsamir marked 7 inline comments as done. ahmadsamir added a comment. ::distanceSqr() is going to be made const, so qAsConst isn't needed It's cheaper to copy basic types than reference them qAsConst isn't needed when iterating over member

D25684: [core/*] replace foreach, deprecated, with range-for

ahmadsamir created this revision. ahmadsamir added a reviewer: aacid. Herald added a project: Okular. ahmadsamir requested review of this revision. REVISION SUMMARY The code compiles and okular seems to load and work as before, all unit tests pass except (parttest and epubgeneratortest, but th

[okular] [Bug 355399] make # of recent files configurable

https://bugs.kde.org/show_bug.cgi?id=355399 Ahmad Samir changed: What|Removed |Added Component|general |general Assignee|kdelibs-b...@kde.org

[Okular-devel] [Bug 261538] KXMLGUIClient memory corruption warning

https://bugs.kde.org/show_bug.cgi?id=261538 Ahmad Samir changed: What|Removed |Added CC||ahmadsamir3...@gmail.com -- Configure