[okular] [Bug 414474] [Feature Request] Highlighter, double click

2019-11-25 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=414474 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Severity|normal

D25484: Enable closing a tab by middle click

2019-11-25 Thread Nathaniel Graham
ngraham added a comment. I think we can assume that, but check in the code. I don't think we necessarily need to save anything in memory except the URL for the document shown in the closed tab. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25484 To: bdbai, #vdg Cc

D25484: Enable closing a tab by middle click

2019-11-25 Thread Bob Bai
bdbai added a comment. In D25484#567258 , @ngraham wrote: > Yes this helps the case that @pino brings up, but it handles a different use case. Most of the time a tab won't have unsaved changes because Okular is primarily a reading app. An "Undo

D25484: Enable closing a tab by middle click

2019-11-25 Thread Nathaniel Graham
ngraham added a comment. In D25484#567112 , @bdbai wrote: > In D25484#566490 , @pino wrote: > > > ... > > > > In D25484#566483 , @romangg wrote: > >

D25484: Enable closing a tab by middle click

2019-11-25 Thread Bob Bai
bdbai added a comment. In D25484#566490 , @pino wrote: > ... > > In D25484#566483 , @romangg wrote: > > > The solution to accidentally clicks is not disabling it by default and making it configu