D25484: Enable closing a tab by middle click

2019-11-23 Thread David Hurka
davidhurka added a comment. To prevent some accidental middle-mouse-clicks on the tab bar, we could lock the cursor while middle-mouse-button-zoom. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25484 To: bdbai, #vdg Cc: davidhurka, ngraham, romangg, ndavis, pino, o

[frameworks-kio] [Bug 414410] "Open containing folder feature" using KIO::highlightInFileManager() does not work in Windows

2019-11-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=414410 Nate Graham changed: What|Removed |Added CC||kdelibs-b...@kde.org Summary|"Open con

[okular] [Bug 414410] "Open containing folder feature using KIO::highlightInFileManager does not work in W10

2019-11-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=414410 Nate Graham changed: What|Removed |Added CC||n...@kde.org Summary|Open containing f

D25484: Enable closing a tab by middle click

2019-11-23 Thread Nathaniel Graham
ngraham added a comment. In D25484#566477 , @pino wrote: > > Do people frequently misclick with the middle mouse button? > > It can happen, and more often with a touchpad. I assume you're talking about Libinput's virtual middle mouse b

D25484: Enable closing a tab by middle click

2019-11-23 Thread Noah Davis
ndavis added a comment. In D25484#566490 , @pino wrote: > In D25484#566482 , @ndavis wrote: > > > In D25484#566477 , @pino wrote: > > > > > > Do people f

D25484: Enable closing a tab by middle click

2019-11-23 Thread Pino Toscano
pino added a comment. In D25484#566482 , @ndavis wrote: > In D25484#566477 , @pino wrote: > > > > Do people frequently misclick with the middle mouse button? > > > > It can happen, and more often

D25484: Enable closing a tab by middle click

2019-11-23 Thread Noah Davis
ndavis added a comment. In D25484#566483 , @romangg wrote: > The solution to accidentally clicks is not disabling it by default and making it configurable, but providing the functionality to "restore" a tab after closing it accidentally. Dolphin

D25484: Enable closing a tab by middle click

2019-11-23 Thread Roman Gilg
romangg added a comment. The solution to accidentally clicks is not disabling it by default and making it configurable, but providing the functionality to "restore" a tab after closing it accidentally. Dolphin and Chrome allow me to restore the last closed tab with Alt+Shift+T. Does Okular t

D25484: Enable closing a tab by middle click

2019-11-23 Thread Noah Davis
ndavis added a comment. In D25484#566477 , @pino wrote: > > Do people frequently misclick with the middle mouse button? > > It can happen, and more often with a touchpad. I hadn't considered that. By default, you have to tap with 3 fin

D25484: Enable closing a tab by middle click

2019-11-23 Thread Pino Toscano
pino added a comment. > Do people frequently misclick with the middle mouse button? It can happen, and more often with a touchpad. > Most applications with non-permanent tabs allow tabs to be closed with MMB without an option to disable the feature. If it's not a problem for Firefox

D25484: Enable closing a tab by middle click

2019-11-23 Thread Noah Davis
ndavis added a comment. In D25484#566470 , @pino wrote: > Please make it configurable, and off by default (otherwise it is too easy to mis-click and close a document). Do people normally misclick with the middle mouse button? Most applic

D25484: Enable closing a tab by middle click

2019-11-23 Thread Pino Toscano
pino added a comment. Please make it configurable, and off by default (otherwise it is too easy to mis-click and close a document). REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25484 To: bdbai, #vdg Cc: pino, okular-devel, johnzh, andisa, siddharthmanthan, maguir

D25484: Enable closing a tab by middle click

2019-11-23 Thread Bob Bai
bdbai created this revision. bdbai added a reviewer: VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. bdbai requested review of this revision. REVISION SUMMARY In some applications like Chromium or Dolphin, it is possible to use middle click to close a tab. This pat