[okular] [Bug 411374] search on continuous view often mispositions search for non-last column

2019-08-27 Thread Dave Gilbert
https://bugs.kde.org/show_bug.cgi?id=411374 --- Comment #2 from Dave Gilbert --- Created attachment 122396 --> https://bugs.kde.org/attachment.cgi?id=122396&action=edit result of searching for Bottom of page 1 when previously on page 3 -- You are receiving this mail because: You are the assi

[okular] [Bug 411374] search on continuous view often mispositions search for non-last column

2019-08-27 Thread Dave Gilbert
https://bugs.kde.org/show_bug.cgi?id=411374 --- Comment #1 from Dave Gilbert --- Created attachment 122395 --> https://bugs.kde.org/attachment.cgi?id=122395&action=edit example pdf -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 411374] New: search on continuous view often mispositions search for non-last column

2019-08-27 Thread Dave Gilbert
https://bugs.kde.org/show_bug.cgi?id=411374 Bug ID: 411374 Summary: search on continuous view often mispositions search for non-last column Product: okular Version: unspecified Platform: Other OS: Linux

D21202: [WIP] Support animated PDF

2019-08-27 Thread Joao Oliveira
joaonetto abandoned this revision. joaonetto added a comment. This was merged on invent.kde.org. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21202 To: joaonetto, aacid, #okular Cc: pino, anthonyfieroni, sander, okular-devel, andisa, siddharthmanthan, maguirre, fb

D23421: Add "find in this document" to selection context menu

2019-08-27 Thread Andi Sardina Ramos
andisa edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23421 To: andisa, #okular Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

2019-08-27 Thread Andi Sardina Ramos
andisa marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23421 To: andisa, #okular Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

2019-08-27 Thread Andi Sardina Ramos
andisa marked 2 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23421 To: andisa, #okular Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

2019-08-27 Thread Andi Sardina Ramos
andisa updated this revision to Diff 64762. andisa added a comment. Adding the "Search for in open document" action in the top level menu. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23421?vs=64540&id=64762 BRANCH search_withing_document (branched fro

D23421: Add "find in this document" to selection context menu

2019-08-27 Thread Nathaniel Graham
ngraham added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D23421 To: andisa, #okular Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid

D23421: Add "find in this document" to selection context menu

2019-08-27 Thread Andi Sardina Ramos
andisa removed a reviewer: Okular. andisa added inline comments. INLINE COMMENTS > ngraham wrote in pageview.cpp:4371 > This grammar change makes it wrong for all the other entries. > > Maybe the new "Search for in open document" menu item should be in the > base level of the context menu, and

[okular] [Bug 410844] Okular segfault

2019-08-27 Thread Tobias Deiminger
https://bugs.kde.org/show_bug.cgi?id=410844 Tobias Deiminger changed: What|Removed |Added Resolution|--- |UPSTREAM Status|CONFIRMED

D23421: Add "find in this document" to selection context menu

2019-08-27 Thread Nathaniel Graham
ngraham added a comment. Works great. I have some UI suggestions below: INLINE COMMENTS > pageview.cpp:4371 > const QString squeezedText = KStringHandler::rsqueeze( > searchText, 21 ); > -webShortcutsMenu->setTitle( i18n( "Search for '%1' with", > squeezedText ) );

[okular] [Bug 410844] Okular segfault

2019-08-27 Thread Jonathan Riddell
https://bugs.kde.org/show_bug.cgi?id=410844 --- Comment #18 from Jonathan Riddell --- I've added this patch to qt in neon -- You are receiving this mail because: You are the assignee for the bug.