[okular] [Bug 386578] Request: Allow annotation mode to "stick" for better use with a stylus

2019-07-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=386578 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail beca

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-07-22 Thread Albert Astals Cid
aacid commandeered this revision. aacid added a reviewer: sander. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D17929 To: aacid, #okular, sander Cc: davidhurka, aacid, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-07-22 Thread Albert Astals Cid
aacid abandoned this revision. aacid added a comment. Abandoing this since it's now on https://invent.kde.org/kde/okular/merge_requests/9/diffs REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D17929 To: aacid, #okular, sander Cc: davidhurka, aacid, ngraham, okular-dev

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22617#500369 , @davidhurka wrote: > Making the parts with background color transparent would be better, right? That would even work on systems which don’t access the stylesheet. Not necessarily. In Breeze, the

D22064: General improvements to stamp annotation

2019-07-22 Thread Simone Gaiarin
simgunz marked an inline comment as done. simgunz added a comment. In D22064#498964 , @aacid wrote: > Small code improvements that can be ignored if you want. Fixed, and thanks for pointing out my bad style practices. I also like clean co

D22064: General improvements to stamp annotation

2019-07-22 Thread Simone Gaiarin
simgunz updated this revision to Diff 62335. simgunz marked 7 inline comments as done. simgunz added a comment. - Move to init list - Add translation context - Use new connect syntax - Add tooltip to custom stamp button REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabri

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread David Hurka
davidhurka added a comment. In D22617#500361 , @ndavis wrote: > In D22617#500346 , @davidhurka wrote: > > > - Why does the stylesheet need a background? > > > You only need to add the classes t

D21376: RFC: In annotations list show highlighted text

2019-07-22 Thread David Hurka
davidhurka added a comment. This would help to fix/implement bug 377886. The missing part is tweaking the search field above the annotation tree view. https://bugs.kde.org/show_bug.cgi?id=377886 Store text along with annotations like highlight, underline and squiggle @jangmarker Are

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22617#500346 , @davidhurka wrote: > By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I ca

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread Nathaniel Graham
ngraham added a comment. These versions look great to me now. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread David Hurka
davidhurka added a comment. By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I can understand it. - Why does the stylesheet need a background? - How are the co

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread David Hurka
davidhurka updated this revision to Diff 62332. davidhurka added a comment. - Adapt view-pages-facing and -facing-first-centered to use ndavis' suggested files REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62294&id=62332 BRANCH add-icons-

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-22 Thread David Hurka
davidhurka retitled this revision from "Add icons for pagelayout options, as needed in Okular" to "Add view-pages-* icons, as needed in Okular for page layout selection". davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D15580: [WIP] New annotation toolbar

2019-07-22 Thread Simone Gaiarin
simgunz added a comment. > Do you have to move this to gitlab anyway? I do not plan to move it given that all the discussion was done here, and that I have not yet seen an official guide regarding the review requests through gitlab. REPOSITORY R223 Okular REVISION DETAIL https://ph

D15580: [WIP] New annotation toolbar

2019-07-22 Thread Luigi Toscano
ltoscano added a comment. In D15580#500275 , @davidhurka wrote: > In D15580#500264 , @simgunz wrote: > > > @davidhurka Thanks for looking up the bug numbers > > > > Do you know if adding the bug

D15580: [WIP] New annotation toolbar

2019-07-22 Thread David Hurka
davidhurka added a comment. In D15580#500264 , @simgunz wrote: > @davidhurka Thanks for looking up the bug numbers > > Do you know if adding the bug numbers separated by a comma without repeating the keyword BUG would work? Probably n

D15580: [WIP] New annotation toolbar

2019-07-22 Thread Simone Gaiarin
simgunz added a comment. @davidhurka Thanks for looking up the bug numbers Do you know if adding the bug numbers separated by a comma without repeating the keyword BUG would work? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: cfe

D15580: [WIP] New annotation toolbar

2019-07-22 Thread Simone Gaiarin
simgunz edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

D15580: [WIP] New annotation toolbar

2019-07-22 Thread Simone Gaiarin
simgunz edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen

[okular] [Bug 410108] Two Okular launchers with the same name

2019-07-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=410108 --- Comment #2 from Albert Astals Cid --- > Because i don't think renaming Okularkirigami to Okular (Kirigami) is weird i > guess since that's not the name we want it to show on Plasma Mobile Sorry, i meant "i think it's weird renaming Okularkirigami"

D15580: [WIP] New annotation toolbar

2019-07-22 Thread Simone Gaiarin
simgunz updated this revision to Diff 62320. simgunz added a comment. - Check if chosen color is valid before storing it - Notify PageViewAnnotator when the color has changed - Add missing annotation tools actions - Add XML annotation tools and connect corresponding actions - Add typewr

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment. In D22617#500212 , @ndavis wrote: > In D22617#500031 , @davidhurka wrote: > > > I can’t follow you here. Centering the first page is a feature / technical detail of Okula

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22617#500168 , @davidhurka wrote: > Other icons with fold in the bottom I could find: > > - document-duplicate > - document-revert-symbolic[-rtl] > - kt-restore-defaults > - password-copy > - viewpdf > -

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread Noah Davis
ndavis added a comment. In D22617#500031 , @davidhurka wrote: > Makes sense, so I’m flipping snap-page now. Is that written down somewhere? Nope, it was recently decided, but I've had that in the back of my mind for a while. > Previ

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread Nathaniel Graham
ngraham added a comment. In D22617#500141 , @davidhurka wrote: > In D22617#500131 , @ndavis wrote: > > > I'll give the latest changes a proper review in a little while. > > > > In D22617#500046 <

D15580: [WIP] New annotation toolbar

2019-07-22 Thread David Hurka
davidhurka added a comment. You could consider to add these bugs as BUG keywords to this patch: 386578, 374728, 352310, 330518, 341914, 157289 - https://bugs.kde.org/show_bug.cgi?id=386578 Allow annotation mode to "stick" for better use with a stylus - https://bugs.kde.org/show_bug.cgi

[okular] [Bug 386578] Request: Allow annotation mode to "stick" for better use with a stylus

2019-07-22 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=386578 --- Comment #2 from David Hurka --- *** Bug 358057 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 358057] [Usability] Permanent/sticky annotation feature is hard to discover

2019-07-22 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=358057 David Hurka changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[okular] [Bug 410108] Two Okular launchers with the same name

2019-07-22 Thread mthw0
https://bugs.kde.org/show_bug.cgi?id=410108 mthw0 changed: What|Removed |Added CC||aro...@archlinux.org, |

[okular] [Bug 410108] Two Okular launchers with the same name

2019-07-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=410108 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org, |

Re: Single page forward/backward step in 2 page view?

2019-07-22 Thread Petra Roosen
Hello @all, some weeks ago (Vol 154, Issue 15) I posted a request for a feature change: to differentiate between "single page forward/back" and "complete view forward/back" in a two-paged side-by-side display. This is important for musical scores displays, as the paging should support an "overlapp

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment. In D22617#499767 , @ndavis wrote: > Nice work! > > I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right

[okular] [Bug 410108] New: Two Okular launchers with the same name

2019-07-22 Thread mthw0
https://bugs.kde.org/show_bug.cgi?id=410108 Bug ID: 410108 Summary: Two Okular launchers with the same name Product: okular Version: 1.7.80 Platform: Archlinux Packages OS: Linux Status: REPORTED Severity:

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment. In D22617#500131 , @ndavis wrote: > I'll give the latest changes a proper review in a little while. > > In D22617#500046 , @davidhurka wrote: > > > What is the icons-d

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread Noah Davis
ndavis added a comment. I'll give the latest changes a proper review in a little while. In D22617#500046 , @davidhurka wrote: > What is the icons-dark directory good for? The icons in there are mostly just the same as in icons. Non-

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment. What is the icons-dark directory good for? The icons in there are mostly just the same as in icons. And I’m a bit concerned that scour-icon removes the id="currentColorScheme" attribute from the stylesheet. How do I avoid that? REPOSITORY R266 Breeze Icons

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka updated this revision to Diff 62294. davidhurka added a comment. - Rename pagelayout-* to view-pages-* REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62293&id=62294 BRANCH add-icons-for-pagelayouts REVISION DETAIL https://phab

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka updated this revision to Diff 62293. davidhurka added a comment. - Remove 24px icons - Flip snap-page icons vertically, so the corner fold is at the top-right - Make pagelayout-single link to snap-page - Flip pagelayout-* icons, except pagelayout-single REPOSITORY R266 Breez

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-22 Thread David Hurka
davidhurka added a comment. In D22617#499767 , @ndavis wrote: > Nice work! > > I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom