D22064: General improvements to stamp annotation

simgunz added a comment. F6929689: Screenshot_20190624_081508.png Okular embedded stamp F6929691: Screenshot_20190624_081534.png File chooser filters F6929694: Screenshot_20190624_081738.png

D22064: General improvements to stamp annotation

simgunz added a task: T8074: Make custom stamp image support more discoverable. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D22064: General improvements to stamp annotation

simgunz edited the summary of this revision. simgunz edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D22064: General improvements to stamp annotation

simgunz created this revision. simgunz added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. simgunz requested review of this revision. REVISION SUMMARY Configuration: - Add push button to select custom stamp image - Check if loaded image is us

D10859: Improve layout of annotation configuration dialogs

simgunz added a comment. @sander Thanks. It worked. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham, aacid Cc: sander, davidhurka, aacid, okular-devel, knambiar, ngraham, fbampaloukas, joaonetto, tfella, darcyshen

D10859: Improve layout of annotation configuration dialogs

This revision was automatically updated to reflect the committed changes. Closed by commit R223:a33cb321df12: Improve layout of annotation configuration dialogs (authored by simgunz). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10859?vs=59534&id=60552 REVIS

[okular] [Bug 409013] Fix background color and frame of search result

https://bugs.kde.org/show_bug.cgi?id=409013 --- Comment #13 from Thomas Bingel --- Created attachment 121106 --> https://bugs.kde.org/attachment.cgi?id=121106&action=edit Useless search function It is very difficult to spot where on the image the search function found the search term -- You

[okular] [Bug 409013] Fix background color and frame of search result

https://bugs.kde.org/show_bug.cgi?id=409013 --- Comment #12 from Thomas Bingel --- Professor Sanders from the TU Dresden you are very disappointing! You did not even answer my questions in my last comment to you! Your last outright commentary is quite foolish! Given your last commentary, I truly

[okular] [Bug 409013] Fix background color and frame of search result

https://bugs.kde.org/show_bug.cgi?id=409013 --- Comment #11 from Oliver Sander --- > you seem to have a similar arrogant attitude like Albert Astals Cid! In all politeness, this is not the place for personality judgements -- it is a bug report about highlighting colors. > It is a severe usabili

[okular] [Bug 409013] Fix background color and frame of search result

https://bugs.kde.org/show_bug.cgi?id=409013 --- Comment #10 from Thomas Bingel --- Hello Yuri, you seem to have a similar arrogant attitude like Albert Astals Cid! It is a severe usability bug in Okular rendering the search function useless. Why don't you use your brain a little bit more instead

D21266: [WIP] Improve documentation of area classes

davidhurka updated this revision to Diff 60536. davidhurka added a comment. - Describe consequences of negative width/height - Add note to RegularArea::contains() concerning simplify() REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21266?vs=60388&id=60536

D21266: [WIP] Improve documentation of area classes

davidhurka marked 14 inline comments as done. REPOSITORY R223 Okular BRANCH improve-area-classes-documentation REVISION DETAIL https://phabricator.kde.org/D21266 To: davidhurka, #okular, aacid Cc: aacid, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen

D17929: Hide cursor when tablet stylus leaves proximity of the screen

sander added a comment. I've been wondering whether it would be possible to write a unit test that sends out all the necessary events. That would allow to debug the problem without actually having the required hardware. Is that possible in principle? REPOSITORY R223 Okular REVISION DETAI

D17929: Hide cursor when tablet stylus leaves proximity of the screen

davidhurka added a comment. Not sure, but that one looks like the inductive stylus I once had. (That one worked pretty bad.) Inductive coupling becomes better as the tip advances the screen surface. -> Proximity detection. When the surface applies pressure to the tip, it squeezes an el

D10859: Improve layout of annotation configuration dialogs

sander added a comment. I had the same problem yesterday and got around it by moving to https://invent.kde.org/kde/okular . REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham, aacid Cc: sander,

D10859: Improve layout of annotation configuration dialogs

simgunz added a comment. Tried to land this, but I got this error message: remote: FATAL: W refs/heads/master okular gaiarin DENIED by refs/.* remote: error: hook declined to update refs/heads/master To git.kde.org:okular ! [remote rejected] 6ee24b04e911da577f23a139c19e8

D17929: Hide cursor when tablet stylus leaves proximity of the screen

sander added a comment. Albert, David, thanks for looking into this -- the problem seems to be a beyond my skill level. My hardware is a Lenovo Thinkpad Yoga, as in http://www.notebookreview.com/notebookreview/lenovo-thinkpad-yoga-12-review/ . I am not a stylus expert, said review calls it

D10859: Improve layout of annotation configuration dialogs

simgunz edited the summary of this revision. REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham, aacid Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, fbampaloukas, joaonetto, tfell

D21271: Improve documentation of TextEntity stuff

davidhurka retitled this revision from "[WIP] Improve documentation of TextEntity stuff" to "Improve documentation of TextEntity stuff". REPOSITORY R223 Okular BRANCH improve-documentation-of-textentity-stuff REVISION DETAIL https://phabricator.kde.org/D21271 To: davidhurka, #okular, aac

D21271: [WIP] Improve documentation of TextEntity stuff

davidhurka marked 2 inline comments as done. REPOSITORY R223 Okular BRANCH improve-documentation-of-textentity-stuff REVISION DETAIL https://phabricator.kde.org/D21271 To: davidhurka, #okular, aacid Cc: aacid, yurchor, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen

D21271: [WIP] Improve documentation of TextEntity stuff

davidhurka marked 11 inline comments as done. davidhurka added a comment. In D21271#485445 , @aacid wrote: > You don't have a committer account, right? No. INLINE COMMENTS > aacid wrote in textpage.h:168 > concatenate = to put things tog

[okular] [Bug 409013] Fix background color and frame of search result

https://bugs.kde.org/show_bug.cgi?id=409013 Yuri Chornoivan changed: What|Removed |Added CC||yurc...@ukr.net --- Comment #9 from Yuri Chor

D17929: Hide cursor when tablet stylus leaves proximity of the screen

davidhurka added a comment. AFAIK these events are only generated for inductive styluses, because a capacitive touchscreen can’t detect proximity with acceptable quality, even less for a stylus. So what kind of stylus/touchscreen do you use, @sander? REPOSITORY R223 Okular REVISION D

[okular] [Bug 409013] Fix background color and frame of search result

https://bugs.kde.org/show_bug.cgi?id=409013 Thomas Bingel changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOT A BUG

D21759: Hold zoom center below center/mouse position

aacid added a comment. > Do you mean it should always try to scroll where the zoom was triggered the first time after Ctrl was pressed the last time? That is what i was expecting this to do yes, if it's supposed to center on the mouse position, it should do that regardless of if there we

D21271: [WIP] Improve documentation of TextEntity stuff

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Thanks for putting up with me. You don't have a committer account, right? INLINE COMMENTS > davidhurka wrote in textpage.h:168 > How do you get from concatenate to append? > > I’m not t

D21759: Hold zoom center below center/mouse position

davidhurka added a comment. In D21759#484966 , @aacid wrote: > In D21759#484499 , @steffenh wrote: > > > Hi @aacid, > > thanks for testing, > > > > > Also it doesn't work? or not how i would e

D17929: Hide cursor when tablet stylus leaves proximity of the screen

aacid added a comment. Hey, i just realized that i have a laptop with a touchscreen and a stylus and tried to test this to see if i could fix the missing bits. But i never get the TabletEnterProximity/TabletLeaveProximity events. I guess i have not configured the stylus properly?

D21759: Hold zoom center below center/mouse position

aacid added a comment. In D21759#484499 , @steffenh wrote: > Hi @aacid, > thanks for testing, > > > Also it doesn't work? or not how i would expect it? > > > > I'm doing ctrl+wheel zoom here with the mouse over the a and ends up being

D21759: Hold zoom center below center/mouse position

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, now it doesn't work for me anymore. It zooms in to a location near the cursor/center pinch point, but not exactly there. REPOSITORY R223 Okular REVISION DETAIL https:/