D15580: New annotation toolbar

2019-06-17 Thread Simone Gaiarin
simgunz added a comment. In D15580#481323 , @davidhurka wrote: > Don’t have UI feedback that asks for action already in this patch. :) > > In D15580#481270 , @simgunz wrote: > > > F6902170: Scre

[okular] [Bug 408683] blank page until I scroll

2019-06-17 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=408683 --- Comment #3 from Albert Astals Cid --- Do you have a hidpi screen? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408849] okular crashes scrolling through certain pdf

2019-06-17 Thread Tobias Deiminger
https://bugs.kde.org/show_bug.cgi?id=408849 Tobias Deiminger changed: What|Removed |Added CC||haxti...@posteo.de Ever confirmed|0

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

2019-06-17 Thread Vasyl Teliman
https://bugs.kde.org/show_bug.cgi?id=408818 Vasyl Teliman changed: What|Removed |Added Version|unspecified |1.7.2 -- You are receiving this mail because:

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

2019-06-17 Thread Vasyl Teliman
https://bugs.kde.org/show_bug.cgi?id=408818 --- Comment #6 from Vasyl Teliman --- By the way, I've failed to mention here that it'd worked OK until I've decided to update KDE to 5.16.0 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

2019-06-17 Thread Vasyl Teliman
https://bugs.kde.org/show_bug.cgi?id=408818 --- Comment #5 from Vasyl Teliman --- Created attachment 120959 --> https://bugs.kde.org/attachment.cgi?id=120959&action=edit The file that causes this crash. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

2019-06-17 Thread Vasyl Teliman
https://bugs.kde.org/show_bug.cgi?id=408818 --- Comment #4 from Vasyl Teliman --- (In reply to Elvis Angelaccio from comment #3) > No need to, I changed the product of this one. :) I'm sorry again. It seems I've already sent one :). Here is a link (you might want to mark it as duplicate): https:

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

2019-06-17 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=408818 Elvis Angelaccio changed: What|Removed |Added Product|ark |okular Component|general

[okular] [Bug 408851] New: Crash when trying to open *.fb2 file

2019-06-17 Thread Vasyl Teliman
https://bugs.kde.org/show_bug.cgi?id=408851 Bug ID: 408851 Summary: Crash when trying to open *.fb2 file Product: okular Version: 1.7.2 Platform: Neon Packages OS: Linux Status: REPORTED Keywords: drkonqi

[okular] [Bug 408849] New: okular crashes scrolling through certain pdf

2019-06-17 Thread Peter Hedwig
https://bugs.kde.org/show_bug.cgi?id=408849 Bug ID: 408849 Summary: okular crashes scrolling through certain pdf Product: okular Version: 1.7.2 Platform: Neon Packages OS: Linux Status: REPORTED Keywords:

D15580: New annotation toolbar

2019-06-17 Thread David Hurka
davidhurka added a comment. Don’t have UI feedback that asks for action already in this patch. :) In D15580#481270 , @simgunz wrote: > F6902170: Screenshot_20190617_165440.png - Maybe the

D15580: New annotation toolbar

2019-06-17 Thread Simone Gaiarin
simgunz updated this revision to Diff 60004. simgunz added a comment. - Fix and simplify width action - Fix and simplify opacity action - Fix annotation tools actions - Rename color action - Formatting REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D21195: [RFC] Create a Change Colors menu (with toolbar button)

2019-06-17 Thread David Hurka
davidhurka edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21195 To: davidhurka, #okular, #vdg Cc: GB_2, davidre, aacid, ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-17 Thread Simone Gaiarin
simgunz added a comment. In D21755#481293 , @davidhurka wrote: > In D21755#481269 , @simgunz wrote: > > > Currently I am using ToolAction in the new annotation toolbar to selected among different g

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-17 Thread David Hurka
davidhurka updated this revision to Diff 60002. davidhurka added a comment. - Add license headers Is this correct? REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21755?vs=59958&id=60002 BRANCH create-toggleactionmenu REVISION DETAIL https://phabri

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-17 Thread David Hurka
davidhurka edited the summary of this revision. davidhurka edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21755 To: davidhurka, #okular Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-17 Thread David Hurka
davidhurka added a comment. In D21755#481269 , @simgunz wrote: > Currently I am using ToolAction in the new annotation toolbar to selected among different geometrical annotation. [...] > For this purpose I need that the action are checkable, a

[okular] [Bug 408837] New: Okular crash when opening PDF from Firefox

2019-06-17 Thread George Stevenson
https://bugs.kde.org/show_bug.cgi?id=408837 Bug ID: 408837 Summary: Okular crash when opening PDF from Firefox Product: okular Version: 1.7.2 Platform: Ubuntu Packages OS: Linux Status: REPORTED Keywords:

[okular] [Bug 408834] New: okular (file name) gives error pointing to KDE connect although that is not in use

2019-06-17 Thread rkeating
https://bugs.kde.org/show_bug.cgi?id=408834 Bug ID: 408834 Summary: okular (file name) gives error pointing to KDE connect although that is not in use Product: okular Version: 1.7.2 Platform: Kubuntu Packages

D15580: New annotation toolbar

2019-06-17 Thread Simone Gaiarin
simgunz added a comment. Favorite annotations: The Star adds the currently selected tool to the favorite list, the bookmark symbol displays the list of the favorite tools: F6902170: Screenshot_20190617_165440.png Customize the favorite tools:

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

2019-06-17 Thread Simone Gaiarin
simgunz added a comment. In D21755#480908 , @davidhurka wrote: > From my point of view, this is complete now. 3 TODOs left (see revision description at the top). > > ToolAction used its own tooltip for the toolbar buttons. Tell me if that is