https://bugs.kde.org/show_bug.cgi?id=391625
David Palacio changed:
What|Removed |Added
CC||palacio.torres.david@gmail.
|
joaonetto edited the summary of this revision.
joaonetto edited the test plan for this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21202
To: joaonetto, aacid, #okular
Cc: pino, anthonyfieroni, sander, okular-devel, joaonetto, tfella, ngraham,
darcyshen, aac
joaonetto updated this revision to Diff 59045.
joaonetto edited the test plan for this revision.
joaonetto added a comment.
Updated Diff to track changes based on master
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21202?vs=58984&id=59045
BRANCH
master
davidhurka marked 4 inline comments as done.
davidhurka added inline comments.
INLINE COMMENTS
> aacid wrote in area.h:108
> i don't know, you may want to ask Peter, but it was 6 years ago, i doubt he
> remembers.
>
> What's your problem with it being static?
It would make sense to make it non
ngraham added a comment.
getting there!
UI review of the latest version:
- Having the annotation tools on the main toolbar makes it overflow for all
but the largest window sizes. How about putting them in a secondary toolbar
below the main one that's hidden until the user shows it b
davidhurka marked 10 inline comments as done.
davidhurka added a comment.
I will remove page sizes from member documentations and describe the
coordinate system with a more abstract reference rectangle.
Page sizes and zoom and so on will just be an application of the normalized
coordinat
https://bugs.kde.org/show_bug.cgi?id=408222
Albert Astals Cid changed:
What|Removed |Added
Resolution|--- |WAITINGFORINFO
Status|REPORTED
ngraham added a comment.
Before-and-after screenshots for this would be nice.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21551
To: jbbgameich, #okular
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Job's a good 'un!
REPOSITORY
R223 Okular
BRANCH
drawer-qqc2
REVISION DETAIL
https://phabricator.kde.org/D21550
To: jbbgameich, #okular, ngraham
Cc: ngraham, okular-devel, joaonett
davidhurka retitled this revision from "[RFC] Write Documentation for
Okular::Part" to "[WIP] Write Documentation for Okular::Part".
davidhurka edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21281
To: davidhurka, #okular
Cc: ognarb,
davidhurka marked an inline comment as done.
davidhurka added inline comments.
INLINE COMMENTS
> aacid wrote in textpage_p.h:32
> Ah, you're trying to export already existing functions :D
>
> Didn't realize that.
>
> Why do you want to export them? Yes their are interesting, but where would
>
davidhurka marked 6 inline comments as done.
davidhurka added a comment.
Sometimes I’m working on PageView, but I move it out of this patch because
it’s less related than I thought. And this is enough stuff for a single patch
for now...
INLINE COMMENTS
> davidhurka wrote in part.cpp:1746
>
https://bugs.kde.org/show_bug.cgi?id=408222
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
--- Comment #4 from Albert As
aacid added inline comments.
INLINE COMMENTS
> simgunz wrote in dlgannotationsbase.ui:55
> Yes.
>
> Both Author and Add had 'a' as accelerator. This was actually working.
> Pressing 'a' twice switch between the two.
>
> Nonetheless I changed it to make the accelerators unique.
>
> Initially I
aacid added a comment.
The diff shown here is wrong. We want the diff from your branch against
master, not the last change in your branch against itself
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21202
To: joaonetto, aacid, #okular
Cc: pino, anthonyfieroni, sand
aacid added inline comments.
INLINE COMMENTS
> davidhurka wrote in textpage_p.h:32
> As mentioned somewhere else, the algorithms in these functions are
> interesting. (Besides they don’t do a good job with vertical text. I hope by
> writing documentation I will get some understanding what chang
aacid added a comment.
Some comments.
Anyhow i feel that you asking all these questions over here is weird,
phabricator is terrible for this kind communication and i can't keep up with
the questions you have or the ones i've answered or whatnot.
I really feel this would benefit from
davidhurka marked 4 inline comments as done.
davidhurka added inline comments.
INLINE COMMENTS
> aacid wrote in textpage.cpp:1880
> pagesSizeMetric defines what pagesize means for your generator.
Ok, if it is documented directly in Generator, it should be sufficient. Maybe I
was looking at Page
jbbgameich added a reviewer: Okular.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21549
To: jbbgameich, #okular
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
jbbgameich added a reviewer: Okular.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21550
To: jbbgameich, #okular
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
jbbgameich added a reviewer: Okular.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21551
To: jbbgameich, #okular
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
jbbgameich created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
jbbgameich requested review of this revision.
REVISION SUMMARY
Move the error label to the results grid view, which fixes the layout of the
TextField.
TEST PLAN
TextField and label are
jbbgameich created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
jbbgameich requested review of this revision.
REVISION SUMMARY
Port the drawer to QQC2
TEST PLAN
It still has the same features as before
REPOSITORY
R223 Okular
BRANCH
drawer-qqc2
jbbgameich created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
jbbgameich requested review of this revision.
REVISION SUMMARY
Fixes displaying the Drawer
TEST PLAN
Drawer is visible
REPOSITORY
R223 Okular
BRANCH
fix-final-properties
REVISION
aacid added inline comments.
INLINE COMMENTS
> davidhurka wrote in textpage.cpp:1880
> Looks like I messed up my comments.
>
> > This is some interesting information, which should be documented more
> > visible. Is the information still true?
>
> belongs only to line 1880:
>
> // m_page->wi
https://bugs.kde.org/show_bug.cgi?id=408222
--- Comment #3 from David Hurka ---
Created attachment 120507
--> https://bugs.kde.org/attachment.cgi?id=120507&action=edit
Page 188 in Okular
A friend just told me that this is readable.
However, how does it look different in Evince? It uses the sa
aacid added a comment.
You really need to remove all the mentions of page you're adding, this is
geometry that has nothing to do with pages.
Yes in Okular in 99.99% of the cases it's used in conjunction with a page,
but it is not about pages, it just so happen that most of the needs okul
ognarb added subscribers: jucato, ognarb.
ognarb added a comment.
@jucato This could potentially interest you ;)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21281
To: davidhurka, #okular
Cc: ognarb, jucato, aacid, okular-devel, joaonetto, tfella, ngraham, darcyshe
https://bugs.kde.org/show_bug.cgi?id=408222
--- Comment #2 from yousifjka...@yahoo.com ---
Please take care for this issue because it is very important for those users
that live in 3rd world countries where most of PDF books are scanned not
formatted
--
You are receiving this mail because:
https://bugs.kde.org/show_bug.cgi?id=408222
--- Comment #1 from yousifjka...@yahoo.com ---
Created attachment 120506
--> https://bugs.kde.org/attachment.cgi?id=120506&action=edit
scanned-pdf
--
You are receiving this mail because:
You are the assignee for the bug.
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:d084641c2de3: Fix narrowing conversion in
LineAnnotationWidget::endStyleIcon (authored by tobiasdeiminger).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21543?vs=5
https://bugs.kde.org/show_bug.cgi?id=408222
yousifjka...@yahoo.com changed:
What|Removed |Added
Summary|Okular is bad in|Okular is bad in displaying
El diumenge, 2 de juny de 2019, a les 14:03:17 CEST, Tobias Deiminger va
escriure:
> Am 02.06.2019 12:46 schrieb Albert Astals Cid:
> > Tobias this one is on you :)
>
> Yep, of course :)
>
> > Good luck!
>
> https://phabricator.kde.org/D21543 should do it, but I have no Windows
> development en
https://bugs.kde.org/show_bug.cgi?id=408222
Bug ID: 408222
Summary: Okular is bad in visualization of scanned PDF ! Please
fix this !
Product: okular
Version: unspecified
Platform: Other
OS: Linux
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
just commit and try it
REPOSITORY
R223 Okular
BRANCH
bugfix/lineannoticon_winbuild
REVISION DETAIL
https://phabricator.kde.org/D21543
To: tobiasdeiminger, aacid
Cc: aacid, okular-deve
bcooksley added a comment.
Thanks for the quick update. Unfortunately I don't have a way of easily
testing proposed patches, but in theory that should solve it yes.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21416
To: tobiasdeiminger, #okular, sander
Cc: bcooksl
sander added a comment.
Does https://phabricator.kde.org/D21543 help?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21416
To: tobiasdeiminger, #okular, sander
Cc: bcooksley, davidhurka, knambiar, ngraham, okular-devel, joaonetto, tfella,
darcyshen, aacid
bcooksley added a comment.
I'm afraid MSVC doesn't like this change - could someone please take a look?
https://build.kde.org/view/Failing/job/Applications/job/okular/job/kf5-qt5%20WindowsMSVCQt5.11/161/console
This is causing the Dependency Build for Extragear on Windows to fail, so a
https://bugs.kde.org/show_bug.cgi?id=406237
fabrice salvaire changed:
What|Removed |Added
CC||fabrice.salva...@orange.fr
--- Comment #11 f
https://bugs.kde.org/show_bug.cgi?id=408075
Nate Graham changed:
What|Removed |Added
CC||n...@kde.org
--
You are receiving this mail beca
davidhurka retitled this revision from "[RFC] Write a bit Documentation for
Part and PageView" to "[RFC] Write Documentation for Okular::Part".
davidhurka edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21281
To: davidhurka, #okular
C
https://bugs.kde.org/show_bug.cgi?id=408102
Nate Graham changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=408102
Tobias Deiminger changed:
What|Removed |Added
CC||haxti...@posteo.de
--- Comment #2 from Tobia
davidhurka added inline comments.
INLINE COMMENTS
> davidhurka wrote in guiutils.cpp:77
> If you use TextPage::textArea( textSelction ), you will get something like
> (using above source lines as example...):
>
> xtSelection(leftTop, rightDown);// TODO this does not seem
>
> if only seem was
simgunz updated this revision to Diff 59017.
simgunz added a comment.
Still very rough, but most of the tools and corresponding basic settings are
now there.
Remember to move/remove ~/.config/okularpartrc before testing this.
Changes highlights:
- Check if chosen color is valid
Am 02.06.2019 12:46 schrieb Albert Astals Cid:
Tobias this one is on you :)
Yep, of course :)
Good luck!
https://phabricator.kde.org/D21543 should do it, but I have no Windows
development environment to try. Can someone help with testing?
Harbormaster didn't catch the error, see
https://ph
tobiasdeiminger created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
tobiasdeiminger requested review of this revision.
REVISION SUMMARY
Windows MSVC Qt5.11 build fails:
conversion from 'initializer list' to 'QSizeF' requires a narrowing
convers
Tobias this one is on you :)
Good luck!
Cheers,
Albert
El dissabte, 1 de juny de 2019, a les 17:57:41 CEST, CI System va escriure:
>
> BUILD FAILURE
>
>
> Build URL
> https://build.kde.org/job/Applications/job/okular/job/kf5-qt5%20WindowsMSVCQt5.11/161/
>
>
> Project:
> kf5-qt
BUILD FAILURE
Build URL
https://build.kde.org/job/Applications/job/okular/job/kf5-qt5%20WindowsMSVCQt5.11/161/
Project:
kf5-qt5 WindowsMSVCQt5.11
Date of build:
Sat, 01 Jun 2019 15:54:35 +
Build duration:
3 min 5 sec and counting
CONSOLE OUTPUT
[
simgunz added a task: T11014: Dimension line annotation tool.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21490
To: tobiasdeiminger
Cc: ngraham, simgunz, okular-devel, joaonetto, tfella, darcyshen, aacid
simgunz added a task: T11014: Dimension line annotation tool.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D15580
To: simgunz, #okular
Cc: knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella,
darcyshen, aacid
simgunz updated this revision to Diff 59000.
simgunz added a comment.
- Change string that inform the user about how Identity info are used
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10859?vs=58965&id=59000
BRANCH
fix-annot-config-dialog
REVISION DET
52 matches
Mail list logo
