[okular] [Bug 408102] After every Plasma update the toolbar configuration is lost

2019-06-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408102 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #1 from Nate Graham ---

[okular] [Bug 408195] unrendered pdf regions with trim margins and facing pages on 4k screen

2019-06-01 Thread Kevin
https://bugs.kde.org/show_bug.cgi?id=408195 Kevin changed: What|Removed |Added CC||kjs...@gmail.com -- You are receiving this mail becaus

[okular] [Bug 408195] New: unrendered pdf regions with trim margins and facing pages on 4k screen

2019-06-01 Thread Kevin
https://bugs.kde.org/show_bug.cgi?id=408195 Bug ID: 408195 Summary: unrendered pdf regions with trim margins and facing pages on 4k screen Product: okular Version: 1.7.1 Platform: Other OS: Linux

D10859: Improve layout of annotation configuration dialogs

2019-06-01 Thread Nathaniel Graham
ngraham added a comment. > Replace “comments and reviews” by “annotations”. +1 REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: davidhurka, aacid, okular-devel, knambiar, ngraham, joao

[okular] [Bug 408190] New: Inactive window effects do not apply to side toolbar

2019-06-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408190 Bug ID: 408190 Summary: Inactive window effects do not apply to side toolbar Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Seve

D10859: Improve layout of annotation configuration dialogs

2019-06-01 Thread David Hurka
davidhurka added inline comments. INLINE COMMENTS > simgunz wrote in dlgannotationsbase.ui:71 > I have not understood the reason. This message is only displayed in the > configuration dialog. In any case we could change it for me. In D10859#472832 , @s

D10859: Improve layout of annotation configuration dialogs

2019-06-01 Thread Simone Gaiarin
simgunz added a comment. What should we do regarding the message at line 71 of conf/dlgannotationsbase.ui ? I think is the last thing to possibly change. After that I think this review is ready. Once I get the ok from @aacid I can land this. (The code for the stamp annotation is rea

[okular] [Bug 381629] add arrow's option to annotation tools

2019-06-01 Thread Tobias Deiminger
https://bugs.kde.org/show_bug.cgi?id=381629 Tobias Deiminger changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED

D21416: Add icons for line annotation arrow styles to combo box

2019-06-01 Thread Tobias Deiminger
This revision was automatically updated to reflect the committed changes. Closed by commit R223:1b89f220ef1b: Add icons for line annotation arrow styles to combo box (authored by tobiasdeiminger). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21416?vs=58980&id=58986#toc REPOSITORY R22

D21248: Add line annotation ending arrows for non PDF documents

2019-06-01 Thread Tobias Deiminger
This revision was automatically updated to reflect the committed changes. Closed by commit R223:d0e3a77de2c3: Add line annotation ending arrows for non PDF documents (authored by tobiasdeiminger). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21248?vs=58958&id

[okular] [Bug 381629] add arrow's option to annotation tools

2019-06-01 Thread Tobias Deiminger
https://bugs.kde.org/show_bug.cgi?id=381629 --- Comment #5 from Tobias Deiminger --- Git commit d0e3a77de2c3b219c94b37a0a07953635840cd7f by Tobias Deiminger. Committed on 01/06/2019 at 15:28. Pushed by tobiasdeiminger into branch 'master'. Add line annotation ending arrows for non PDF documents

D21202: [WIP] Support animated PDF

2019-06-01 Thread Joao Oliveira
joaonetto edited the summary of this revision. joaonetto edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21202 To: joaonetto, aacid, #okular Cc: pino, anthonyfieroni, sander, okular-devel, joaonetto, tfella, ngraham, darcyshen, aac

D21202: [WIP] Support animated PDF

2019-06-01 Thread Joao Oliveira
joaonetto updated this revision to Diff 58984. joaonetto added a comment. Updating revision to match the current branch REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21202?vs=58488&id=58984 BRANCH gsoc2019_animatedpdf REVISION DETAIL https://phabricat

D21248: Add line annotation ending arrows for non PDF documents

2019-06-01 Thread Oliver Sander
sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH feature/drawlineendings REVISION DETAIL https://phabricator.kde.org/D21248 To: tobiasdeiminger, #okular, aacid, sander Cc: ngraham, sander, knambiar, okular-devel, joaonetto, tfel

D21416: Add icons for line annotation arrow styles to combo box

2019-06-01 Thread Oliver Sander
sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21416 To: tobiasdeiminger, #okular, sander Cc: davidhurka, knambiar, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21416: Add icons for line annotation arrow styles to combo box

2019-06-01 Thread Tobias Deiminger
tobiasdeiminger added a comment. In D21416#472774 , @davidhurka wrote: > Not wrong but not important. How often does one change the color theme while chosing a line ending? I could only imagine that the color theme changes automatically based o

D21416: Add icons for line annotation arrow styles to combo box

2019-06-01 Thread David Hurka
davidhurka added a comment. In D21416#472772 , @tobiasdeiminger wrote: > In D21416#471897 , @tobiasdeiminger wrote: > > > In D21416#471795 , @davidhurka w

D21416: Add icons for line annotation arrow styles to combo box

2019-06-01 Thread Tobias Deiminger
tobiasdeiminger added a comment. In D21416#471897 , @tobiasdeiminger wrote: > In D21416#471795 , @davidhurka wrote: > > > For dark color themes: maybe the color of the adjacent text would be good a

D21416: Add icons for line annotation arrow styles to combo box

2019-06-01 Thread Tobias Deiminger
tobiasdeiminger updated this revision to Diff 58980. tobiasdeiminger added a comment. Consider QGuiApplication::palette, to improve icon visibility in dark themes. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21416?vs=58872&id=58980 REVISION DETAIL http

[okular] [Bug 355467] Find from current page does not work for successive finds.

2019-06-01 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=355467 Albert Astals Cid changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---