D21332: Okular Annotation: add line start/end style config only for Straight Line tool

tobiasdeiminger added a comment. `arc patch` fails, could you please rebase on current master? You may also want to add CCBUG : 381629 to the description. Besides that your changes look reason

D21320: Fix build with poppler < 0.51

sander added a comment. My error. Apologies! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: aacid, joaonetto, okular-devel, tfella, ngraham, darcyshen

D20948: [EPubGenerator] Avoid pointless scans of the whole document

This revision was automatically updated to reflect the committed changes. Closed by commit R223:eb41001e0e28: [EPubGenerator] Avoid pointless scans of the whole document (authored by bruns, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D209

D20948: [EPubGenerator] Avoid pointless scans of the whole document

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. makes sense REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20948 To: bruns, #okular, aacid Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen

D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table

This revision was automatically updated to reflect the committed changes. Closed by commit R223:9f98c010691e: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table (authored by bruns, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.

[okular] [Bug 406738] Okular crashes when I try to open a specific epub file

https://bugs.kde.org/show_bug.cgi?id=406738 Albert Astals Cid changed: What|Removed |Added Latest Commit||https://commits.kde.org/oku

[okular] [Bug 407140] Crash, QTextDocument chokes on input and ends up with negative pagecounts

https://bugs.kde.org/show_bug.cgi?id=407140 Albert Astals Cid changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|---

[okular] [Bug 406738] Okular crashes when I try to open a specific epub file

https://bugs.kde.org/show_bug.cgi?id=406738 Albert Astals Cid changed: What|Removed |Added CC||kdeb...@fratti.ch --- Comment #6 from Alber

D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. ok, i guess, the padding was a bit arbitrary and to first page only anyway ^_^ REPOSITORY R223 Okular BRANCH fix_epub REVISION DETAIL https://phabricator.kde.org/D20949 To: bruns, #ok

[okular] [Bug 407836] Okular crashes with a segfault when opening epub file

https://bugs.kde.org/show_bug.cgi?id=407836 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Status|REPORTED

D21248: Add line annotation ending arrows for non PDF documents

tobiasdeiminger edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21248 To: tobiasdeiminger, #okular, aacid Cc: ngraham, sander, knambiar, okular-devel, joaonetto, tfella, darcyshen, aacid

D20950: [EPubGenerator] Use proper UserResource enum value for custom resource

This revision was automatically updated to reflect the committed changes. Closed by commit R223:eb1e79644905: [EPubGenerator] Use proper UserResource enum value for custom resource (authored by bruns, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.k

D20950: [EPubGenerator] Use proper UserResource enum value for custom resource

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20950 To: bruns, #okular, aacid Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen

D21320: Fix build with poppler < 0.51

aacid added a comment. I've reverted the changeset since it was breaking the build REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: aacid, joaonetto, okular-devel, tfella, ngraham, darcyshen

[okular] [Bug 407731] can't open amazon invoices

https://bugs.kde.org/show_bug.cgi?id=407731 Albert Astals Cid changed: What|Removed |Added Resolution|WAITINGFORINFO |NOT A BUG Status|NEEDSINFO

D21320: Fix build with poppler < 0.51

joaonetto added a comment. This broke the compilation process on my machine. I just tested with a clean version of KDE Neon, Poppler 0.62, and it doesn't compile, something about FormFieldsSignatures. Is this only happening to me? REPOSITORY R223 Okular REVISION DETAIL https://phab

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka marked 2 inline comments as done. davidhurka added a comment. Probably it should be described how dropped URLs are handled in general? Sometimes the Part uses them and wildly opens files, sometimes not. INLINE COMMENTS > part.h:154 > + */ > void showSourceLocation

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka updated this revision to Diff 58507. davidhurka added a comment. - Part::Part() 'QObject is a widget' -> 'QObject is an object' - Document some D-Bus methods and Part signals, minor improvements in Document REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.

[okular] [Bug 407731] can't open amazon invoices

https://bugs.kde.org/show_bug.cgi?id=407731 --- Comment #6 from David Hurka --- Thats interesting: Create some files somewhere in the most abandoned ~/.mozilla/ directories, and poppler opens the PDF. Yes, this workarround works for me. > I guess you're not a firefox user or you don't have a >

[okular] [Bug 407836] New: Okular crashes with a segfault when opening epub file

https://bugs.kde.org/show_bug.cgi?id=407836 Bug ID: 407836 Summary: Okular crashes with a segfault when opening epub file Product: okular Version: 1.7.1 Platform: Archlinux Packages OS: Linux Status: REPORTED

D21202: [WIP] Support animated PDF

joaonetto updated this revision to Diff 58488. joaonetto added a comment. Documentation and fixing spaces REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21202?vs=58487&id=58488 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21202 AFFECTED

D21202: [WIP] Support animated PDF

joaonetto retitled this revision from "Added basic JavaScript functions to support animated PDF" to "[WIP] Support animated PDF". joaonetto edited the summary of this revision. joaonetto edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.or

D21202: Added basic JavaScript functions to support animated PDF

joaonetto updated this revision to Diff 58487. joaonetto added a comment. Implemented setInterval/clearInterval. WidgetScripts are now supported on pageOpening/Closing. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21202?vs=58165&id=58487 BRANCH master

[okular] [Bug 407731] can't open amazon invoices

https://bugs.kde.org/show_bug.cgi?id=407731 --- Comment #5 from Albert Astals Cid --- a very basic and lame workaround while you get your distribution to give you a newer poppler would be so this file doesn't crash would be mkdir -p ~/.mozilla/firefox/default certutil -N -d ~/.mozilla/firefox/d

D21320: Fix build with poppler < 0.51

volkov closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20437: Make selection scrolling go at 60 fps

kezik added a comment. Thanks everybody REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20437 To: kezik, #okular, aacid, sander, ngraham Cc: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik, joaonetto, tfella, darcyshen

[okular] [Bug 407828] New: [Feature Request]: Adjust print area to whole page

https://bugs.kde.org/show_bug.cgi?id=407828 Bug ID: 407828 Summary: [Feature Request]: Adjust print area to whole page Product: okular Version: 1.3.3 Platform: Other OS: Linux Status: REPORTED Severity: no

D21332: Okular Annotation: add line start/end style config only for Straight Line tool

knambiar created this revision. knambiar added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. knambiar requested review of this revision. REVISION SUMMARY “Inner Color” configuration of Polygon tool was overlapping with the line start/end styles int

D21238: Okular Annotation: add support for line start style for Straight Line tool

knambiar added a comment. In D21238#468127 , @tobiasdeiminger wrote: > @knambiar The config dialog for polygon annotations has seemingly regressed with recent changes: Ouch. Going to fix it in a new review. REPOSITORY R223 Okular REV

D21320: Fix build with poppler < 0.51

sander accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH Applications/19.04 REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular, sander Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

[okular] [Bug 343834] Okular doesn't print some form fields

https://bugs.kde.org/show_bug.cgi?id=343834 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #4 from