D20760: Okular Annotation: add support for line ending style for Straight Line tool

pino added inline comments. INLINE COMMENTS > annotationwidgets.cpp:549-558 > +m_termStyleCombo->addItem( QStringLiteral(u"\u25A1") + i18n( " Square" ) > ); > +m_termStyleCombo->addItem( QStringLiteral(u"\u25CB") + i18n( " Circle" ) > ); > +m_termStyleCombo->addItem( QStringLiteral(

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. I think it should. But not in this patch. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular, #vdg, sander, ngraham Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

[okular] [Bug 407256] New: Please change search result display color

https://bugs.kde.org/show_bug.cgi?id=407256 Bug ID: 407256 Summary: Please change search result display color Product: okular Version: 1.6.2 Platform: Fedora RPMs OS: Linux Status: REPORTED Severity: norma

D20760: Okular Annotation: add support for line ending style for Straight Line tool

tobiasdeiminger added a comment. In D20760#461314 , @sander wrote: > At least squares and diamonds are incorrect, too. Ok, so at least we're consistent in doing wrong :) I'll fix it. Btw., this raises the question if setting / changin

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. At least squares and diamonds are incorrect, too. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular, #vdg, sander, ngraham Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen,

D20760: Okular Annotation: add support for line ending style for Straight Line tool

tobiasdeiminger added a comment. In D20760#461261 , @sander wrote: > Is this really how they are supposed to look? If not, is this a poppler bug, or is Okular missing some further line ending setup code? Needs to be fixed in poppler, I'll

D20760: Okular Annotation: add support for line ending style for Straight Line tool

sander added a comment. I tried the circle line endings and they look a bit strange to me: F6810572: okular-strange-circle-line-ending.png Is this really how they are supposed to look? If not, is this a poppler bug, or is Okular missing some furth

D20760: Okular Annotation: add support for line ending style for Straight Line tool

ngraham accepted this revision. ngraham added a comment. Looks great to me now! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular, #vdg, sander, ngraham Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcy

[okular] [Bug 407217] Toggle Change Colors button does not toggle

https://bugs.kde.org/show_bug.cgi?id=407217 David Hurka changed: What|Removed |Added See Also||https://bugs.kde.org/show_b |

[okular] [Bug 173264] Add hotkey for "Change colors"

https://bugs.kde.org/show_bug.cgi?id=173264 David Hurka changed: What|Removed |Added See Also||https://bugs.kde.org/show_b |