D18744: Add action in Edit menu to select the current page

loh.tar added inline comments. INLINE COMMENTS > shubham wrote in pageview.cpp:743 > So better I will remove that. Here is e.g. Alt-P, and a couple of F-Keys not used. But perhaps exist in other software some similar function with a usual key sequence that can be adopt REPOSITORY R223 Okula

D18358: [WIP] Add buttons to collapse and expand all elements

ngraham added a reviewer: Okular. ngraham added a comment. If you need icons, please file a bug in the `Breeze | Icons` product and add #VDG as a subscriber to the patch. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To:

D18744: Add action in Edit menu to select the current page

shubham added inline comments. INLINE COMMENTS > ngraham wrote in pageview.cpp:743 > It doesn't have a shortcut at all. If you can't think of anything that > doesn't conflict, then just don't give it one. So better I will remove that. REPOSITORY R223 Okular REVISION DETAIL https://phabric

D18744: Add action in Edit menu to select the current page

ngraham added inline comments. INLINE COMMENTS > shubham wrote in pageview.cpp:743 > What sequence should I use? It doesn't have a shortcut at all. If you can't think of anything that doesn't conflict, then just don't give it one. REPOSITORY R223 Okular REVISION DETAIL https://phabricator

D18744: Add action in Edit menu to select the current page

shubham added inline comments. INLINE COMMENTS > ngraham wrote in pageview.cpp:743 > Erm, that's the shortcut used for printing. Did you test this? What sequence should I use? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: k

D18358: [WIP] Add buttons to collapse and expand all elements

joaonetto retitled this revision from "Add buttons to collapse and expand all elements" to "[WIP] Add buttons to collapse and expand all elements". joaonetto edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18358 To: joaonetto Cc: okul

[okular] [Bug 393478] crash when I exit presentation mode and enter again

https://bugs.kde.org/show_bug.cgi?id=393478 Albert Astals Cid changed: What|Removed |Added CC||xionbox33...@gmail.com --- Comment #18 from

[okular] [Bug 404078] Full screen to normal back to full screen causes systematic crash

https://bugs.kde.org/show_bug.cgi?id=404078 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Status|NEEDSINFO

D18144: Implemented find function from console

aacid closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18144 To: joaonetto, #okular, aacid Cc: ngraham, aacid, yurchor, okular-devel, tfella, darcyshen

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

https://bugs.kde.org/show_bug.cgi?id=362038 Albert Astals Cid changed: What|Removed |Added Latest Commit||https://commits.kde.org/oku

D18144: Implemented find function from console

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Ah, you got bitten by findbar not being visible to the test. I'll fix the test in a commit just after landing this, have a look in you're interested in the creative solution. REPOSITORY

D18744: Add action in Edit menu to select the current page

ngraham added a comment. In D18744#411621 , @shubham wrote: > I knew ctrl p is for print, so for time being I kept it so I can get suggestion for other shortcut sequence. It's not acceptable to deliberately publish a diff that does the wr

D18744: Add action in Edit menu to select the current page

shubham added a comment. In D18744#411599 , @ngraham wrote: > Please test your changes. The new menu is not actually added to the Edit menu and the shortcut you chose conflicts with the print shortcut. I knew ctrl p is for print, so for t

D18744: Add action in Edit menu to select the current page

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Please test your changes. The new menu is not actually added to the Edit menu and the shortcut you chose conflicts with the print shortcut. INLINE COMMENTS > pageview.cpp:740 >

D18744: Add action in Edit menu to select the current page

shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid

D18744: Add action in Edit menu to select the current page

shubham retitled this revision from "Add action in Edit menu to select the entire page " to "Add action in Edit menu to select the current page ". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.

D18744: Add action in Edit menu to select the entire page

shubham retitled this revision from "Select entire page on mouse double click event" to "Add action in Edit menu to select the entire page ". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar,

D18744: Select entire page on mouse double click event

shubham updated this revision to Diff 51610. shubham added a comment. Remove unneeded comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=51609&id=51610 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FIL

D18744: Select entire page on mouse double click event

shubham updated this revision to Diff 51609. shubham edited the summary of this revision. shubham added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Add action and shortcut to select the current page Remove triggering on mouseDoubleClick event