[okular] [Bug 403178] Buggy Zoom Out

2019-01-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=403178 --- Comment #2 from alt.su-7oon2...@yopmail.com --- If you mean View > Trim View > Trim Margins, then yes, it was enabled. I am unsure if that was enabled by me or if it defaults to enabled. Anyway, disabling Trim Margins seems to fix the issue, so I gu

D18144: Implemented find function from console

2019-01-14 Thread Joao Oliveira
joaonetto updated this revision to Diff 49497. joaonetto added a comment. Code cleanup, only important parts should be changed REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18144?vs=49496&id=49497 BRANCH arcpatch-D18144 REVISION DETAIL https://phabric

D18144: Implemented find function from console

2019-01-14 Thread Joao Oliveira
joaonetto updated this revision to Diff 49496. joaonetto added a comment. Deleted signal, now I call the function after the file has been open REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18144?vs=49420&id=49496 BRANCH arcpatch-D18144 REVISION DETAIL

D18144: Implemented find function from console

2019-01-14 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > joaonetto wrote in part.cpp:1716 > Tried this, didn't work for network files Right, you actually want it in openFile() not in openUrl, sorry :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18144 To: joaonetto, #okular C

[okular] [Bug 403178] Buggy Zoom Out

2019-01-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=403178 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Status|REPORTED

D18238: Implements a new button on findbar that allows users to choose the color that highlights the text

2019-01-14 Thread Joao Oliveira
joaonetto added a comment. I'm okay in discarding it. But shouldn't we just give them the option? I can put the settings in the preferences toolbar or something. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18238 To: joaonetto, #okular Cc: aacid, okular-devel

D18238: Implements a new button on findbar that allows users to choose the color that highlights the text

2019-01-14 Thread Albert Astals Cid
aacid added a comment. I don't think it's a good idea, we now have the border around search results so they are more distinguishable from higlights. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18238 To: joaonetto, #okular Cc: aacid, okular-devel, tfella, ngraham,

D18238: Implements a new button on findbar that allows users to choose the color that highlights the text

2019-01-14 Thread Joao Oliveira
joaonetto added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18238 To: joaonetto, #okular Cc: okular-devel, ngraham, darcyshen, aacid

[okular] [Bug 188239] [JJ] Okular doesn't follow PageLayout TwoColumnLeft and TwoColumnRight

2019-01-14 Thread Denis Bitouzé
https://bugs.kde.org/show_bug.cgi?id=188239 Denis Bitouzé changed: What|Removed |Added CC||dbito...@wanadoo.fr --- Comment #12 from Denis