D18118: Presentation mode: go to previous page when left-clicking on left half of the page

michaelweghorn added a comment. I'd also prefer to leave the current behaviour of a left-click as it is, regardless of the exact position. That is also in line with what e.g. LibreOffice Impress does. Allowing to go back by doing a single-finger swipe sounds great. REPOSITORY R223 Okular

D18144: Implemented find function from console

joaonetto updated this revision to Diff 49206. joaonetto added a comment. Changed the code so I no longer use query. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18144?vs=49193&id=49206 BRANCH arcpatch-D18144 REVISION DETAIL https://phabricator.kde.o

D12901: Add unit test for SignatureFormField

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D13484: Show signature validation summary as popup

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13484 To: aacid, chinmoyr Cc: ngraham, okular-devel, darcyshen, aacid

D12901: Add unit test for SignatureFormField

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12901 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D13484: Show signature validation summary as popup

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D14656: Add utitlity functions for use in digital signature verification

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D14655: Reimplement signature form field and related utility classes in poppler generator

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D14696: Add certificate viewer

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14696 To: aacid, ngraham, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D14696: Add certificate viewer

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D14656: Add utitlity functions for use in digital signature verification

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14656 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14655 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D14654: Add API for signature form field, and other helper classes

aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde

D14654: Add API for signature form field, and other helper classes

aacid abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14654 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D14654: Add API for signature form field, and other helper classes

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14654 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D14734: Add revision viewer

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D14734: Add revision viewer

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14734 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D14748: Add signature properties dialog

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D14748: Add signature properties dialog

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14748 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D14816: Add signature panel

aacid abandoned this revision. aacid added a comment. This has been merged as part of https://commits.kde.org/okular/a234a902dcfff249d8f1d41dfbc257496c81d84e Abandoning because phabricator doesn't have a "merged as part of a different commit" option. REPOSITORY R223 Okular REVISION D

D14816: Add signature panel

aacid commandeered this revision. aacid edited reviewers, added: chinmoyr; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14816 To: aacid, chinmoyr Cc: okular-devel, ngraham, darcyshen, aacid

D18144: Implemented find function from console

aacid added a comment. Using query is a bad idea, now if i actually open a file that has a query in it, it opens the find bar for no reason okular https://bugs.freedesktop.org/attachment.cgi?id=140739 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18144 To: joa

D18144: Implemented find function from console

joaonetto updated this revision to Diff 49193. joaonetto added a comment. one last change to avoid repeating code. I guess it's ready to land, just need a reviewer. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18144?vs=49190&id=49193 BRANCH arcpatch-D1

D18144: Implemented find function from console

joaonetto updated this revision to Diff 49190. joaonetto added a comment. Using command find from terminal now opens FindBar REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18144?vs=49125&id=49190 BRANCH arcpatch-D18144 REVISION DETAIL https://phabricat

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

https://bugs.kde.org/show_bug.cgi?id=362038 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|REPORTED

D18144: Implemented find function from console

yurchor added a comment. In D18144#390624 , @joaonetto wrote: > Tried that, not possible, it gets me compilation error. Ooops... Sorry. Otherwise, I can confirm that the patch works as expected. INLINE COMMENTS > part.cpp:1730 > +

D18144: Implemented find function from console

joaonetto added a comment. Tried that, not possible, it gets me compilation error. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18144 To: joaonetto, #okular Cc: yurchor, okular-devel, ngraham, darcyshen, aacid

D18144: Implemented find function from console

joaonetto added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18144 To: joaonetto, #okular Cc: yurchor, okular-devel, ngraham, darcyshen, aacid