Re: Google Summer of Code Ideas

2019-01-03 Thread Albert Astals Cid
El dimarts, 1 de gener de 2019, a les 22:21:41 CET, Oliver Sander va escriure: > Done. > > BTW: What is the status on the code from last years 'verify signatures' > project? > Can I help you with that in any way? Not really. Cheers, Albert > > Best, > Oliver > > On 22.12.18 11:56, Albert A

T10243: Some KDE applications could use better icons

2019-01-03 Thread Nathaniel Graham
ngraham created this task. ngraham triaged this task as "Wishlist" priority. ngraham added projects: VDG, KDE Applications. TASK DESCRIPTION Many of the Breeze app icons are great, but there are a few KDE applications whose own Breeze icons are rather uninspired, especially compared to their O

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-01-03 Thread Albert Astals Cid
aacid added a comment. > There is one drawback to this patch. With the cursor mode HiddenDelay, the cursor disappears after a short time, and should reappear at the next mouse move. This does not work if the cursor has been hidden by TabletLeaveProximity, and I don't understand why. Did

T10243: Some KDE applications could use better icons

2019-01-03 Thread Nathaniel Graham
ngraham added a comment. I have no idea where it's used, sorry. I just saw that the Breeze version of it looked somewhat underwhelming compared to its Oxygen version. TASK DETAIL https://phabricator.kde.org/T10243 To: ngraham Cc: knauss, mglb, filipf, mludwig, aacid, lesliezhai, elvisangel

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-01-03 Thread Oliver Sander
sander marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D17929 To: sander, #okular Cc: shubham, aacid, ngraham, okular-devel, darcyshen

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-01-03 Thread Oliver Sander
sander updated this revision to Diff 48589. sander added a comment. Whitespace fixes REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17929?vs=48568&id=48589 REVISION DETAIL https://phabricator.kde.org/D17929 AFFECTED FILES ui/presentationwidget.cpp ui

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-01-03 Thread Oliver Sander
sander added inline comments. INLINE COMMENTS > aacid wrote in presentationwidget.cpp:1373 > Is this changeset related? It is. The code I added is exactly what the two calls to `slotChangeDrawingToolEngine` do, except that the first one additionally set the cursor to 'Arrow' (without good reas

T10243: Some KDE applications could use better icons

2019-01-03 Thread Sandro Knauß
knauss added a comment. About mentioned pim icon (Kontact, KOrganizer Calendar): - The oxygen icon for Kontact looks like what I have in mind of kontact. It gives me a bundle of pim applications. The breeze one it overlaying each other, so you can only see the email one. that is not clea

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-01-03 Thread Shubham
shubham added inline comments. INLINE COMMENTS > presentationwidget.cpp:540 > > +bool PresentationWidget::eventFilter (QObject * o, QEvent *e ) > +{ Remove space before o REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D17929 To: sander, #okular Cc: shubham, aacid, ng

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-01-03 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > presentationwidget.cpp:1373 > // that - that gives continuous drawing > -slotChangeDrawingToolEngine( QDomElement() ); > -slotChangeDrawingToolEngine( m_currentDrawingToolElement ); > +delete m_drawingEngine; > +

D17929: Hide cursor when tablet stylus leaves proximity of the screen

2019-01-03 Thread Albert Astals Cid
aacid added a comment. In D17929#385468 , @sander wrote: > > Coding style: Opening curly braces go on the same line of the if statement. > > Not in that file, apparently. Not in all of okular [exceptions probably exist] REPOSITORY