D16364: Resolve symlinks before saving so we don't "break" them

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks. Works now and fixes the bug. Let's get this into 18.12.3! REPOSITORY R223 Okular BRANCH arcpatch-D16364 REVISION DETAIL https://phabricator.kde.org/D16364

D16364: Resolve symlinks before saving so we don't "break" them

aacid updated this revision to Diff 44050. aacid added a comment. fix code REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16364?vs=44048&id=44050 BRANCH arcpatch-D16364 REVISION DETAIL https://phabricator.kde.org/D16364 AFFECTED FILES part.cpp To:

D16364: Resolve symlinks before saving so we don't "break" them

aacid added inline comments. INLINE COMMENTS > ngraham wrote in part.cpp:2540 > Shouldn't `realSaveUrl.toLocalFile()` be `saveUrl.toLocalFile()`? Yeah, that's what you get when you rewrite the match at last minute and don't test it again. REPOSITORY R223 Okular REVISION DETAIL https://pha

D16364: Resolve symlinks before saving so we don't "break" them

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks for the patch! However this does not actually work for me. See the following video (taken with the patch applied): F6342100: doesn't work.webm

[okular] [Bug 399870] save (of annotations) overwrites symlinked PDF with copy

https://bugs.kde.org/show_bug.cgi?id=399870 Albert Astals Cid changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

D16364: Resolve symlinks before saving so we don't "break" them

aacid created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. aacid requested review of this revision. REVISION SUMMARY BUGS: 399870 REPOSITORY R223 Okular BRANCH Applications/18.08 REVISION DETAIL https://phabricator.kde.org/D16364 AFFECTED FILE

[okular] [Bug 400103] Feature Request remember last used directory in places (Save as dialog)

https://bugs.kde.org/show_bug.cgi?id=400103 --- Comment #4 from Albert Astals Cid --- (In reply to Nate Graham from comment #3) > Open a new file (or create a new one, whatever) No, that is a big difference, because if you create a new one, Save as doesn't have a place to suggest where to save,

D16345: Create new "Zoom to 100%" action

abetts added a comment. +1 I think there "could' be variations of this like Show original size Maybe? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16345 To: ngraham, #okular, #vdg Cc: abetts, aacid, okular-devel, ngraham

[okular] [Bug 400104] Crash when opening a link to a local pdf

https://bugs.kde.org/show_bug.cgi?id=400104 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit|

D16285: Remember printing option and print range in the print dialog

ahmadosama added a comment. In D16285#346944 , @aacid wrote: > In D16285#346879 , @ahmadosama wrote: > > > In D16285#346864 , @aacid wrote: > > > > > I

[okular] [Bug 400103] Feature Request remember last used directory in places (Save as dialog)

https://bugs.kde.org/show_bug.cgi?id=400103 --- Comment #3 from Nate Graham --- Spectacle is one such example.(In reply to Albert Astals Cid from comment #2) > (In reply to Nate Graham from comment #1) > > Yeah, most other KDE apps' save dialogs remember the last saved location, so > > Okular's p

[okular] [Bug 400104] Crash when opening a link to a local pdf

https://bugs.kde.org/show_bug.cgi?id=400104 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Status|REPORTED

[okular] [Bug 400103] Feature Request remember last used directory in places (Save as dialog)

https://bugs.kde.org/show_bug.cgi?id=400103 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #2 from Albert As

[okular] [Bug 400103] Feature Request remember last used directory in places (Save as dialog)

https://bugs.kde.org/show_bug.cgi?id=400103 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #1 from Nate Graham ---

D16285: Remember printing option and print range in the print dialog

aacid added a comment. In D16285#346879 , @ahmadosama wrote: > In D16285#346864 , @aacid wrote: > > > If you're not going to save the data, why are you adding it to the docinfo xml? > > > > If

D16285: Remember printing option and print range in the print dialog

ahmadosama added a comment. @yurchor I have reformatted the code to be consistent, sorry for this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16285 To: ahmadosama, #okular Cc: aacid, yurchor, broulik, ngraham, okular-devel

[okular] [Bug 398116] When opening PDF file Okular opens in full screen mode & difficult to return to normal mode

https://bugs.kde.org/show_bug.cgi?id=398116 Thomas Bingel changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 398113] Go to page links work erratically

https://bugs.kde.org/show_bug.cgi?id=398113 Thomas Bingel changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Ever confirmed|0

[okular] [Bug 398113] Go to page links work erratically

https://bugs.kde.org/show_bug.cgi?id=398113 --- Comment #4 from Thomas Bingel --- So by definition is wrong! For anyone, who does serious work with a PDF needs to be able to follow bibliographical references at any time whether in highlighter mode or not. What I do at the moment is I open same

D16285: Remember printing option and print range in the print dialog

ahmadosama updated this revision to Diff 44043. ahmadosama added a comment. - Reformat other parts of the code REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16285?vs=44041&id=44043 BRANCH remember_print_range REVISION DETAIL https://phabricator.kde.or

D16285: Remember printing option and print range in the print dialog

ahmadosama updated this revision to Diff 44041. ahmadosama added a comment. - Reformatting the code to be consistent with other parts REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16285?vs=44036&id=44041 BRANCH remember_print_range REVISION DETAIL htt

D16285: Remember printing option and print range in the print dialog

ahmadosama added a comment. In D16285#346864 , @aacid wrote: > If you're not going to save the data, why are you adding it to the docinfo xml? > > If this is only for remembering the options while okular is open i don't even think it makes

D16285: Remember printing option and print range in the print dialog

aacid added a comment. If you're not going to save the data, why are you adding it to the docinfo xml? If this is only for remembering the options while okular is open i don't even think it makes sense storing it into document at all and should just be stored in Part as something like

D16285: Remember printing option and print range in the print dialog

yurchor added inline comments. INLINE COMMENTS > document.cpp:652 > +} > +else if( printElement.tagName() == > QLatin1String("printRange") ) > +{ Is it possible to keep the consistent formatting with other if's? It seems t

D16285: Remember printing option and print range in the print dialog

ngraham added a comment. Great, that sounds like exactly what would be expected. +1. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16285 To: ahmadosama, #okular Cc: broulik, ngraham, okular-devel, aacid

D16345: Create new "Zoom to 100%" action

ngraham added a reviewer: VDG. ngraham added a comment. One of the purposes of a menu bar is to teach users keyboard shortcuts. That's the reason why menu items have shortcuts listed next to them, and why tools with shortcuts have menu items. This isn't a philosophical position, it's a state

[okular] [Bug 400089] Previously closed PDF's open at startup, accompanied by an error message

https://bugs.kde.org/show_bug.cgi?id=400089 --- Comment #2 from dustin.fens...@gmail.com --- (In reply to Tobias Deiminger from comment #1) > Could it be you have "Restore manually saved session" checked in KDE System > Settings > Startup and Shutdown > Desktop Session? What you describe sounds >

D16285: Remember printing option and print range in the print dialog

ahmadosama added a comment. In D16285#344990 , @ngraham wrote: > This new information is saved/remembered per-document and not globally, right? The new information was saved for all documents if Okular was not closed, closing the documen

D16285: Remember printing option and print range in the print dialog

ahmadosama updated this revision to Diff 44036. ahmadosama added a comment. - Resetting the printing option to the default options when closing document REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16285?vs=43825&id=44036 BRANCH remember_print_range RE

D16345: Create new "Zoom to 100%" action

aacid added a comment. In D16345#346829 , @ngraham wrote: > In D16345#346828 , @aacid wrote: > > > In D16345#346803 , @ngraham wrote: > > > > > I would

D16345: Create new "Zoom to 100%" action

ngraham added a comment. In D16345#346828 , @aacid wrote: > In D16345#346803 , @ngraham wrote: > > > I would prefer to leave it in the main menu. The whole purpose of an app's main menu is to expose

D16345: Create new "Zoom to 100%" action

aacid added a comment. In D16345#346803 , @ngraham wrote: > I would prefer to leave it in the main menu. The whole purpose of an app's main menu is to expose all functionality in a visible manner--especially if that functionality has a keyboard

D16345: Create new "Zoom to 100%" action

ngraham added a comment. I would prefer to leave it in the main menu. The whole purpose of an app's main menu is to expose all functionality in a visible manner--especially if that functionality has a keyboard shortcut, since the menu becomes the only way for the user to see and learn the sh

D16345: Create new "Zoom to 100%" action

ngraham updated this revision to Diff 44028. ngraham marked an inline comment as done. ngraham added a comment. Use new slot syntax REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16345?vs=44003&id=44028 BRANCH zoom-to-100 (branched from master) REVISION

[okular] [Bug 400089] Previously closed PDF's open at startup, accompanied by an error message

https://bugs.kde.org/show_bug.cgi?id=400089 Tobias Deiminger changed: What|Removed |Added Status|REPORTED|NEEDSINFO CC|

[okular] [Bug 400104] New: Crash when opening a link to a local pdf

https://bugs.kde.org/show_bug.cgi?id=400104 Bug ID: 400104 Summary: Crash when opening a link to a local pdf Product: okular Version: 1.5.2 Platform: Archlinux Packages OS: Linux Status: REPORTED Severity:

[okular] [Bug 400103] New: Feature Request remember last used directory in places (Save as dialog)

https://bugs.kde.org/show_bug.cgi?id=400103 Bug ID: 400103 Summary: Feature Request remember last used directory in places (Save as dialog) Product: okular Version: unspecified Platform: openSUSE RPMs OS: Li

D16345: Create new "Zoom to 100%" action

aacid added a comment. I would argue we should leave this out of the menus, if people want to use the mouse to activate this they probably will just use the zoom combo in the toolbar. INLINE COMMENTS > pageview.cpp:488 > + > +d->aZoomActual = KStandardAction::actualSize( this, > SLOT(s