D13203: Add Typewriter annotation tool in Okular

2018-08-23 Thread Tobias Deiminger
tobiasdeiminger added a comment. I'd like to split this into two new Diffs 1. Add typewriter (everything until ID 36397 ) 2. Add fontcolor support (the reminder, depends on "Add typwriter") It's easier to review and test. And, the first

D15027: Show tooltips for links only if "Show hints..." is enabled in the preferences

2018-08-23 Thread Oliver Sander
sander added a comment. Wow, I have never noticed that tiny 'welcome' window until now... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15027 To: sander, #okular Cc: aacid, okular-devel, ngraham

D15027: Show tooltips for links only if "Show hints..." is enabled in the preferences

2018-08-23 Thread Oliver Sander
sander added a comment. I see. So there is simply no option to disable the tooltips? And what does OSD mean anyway? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15027 To: sander, #okular Cc: aacid, okular-devel, ngraham

[okular] [Bug 397786] Secondary comments do not show in pdf files under Okular.

2018-08-23 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=397786 Christoph Feck changed: What|Removed |Added Resolution|FIXED |WAITINGFORINFO -- You are receiving this mail

[okular] [Bug 397786] Secondary comments do not show in pdf files under Okular.

2018-08-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397786 Nate Graham changed: What|Removed |Added Resolution|WAITINGFORINFO |FIXED CC|

[okular] [Bug 393811] Inconsistent behaviour in saving comments

2018-08-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=393811 --- Comment #7 from david08...@gmail.com --- Yes, "Do you really want to Cancel" would be nice. After I edited a note, I want to save the changes and close the window, I press Esc, as that key does just that - saving and closing. (With the exception of

Re: Strange behavior of PDF form texts in Okular that I built

2018-08-23 Thread Albert Astals Cid
El dilluns, 20 d’agost de 2018, a les 12:23:45 CEST, Anıl Özbek va escriure: > I have one sample PDF file [1]. I don't know what all the features of > the file are, but I think it dynamically takes the date (or just date > format) from the system. > > When I edit this PDF file (fill form) with Oku

[okular] [Bug 397097] .okular archive should store the original file

2018-08-23 Thread ederag
https://bugs.kde.org/show_bug.cgi?id=397097 --- Comment #4 from ederag --- Done, here is the downgraded package, for openSUSE Leap15.0: https://build.opensuse.org/package/show/home:ederag/okular-1.2 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 396326] Crash on right-click over a specific section of the TOC of a specific document

2018-08-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=396326 Albert Astals Cid changed: What|Removed |Added CC||m...@hubbinash.org --- Comment #2 from Albe

[okular] [Bug 397800] Okular crashed when selecting a bookmark link

2018-08-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=397800 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Status|UNCONFIRME

[okular] [Bug 393811] Inconsistent behaviour in saving comments

2018-08-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=393811 --- Comment #6 from Albert Astals Cid --- (In reply to david08741 from comment #5) > Sorry, I wanted to change it back from information required, and the last > state was confirmed (I think) - I had no intention in saying you are wrong. > I thought conf

[okular] [Bug 397786] Secondary comments do not show in pdf files under Okular.

2018-08-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=397786 Albert Astals Cid changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRM

[okular] [Bug 393811] Inconsistent behaviour in saving comments

2018-08-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=393811 --- Comment #5 from david08...@gmail.com --- Sorry, I wanted to change it back from information required, and the last state was confirmed (I think) - I had no intention in saying you are wrong. I thought confirmed meant that the behaviour has been confi

[okular] [Bug 393811] Inconsistent behaviour in saving comments

2018-08-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=393811 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |UNCONFIRMED Ever confirmed|1

[okular] [Bug 393811] Inconsistent behaviour in saving comments

2018-08-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=393811 david08...@gmail.com changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO

D15027: Show tooltips for links only if "Show hints..." is enabled in the preferences

2018-08-23 Thread Albert Astals Cid
aacid added a comment. because that's not what the osd is, the osd is the thing on the top that says like "Welcome" and "File loaded", it is not about the tooltips at all. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15027 To: sander, #okular Cc: aacid, okular-dev

[okular] [Bug 397783] Show path of hyperlink in text selection mode

2018-08-23 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=397783 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de Ever confirmed|

D15027: Show tooltips for links only if "Show hints..." is enabled in the preferences

2018-08-23 Thread Oliver Sander
sander created this revision. sander added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY I would expect the "Show hints and info messages" option to control whether tooltips are shown when

[okular] [Bug 385951] Some applications dont show menubar after disabling global menu again

2018-08-23 Thread Øystein Steffensen-Alværvik
https://bugs.kde.org/show_bug.cgi?id=385951 Øystein Steffensen-Alværvik changed: What|Removed |Added CC||yst...@posteo.net --- Comment #11

D14904: TOC: Add collapse/expand options

2018-08-23 Thread Peter Wu
Lekensteyn added a comment. In D14904#314184 , @aacid wrote: > The style for the files you've touched is [mostly] braces on next line, not same line I see. The file also seems to prefer patterns like: if( condition ) {

D14904: TOC: Add collapse/expand options

2018-08-23 Thread Albert Astals Cid
aacid added a comment. In D14904#313955 , @Lekensteyn wrote: > In D14904#313718 , @aacid wrote: > > > The braces are all in the wrong place > > > Which braces? if (!worklist[0].

[okular] [Bug 397800] New: Okular crashed when selecting a bookmark link

2018-08-23 Thread Hubbi NM
https://bugs.kde.org/show_bug.cgi?id=397800 Bug ID: 397800 Summary: Okular crashed when selecting a bookmark link Product: okular Version: 1.3.3 Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Keyw

D14904: TOC: Add collapse/expand options

2018-08-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm good with this now. I wonder if "Expand/collapse everything" or "Expand/collapse all sections" might be clearer than "Expand/collapse all", but that's just a tiny minor probably subje

[okular] [Bug 397786] Secondary comments do not show in pdf files under Okular.

2018-08-23 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=397786 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1 from

[okular] [Bug 397786] New: Secondary comments do not show in pdf files under Okular.

2018-08-23 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=397786 Bug ID: 397786 Summary: Secondary comments do not show in pdf files under Okular. Product: okular Version: unspecified Platform: Other OS: Linux Status

[okular] [Bug 397783] New: Show path of hyperlink in text selection mode

2018-08-23 Thread David
https://bugs.kde.org/show_bug.cgi?id=397783 Bug ID: 397783 Summary: Show path of hyperlink in text selection mode Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity

D14904: TOC: Add collapse/expand options

2018-08-23 Thread Peter Wu
Lekensteyn added a comment. In D14904#313718 , @aacid wrote: > The braces are all in the wrong place Which braces? INLINE COMMENTS > aacid wrote in part.cpp:2996 > Would "Collapse children" instead of just "Collapse" make more sense? For

D14904: TOC: Add collapse/expand options

2018-08-23 Thread Peter Wu
Lekensteyn updated this revision to Diff 40289. Lekensteyn edited the summary of this revision. Lekensteyn edited the test plan for this revision. Lekensteyn added a comment. I changed the text and removed the icons as I was not able to find a suitable replacement in /usr/share/icons (no resul