D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-20 Thread Andre Heinecke
aheinecke updated this revision to Diff 27658. aheinecke added a comment. Removed check for page in field wrapping. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10073?vs=27264&id=27658 REVISION DETAIL https://phabricator.kde.org/D10073 AFFECTED FILES

D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-20 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > aheinecke wrote in kjs_field.cpp:217 > It is not assured in kjs_event.cpp eventGetSource and eventGetTarget that the > targetPage / sourcePage is not null. This depends a how the event object is > set up. > > Although I think that sourcePage "shou

[okular] [Bug 390816] New: colour palette for review tool

2018-02-20 Thread k1
https://bugs.kde.org/show_bug.cgi?id=390816 Bug ID: 390816 Summary: colour palette for review tool Product: okular Version: unspecified Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED Severity: wishlis

[okular] [Bug 390284] no such file errors

2018-02-20 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=390284 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Ever confirmed|0

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

2018-02-20 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > aheinecke wrote in document.cpp:1139 > Sorry I can't follow you here. > > If an action is processed from somewhere else the scripter won't have an > event set and the event pointer in the scripter is null. > > If the processAction is triggered her

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

2018-02-20 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=389668 abogi...@gmail.com changed: What|Removed |Added CC||abogi...@gmail.com -- You are receiving th

D10547: Recalculate forms after command form changes

2018-02-20 Thread Andre Heinecke
aheinecke updated this revision to Diff 27600. aheinecke retitled this revision from "[PATCH] Recalculate forms after command form changes" to "Recalculate forms after command form changes". aheinecke edited the test plan for this revision. aheinecke added a comment. Extended CalculateTextTest

D10504: Bug 288042 - Option to reset forms

2018-02-20 Thread Ahmad Osama
ahmadosama added a comment. I have not created an auto test before, I am currently going through current auto tests to understand how it works, then I will try creating an auto test for this bug. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10504 To: ahmadosama,

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

2018-02-20 Thread Andre Heinecke
aheinecke added inline comments. INLINE COMMENTS > aacid wrote in document.cpp:1139 > This is problematic since it will leave a dangling event pointer for any > Action::Script action executed through Document::processAction that doesn't > come from this function. Sorry I can't follow you here.

D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-20 Thread Andre Heinecke
aheinecke added inline comments. INLINE COMMENTS > aacid wrote in kjs_field.cpp:217 > Why the new if? It is not assured in kjs_event.cpp eventGetSource and eventGetTarget that the targetPage / sourcePage is not null. This depends a how the event object is set up. Although I think that sourceP