D7594: Update to synctex 1.19

2017-09-05 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH synctex-update (branched from master) REVISION DETAIL https://phabricator.kde.org/D7594 To: rkflx, #okular, sander, #kile, aacid Cc: mludwig, aacid

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-05 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D7671#143117, @aacid wrote: > It was added to make this work, and it did work at some point, i don't add code for nothing ;) Of course, and your code still works today: it fixes the rm/touch case (with https://phabricator.kde.

D7594: Update to synctex 1.19

2017-09-05 Thread Henrik Fehlauer
rkflx added a comment. Thanks, targeting master matches exactly with my own impact assessment and the FIXED-IN set in the summary. I guess bugs in synctex for particular documents should go upstream, so if you are happy with my integration work, please "accept" it from the Okular side.

[okular] [Bug 384381] Cursor over X to close note should be an arrow

2017-09-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384381 Nate Graham changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC|

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-05 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D7671#143187, @progwolff wrote: > In https://phabricator.kde.org/D7671#143118, @aacid wrote: > > > No, the code doesn't wait *only* for a dirty for path/file, read Part::slotFileDirty better > > > > The problem here is that dir

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-05 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D7671#143202, @progwolff wrote: > ~~Okay, I modified KDirWatch so we actually get a dirty signal for the directory.~~ > > Now a new problem arised. > QSaveFile does not delete and recreate the file as we thought. It just moves

[okular] [Bug 355043] Cannot differentiate between review and search highlights

2017-09-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=355043 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving thi

[okular] [Bug 384070] Text based genertors need reloading the file after font size change

2017-09-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=384070 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving thi

[okular] [Bug 384143] HiPDI: freehand line in presentation mode is blocky

2017-09-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=384143 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving thi

[okular] [Bug 384142] okular: seg at exit (For multiple input files)

2017-09-05 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=384142 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving thi

[okular] [Bug 384381] New: Cursor over X to close note should be an arrow

2017-09-05 Thread Simone Gaiarin
https://bugs.kde.org/show_bug.cgi?id=384381 Bug ID: 384381 Summary: Cursor over X to close note should be an arrow Product: okular Version: 1.2.0 Platform: Other OS: Linux Status: UNCONFIRMED Severity: min

[okular] [Bug 314909] Indicate note in annotations such as highlighting

2017-09-05 Thread Simone Gaiarin
https://bugs.kde.org/show_bug.cgi?id=314909 Simone Gaiarin changed: What|Removed |Added CC||simg...@gmail.com --- Comment #1 from Simone G

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-05 Thread Julian Wolff
progwolff added a comment. Okay, I modified KDirWatch so we actually get a dirty signal for the directory. Now a new problem arised. QSaveFile does not delete and recreate the file as we thought. It just moves the swap file to the old file's location. On move, KDirWatch still sends

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-05 Thread Julian Wolff
progwolff added a comment. In https://phabricator.kde.org/D7671#143118, @aacid wrote: > No, the code doesn't wait *only* for a dirty for path/file, read Part::slotFileDirty better > > The problem here is that dirty for the path is not being emitted, https://mail.kde.org/pipermail/kde

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2017-09-05 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=383651 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #4 from