[okular] [Bug 382011] SyncTeX 2017 upgrade

2017-09-03 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=382011 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving thi

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-03 Thread Henrik Fehlauer
rkflx added a comment. Albert: Do you remember why https://phabricator.kde.org/R223:f93ccd7923491c6b1412ba5cb1fe0711e44496d8 was necessary? There is no bug linked and no autotest. Using just the commit message as a testcase, with https://phabricator.kde.org/D7671 applied and `watcher->addDi

[okular] [Bug 371828] Wrong aspect ratio when rendering tiff file

2017-09-03 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=371828 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving thi

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-03 Thread Albert Astals Cid
aacid added a comment. I don't know who told you this is the correct behaviour of kdirwatch, but i kind of disagree. Since we're not watching the file but *also* the folder. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7671 To: progwolff, aacid Cc: sander, rk

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-03 Thread Oliver Sander
sander added a comment. Such a @note seems like a good idea. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7671 To: progwolff, aacid Cc: sander, rkflx, #okular, aacid

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-03 Thread Henrik Fehlauer
rkflx added a comment. Nice, solves the issues for me (and confirms my suspicion that this is not a regression or porting issue, as this is broken for me even on an ancient KDE4 distro), but I'll let Albert give the final "ship it". Do you think we should add a `@note` to that effect to

D7594: Update to synctex 1.19

2017-09-03 Thread Henrik Fehlauer
rkflx updated this revision to Diff 19133. rkflx edited the summary of this revision. rkflx edited the test plan for this revision. rkflx added a comment. Plug multiple leaks and prevent a segfault by adding another patch to the imported synctex code. (The patch seems simple, but the nest

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-03 Thread Julian Wolff
progwolff edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7671 To: progwolff, aacid Cc: #okular, aacid

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-03 Thread Julian Wolff
progwolff created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY Files saved with QSaveFile don't get dirty. The are deleted and replaced. Thus, inotify and KDirWatch don't emit a "dirty" signal (wich is the co