Re: Review Request 130171: Fix page-jumping-back-issue commonly encountered when in presentation mode

2017-07-03 Thread Albert Astals Cid
> On jul. 3, 2017, 9:07 p.m., Albert Astals Cid wrote: > > Sorry but no, you can't fix presentation mode by removing code out of > > pageview that you claim you don't know what it does. Debug more and come up > > with a better patch. > > Alexander Schlarb wrote: > Well, can you tell me wha

Re: Review Request 130171: Fix page-jumping-back-issue commonly encountered when in presentation mode

2017-07-03 Thread Alexander Schlarb
> On Juli 3, 2017, 11:07 nachm., Albert Astals Cid wrote: > > Sorry but no, you can't fix presentation mode by removing code out of > > pageview that you claim you don't know what it does. Debug more and come up > > with a better patch. Well, can you tell me what that code I'm trying to remove

Review Request 130172: Add support for the forward and back mouse buttons

2017-07-03 Thread Alexander Schlarb
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130172/ --- Review request for Okular. Repository: okular Description --- This

Re: Review Request 130171: Fix page-jumping-back-issue commonly encountered when in presentation mode

2017-07-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130171/#review103404 --- Sorry but no, you can't fix presentation mode by removing co

Review Request 130171: Fix page-jumping-back-issue commonly encountered when in presentation mode

2017-07-03 Thread Alexander Schlarb
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130171/ --- Review request for Okular. Repository: okular Description --- This

D6268: HiDPI Support for Okular

2017-07-03 Thread David Edmundson
davidedmundson added a comment. qApp->DPR can change within the lifespan of the app; for example plugging in a new monitor can change things. This does mean it's very important to keep the metadata of the pixmap's dpr with the pixmap. It ends up simpler and safer overall. Doesn't mea

D6268: HiDPI Support for Okular

2017-07-03 Thread Lukas Hetzenecker
hetzenecker added a comment. Thanke for your feedback. In https://phabricator.kde.org/D6268#121135, @aacid wrote: > I would very much prefer if you didn't break the ABI of the files in core/ > > Also not sure why you need to pass the devicepixel ratio up and down, isn't it the sa