Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-19 Thread Daniel Lichtenberger
> On March 14, 2016, 12:28 a.m., Albert Astals Cid wrote: > > Could you please fix all the indentation to be like the one in the file? > > Daniel Lichtenberger wrote: > ui/embeddedfilesdialog.{h,cpp} use both tabs and spaces (even within the > same method). Should I just convert them to spa

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

2016-03-19 Thread Christian Kalkhoff via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357626 --- Comment #9 from Christian Kalkhoff --- I will try to create a patch for this and add it to this issue before the next weekend. -- You are receiving this mail because: You are the assignee for the bug. __

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

2016-03-19 Thread Basti via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357626 --- Comment #8 from Basti --- Ahh sorry. now I understand what you want. You're right, the button doesn't exist. Sorry for that :) -- You are receiving this mail because: You are the assignee for the bug. __

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

2016-03-19 Thread Christian Kalkhoff via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357626 --- Comment #7 from Christian Kalkhoff --- Basti I cannot tell from your screenshot. Is the menu created from main menu -> Some Bookark -> right click or from the side panel -> Some Bookmark -> right click. I get "Delete Bookmark" in the latter but nor

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

2016-03-19 Thread Christian Kalkhoff via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357626 --- Comment #5 from Christian Kalkhoff --- Created attachment 97985 --> https://bugs.kde.org/attachment.cgi?id=97985&action=edit screenshot of the bookmarks context menu -- You are receiving this mail because: You are the assignee for the bug. _

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

2016-03-19 Thread Basti via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357626 --- Comment #6 from Basti --- Created attachment 97986 --> https://bugs.kde.org/attachment.cgi?id=97986&action=edit bookmark context menu Isn't that the menu you want? -- You are receiving this mail because: You are the assignee for the bug. __

[Okular-devel] [okular] [Bug 357626] Please add "Remove bookmark" in popup menu

2016-03-19 Thread Christian Kalkhoff via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357626 Christian Kalkhoff changed: What|Removed |Added CC||e...@softmetz.de --- Comment #4 from Chris

Re: [Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

2016-03-19 Thread Thomas Friedrichsmeier
On Thu, 17 Mar 2016 00:41:37 +0100 Albert Astals Cid wrote: > The log is at > https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/testReport/ > > Seems something is very wrong and the pdf plugin can't be found (even > if it's build) Yes. The "root symptom" is

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

2016-03-19 Thread Albert Astals Cid
> On March 10, 2016, 12:28 a.m., Albert Astals Cid wrote: > > This will put triangles in the whole chain of parent, child, child when the > > list is not a treeview, maybe we can also check somewhere else so that the > > behaviour does not change when it's not a treeview (i.e. onyl the last one

[Okular-devel] [okular] [Bug 360603] New: Markdown (.md) support

2016-03-19 Thread Thomas Fischer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=360603 Bug ID: 360603 Summary: Markdown (.md) support Product: okular Version: unspecified Platform: unspecified URL: https://en.wikipedia.org/wiki/Markdown OS: All

[Okular-devel] [okular] [Bug 314943] Visibility of "This document has embedded files" should be configurable, or at least remembered across sessions

2016-03-19 Thread Daniel Lichtenberger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=314943 Daniel Lichtenberger changed: What|Removed |Added CC||daniel.lichtenber...@gmx.ne

Re: [Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

2016-03-19 Thread Albert Astals Cid
El dimecres, 16 de març de 2016, a les 13:50:45 CET, Thomas Friedrichsmeier va escriure: > Hi, > > On Wed, 16 Mar 2016 10:05:57 + (UTC) > > no-re...@kde.org wrote: > > GENERAL INFO > > > > BUILD UNSTABLE > > Build URL: > > https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Lin

[Okular-devel] [okular] [Bug 341043] Highlighting exceeds the margins of the line

2016-03-19 Thread Germano Massullo via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=341043 Germano Massullo changed: What|Removed |Added Version|0.20.2 |0.24.0 --- Comment #2 from Germano Massullo

[Okular-devel] [okular] [Bug 341043] Highlighting exceeds the margins of the line

2016-03-19 Thread Albert Astals Cid via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=341043 --- Comment #3 from Albert Astals Cid --- The fact that you use plasma desktop or not is unrelated to okular at all, and since they are not released together the versioning you gave doesn't help either. -- You are receiving this mail because: You are

Re: [Okular-devel] Review Request 127366: Resize annotations

2016-03-19 Thread Tobias Deiminger
> On März 14, 2016, 12:46 vorm., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try asking

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

2016-03-19 Thread Miklós Máté
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127013/ --- (Updated March 17, 2016, 8:12 p.m.) Review request for Okular. Changes

[Okular-devel] [okular] [Bug 341043] Highlighting exceeds the margins of the line

2016-03-19 Thread Germano Massullo via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=341043 --- Comment #4 from Germano Massullo --- (In reply to Albert Astals Cid from comment #3) > The fact that you use plasma desktop or not is unrelated to okular at all, > and since they are not released together the versioning you gave doesn't > help eithe

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-19 Thread Daniel Lichtenberger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127351/ --- (Updated March 16, 2016, 4:59 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

2016-03-19 Thread Thomas Friedrichsmeier
Hi, On Wed, 16 Mar 2016 10:05:57 + (UTC) no-re...@kde.org wrote: > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ > Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Mar 2016 > 09:58:31 + Bui