Re: [Okular-devel] Review Request 124026: Remove leftovers from KUrl -> QUrl port

2015-07-18 Thread Jan Kundrát
> On July 9, 2015, 9:20 p.m., Albert Astals Cid wrote: > > Why are you removing the test? Seems like a value test to me to make sure > > we're differentiating when # is a char of the file and when # refers to a > > page number. Because that test always fails right now. I wasn't aware of the #

Re: [Okular-devel] Review Request 124027: s/auto_ptr/unique_ptr/

2015-07-18 Thread Alexander Potashev
> On Июль 12, 2015, 2:24 п.п., Albert Astals Cid wrote: > > > Okular is being built in C++11 mode anyway > > > > Is it? Can you point me where we enable that? C++11 is enabled in extra-cmake-modules/kde-modules/KDECompilerSettings.cmake (see line "set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c

[Okular-devel] [okular] [Bug 348296] why pop-up notes are big? i can't manipulate them between letters. I wish to have small pop-up notes so it will be easy to manipulate them between letters

2015-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=348296 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel ma

[Okular-devel] [okular] [Bug 347793] Okular crashes when opening a .doc file which is named as .pdf file.

2015-07-18 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=347793 --- Comment #3 from Christoph Feck --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -- You are receiving this m

Re: [Okular-devel] Review Request 123909: Added import/export of bookmarks as requested in Bug 336381 - easily transfer bookmarks between computers

2015-07-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123909/#review82625 --- part.cpp (line 2165)

[Okular-devel] [okular] [Bug 348644] Explain difference between 'Save as...' and 'Save copy as...' in the handbook (and possibly remove the second)

2015-07-18 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=348644 Albert Astals Cid changed: What|Removed |Added CC||lu...@hube-lueck.de, |

Re: [Okular-devel] Review Request 124381: Make KF5 based okular coinstallable with KDE4 version

2015-07-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124381/#review82622 --- CMakeLists.txt (line 219)

[Okular-devel] Review Request 124381: Make KF5 based okular coinstallable with KDE4 version

2015-07-18 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124381/ --- Review request for Okular and Albert Astals Cid. Repository: okular Des

Re: [Okular-devel] Redrawing the screen due to optional content group changes

2015-07-18 Thread Albert Astals Cid
El Divendres, 17 de juliol de 2015, a les 12:52:30, Jeremy Maitin-Shepard va escriure: > Forwarding to the list, since I sent my original reply incorrectly... > > On Fri, Jul 17, 2015 at 12:51 PM, Jeremy Maitin-Shepard > wrote: > > > > On Thu, Jul 16, 2015 at 3:16 PM, Albert Astals Cid wrote: