Re: [Okular-devel] Review Request 119640: CMake KF5

2014-08-07 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119640/ --- (Updated Aug. 7, 2014, 11:22 p.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 119595: Pass the command line options properly when using tabs or unique instances

2014-08-07 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119595/#review64020 --- Ship it! Not deep review of the code, but the test looks quit

Re: [Okular-devel] Review Request 117267: make width of the rectangle for inline note in annotations configurable

2014-08-07 Thread Albert Astals Cid
> On ago. 6, 2014, 9:05 p.m., Albert Astals Cid wrote: > > Alin: Ping > > Alin M Elena wrote: > Hi Albert, > > sorry I am a little bit out of time to do the changes at the moment... > > Alin Would you mind if i discard this review request to keep the queue cleaner and wh

Re: [Okular-devel] Review Request 119640: CMake KF5

2014-08-07 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119640/#review64018 --- Ship it! Just create a frameworks branch and feel free to wor

Re: [Okular-devel] Review Request 119595: Pass the command line options properly when using tabs or unique instances

2014-08-07 Thread Jonathan Doman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119595/#review63990 --- Ship it! Haven't had time to build and test, but the code loo

[Okular-devel] [okular] [Bug 338088] Previous page button moves to previous page in document, not previous read page

2014-08-07 Thread Tobias Winchen
https://bugs.kde.org/show_bug.cgi?id=338088 --- Comment #5 from Tobias Winchen --- On Thursday 07 August 2014 09:11:10 you wrote: > https://bugs.kde.org/show_bug.cgi?id=338088 > > --- Comment #3 from Albert Astals Cid --- > The reporter did not know the functionality existed. But in my opinion

[Okular-devel] [okular] [Bug 338088] Previous page button moves to previous page in document, not previous read page

2014-08-07 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=338088 --- Comment #4 from Jonathan Verner --- Thanks for clarifying. Online discussion has the drawback that one can't see non-verbal hints and without them, as I said, your second sentence sounded a bit harsh to me :-) As for the feature, I won't pollute

[Okular-devel] [okular] [Bug 338088] Previous page button moves to previous page in document, not previous read page

2014-08-07 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=338088 --- Comment #3 from Albert Astals Cid --- The reporter did not know the functionality existed. But in my opinion it is far "harder" to report a bug that to open the menus and look through them, so I am interested if he did look through them or not. If n

[Okular-devel] [okular] [Bug 338088] Previous page button moves to previous page in document, not previous read page

2014-08-07 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=338088 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com --- Comment #2 from

Re: [Okular-devel] Review Request 117267: make width of the rectangle for inline note in annotations configurable

2014-08-07 Thread Alin M Elena
> On Aug. 6, 2014, 9:05 p.m., Albert Astals Cid wrote: > > Alin: Ping Hi Albert, sorry I am a little bit out of time to do the changes at the moment... Alin - Alin M --- This is an automatically generated e-mail. To reply, visit: htt

[Okular-devel] Review Request 119640: CMake KF5

2014-08-07 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119640/ --- Review request for Okular. Repository: okular Description --- Basi

[Okular-devel] [okular] [Bug 338088] Previous page button moves to previous page in document, not previous read page

2014-08-07 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=338088 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Resolution|---

[Okular-devel] [okular] [Bug 338088] New: Previous page button moves to previous page in document, not previous read page

2014-08-07 Thread Tobias Winchen
https://bugs.kde.org/show_bug.cgi?id=338088 Bug ID: 338088 Summary: Previous page button moves to previous page in document, not previous read page Product: okular Version: unspecified Platform: unspecified