Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-11-27 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/ --- (Updated Nov. 28, 2013, 7:35 a.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 114060: Proposed viewport transition refinements for Find and Undo/Redo actions

2013-11-27 Thread Jon Mease
> On Nov. 27, 2013, 11:16 p.m., Albert Astals Cid wrote: > > core/utils.h, line 78 > > > > > > Same question as before, since this method seems to be used only in > > core/* can you see if you can put it in some _

Re: [Okular-devel] Review Request 114060: Proposed viewport transition refinements for Find and Undo/Redo actions

2013-11-27 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114060/ --- (Updated Nov. 28, 2013, 12:47 a.m.) Review request for Okular. Changes -

[Okular-devel] [okular] [Bug 328026] Having the option to paste selected text into an annotation.

2013-11-27 Thread Chris George
https://bugs.kde.org/show_bug.cgi?id=328026 --- Comment #10 from Chris George --- I cannot select via inserting the cursor between two letters or at the beginning of a sentence and mouse drag or shift-arrow to select the text I want. I must select a block of text, usually including text from the

[Okular-devel] [okular] [Bug 328026] Having the option to paste selected text into an annotation.

2013-11-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=328026 --- Comment #9 from Albert Astals Cid --- (In reply to comment #8) > It was the first thing I noticed about the application. The "normal" > procedure in most textual applications, like web browsers, word-processors > and text editors is to be able to hi

[Okular-devel] [okular] [Bug 328026] Having the option to paste selected text into an annotation.

2013-11-27 Thread Chris George
https://bugs.kde.org/show_bug.cgi?id=328026 --- Comment #8 from Chris George --- It was the first thing I noticed about the application. The "normal" procedure in most textual applications, like web browsers, word-processors and text editors is to be able to highlight text with the selection tool

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

2013-11-27 Thread Fabio D'Urso
> On Nov. 27, 2013, 7:49 p.m., Fabio D'Urso wrote: > > Rendering differences (that I judged ugly) were the reason why I chose to > > go the dashed outline route. > > Jon Mease wrote: > Yeah, that makes sense. How do you feel about my idea above of only using > this approach for the "geomet

Re: [Okular-devel] Review Request 114060: Proposed viewport transition refinements for Find and Undo/Redo actions

2013-11-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114060/#review44637 --- core/document.h

Re: [Okular-devel] Review Request 114019: [GCI] Extend AudioPlayer so that it gives info about if something is playing at the moment or not.

2013-11-27 Thread Egor Matirov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114019/ --- (Updated Nov. 27, 2013, 10:27 p.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 114019: [GCI] Extend AudioPlayer so that it gives info about if something is playing at the moment or not.

2013-11-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114019/#review44632 --- This review has been submitted with commit f98f55db9d6dc669e4b

Re: [Okular-devel] Review Request 113978: FB2-module tips on the references to footnotes, finding does footnote.

2013-11-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113978/#review44629 --- Ok, after you left IRC I thought about it, and it's a reasonabl

[Okular-devel] [okular] [Bug 328026] Having the option to paste selected text into an annotation.

2013-11-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=328026 --- Comment #7 from Albert Astals Cid --- How is our method of copying text unusual? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.o

Re: [Okular-devel] Review Request 113973: Proof of concept magnifying glass found in old kdvi (or current xdvi)

2013-11-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113973/#review44625 --- As said in IRC, i'm not really thrilled about this feature, but

[Okular-devel] [okular] [Bug 328026] Having the option to paste selected text into an annotation.

2013-11-27 Thread Chris George
https://bugs.kde.org/show_bug.cgi?id=328026 --- Comment #6 from Chris George --- No worries. I was trying to work towards the same goal as Docear, but using the much easier path of extracting the data required from okular's unique xml file. I guess I'll just wait for them to complete their standa

[Okular-devel] [okular] [Bug 328026] Having the option to paste selected text into an annotation.

2013-11-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=328026 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

2013-11-27 Thread Jon Mease
> On Nov. 27, 2013, 7:49 p.m., Fabio D'Urso wrote: > > Rendering differences (that I judged ugly) were the reason why I chose to > > go the dashed outline route. > > Jon Mease wrote: > Yeah, that makes sense. How do you feel about my idea above of only using > this approach for the "geomet

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

2013-11-27 Thread Fabio D'Urso
> On Nov. 27, 2013, 7:49 p.m., Fabio D'Urso wrote: > > Rendering differences (that I judged ugly) were the reason why I chose to > > go the dashed outline route. > > Jon Mease wrote: > Yeah, that makes sense. How do you feel about my idea above of only using > this approach for the "geomet

[Okular-devel] [okular] [Bug 328029] Have highlighted text show in xml file in docdata directory

2013-11-27 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=328029 Fabio D'Urso changed: What|Removed |Added CC||fabiodu...@hotmail.it --- Comment #5 from Fabio

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

2013-11-27 Thread Jon Mease
> On Nov. 27, 2013, 7:49 p.m., Fabio D'Urso wrote: > > Rendering differences (that I judged ugly) were the reason why I chose to > > go the dashed outline route. Yeah, that makes sense. How do you feel about my idea above of only using this approach for the "geometric" annotations? To my eye

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

2013-11-27 Thread Jon Mease
> On Nov. 27, 2013, 7:44 p.m., Albert Astals Cid wrote: > > Don't have an opinion to be honest. It is true that for some cases it looks > > better, but for some others it looks weird since you switch between text > > rendered by poppler and text rendered by us. I'm not oposed to either. > > Fa

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

2013-11-27 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114153/#review44612 --- Rendering differences (that I judged ugly) were the reason why

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

2013-11-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114153/#review44611 --- Don't have an opinion to be honest. It is true that for some ca

[Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

2013-11-27 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114153/ --- Review request for Okular. Repository: okular Description --- Unlik

[Okular-devel] [okular] [Bug 169847] split view feature

2013-11-27 Thread Ruslan Kabatsayev
https://bugs.kde.org/show_bug.cgi?id=169847 Ruslan Kabatsayev changed: What|Removed |Added CC||b7.10110...@gmail.com -- You are receiving