[Okular-devel] Review Request 110589: Undo support for PDF forms

2013-05-21 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110589/ --- Review request for Okular. Description --- Add undo / redo support fo

[Okular-devel] [okular] [Bug 159601] configurable review tools

2013-05-21 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=159601 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC|

Re: [Okular-devel] Review Request 110566: Configurable review tools

2013-05-21 Thread Albert Astals Cid
> On May 21, 2013, 12:07 a.m., Albert Astals Cid wrote: > > conf/widgetannottools.cpp, line 291 > > > > > > Would it make sense to try to reuse the defaultToolName function? > > Fabio D'Urso wrote: > Yes it m

Re: [Okular-devel] Review Request 110566: Configurable review tools

2013-05-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110566/ --- (Updated May 21, 2013, 9:29 p.m.) Status -- This change has been mark

Re: [Okular-devel] Review Request 110566: Configurable review tools

2013-05-21 Thread Albert Astals Cid
> On May 21, 2013, 12:07 a.m., Albert Astals Cid wrote: > > conf/widgetannottools.cpp, line 298 > > > > > > maybe i18nc here so it is clear that this is a noun and not a verb? > > Fabio D'Urso wrote: > I agre

Re: [Okular-devel] Review Request 110566: Configurable review tools

2013-05-21 Thread Fabio D'Urso
> On May 21, 2013, 12:07 a.m., Albert Astals Cid wrote: > > conf/preferencesdialog.cpp, line 51 > > > > > > Instead of draw-freehand maybe use the same icon we use in the side > > panel? It *is* draw-freehand, is

Re: [Okular-devel] Review Request 110566: Configurable review tools

2013-05-21 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110566/ --- (Updated May 21, 2013, 11:23 a.m.) Review request for Okular. Changes --