Re: [Okular-devel] Review Request 109119: Txt backend: detect encoding by chunks

2013-02-24 Thread Albert Astals Cid
> On Feb. 23, 2013, 6:51 p.m., Azat Khuzhin wrote: > > generators/txt/document.cpp, line 69 > > > > > > Maybe we must use `array.left( i )` here? > > And increment i += chunkSize before. Seems to me you should

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-24 Thread Azat Khuzhin
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109119: Txt backend: detect encoding by chunks

2013-02-24 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109119/#review27938 --- generators/txt/document.cpp

[Okular-devel] Review Request 109119: Txt backend: detect encoding by chunks

2013-02-24 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109119/ --- Review request for Okular. Description --- Don't to extra job, when e

[Okular-devel] [kdelibs] [Bug 313984] Okular crashed after changing the colour of some highlighted text

2013-02-24 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=313984 Christoph Feck changed: What|Removed |Added Component|general |general Version|0.15.5

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

2013-02-24 Thread Tomáš Poledný
> On Feb. 23, 2013, 11:50 p.m., Albert Astals Cid wrote: > > Should move it to a bool like we do in start presentation, otherwise > > okular https://bugs.freedesktop.org/attachment.cgi?id=46889 --print > > won't work I have rewritten it. I do not know if we need to change the version of inter

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

2013-02-24 Thread Tomáš Poledný
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Descriptio

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

2013-02-24 Thread Tomáš Poledný
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 109115: Make observer.h installable

2013-02-24 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/#review27957 --- the active-documentviewer touch app still works properly with t

Re: [Okular-devel] Review Request 109115: Make observer.h installable

2013-02-24 Thread Bogdan Cristea
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/#review27956 --- Ship it! works for me - Bogdan Cristea On Feb. 23, 2013, 10

[Okular-devel] [okular] [Bug 301774] Wish: New option to save embedded annotation upon change/document close

2013-02-24 Thread Sudhir Khanger
https://bugs.kde.org/show_bug.cgi?id=301774 Sudhir Khanger changed: What|Removed |Added CC||sud...@sudhirkhanger.com --- Comment #15 from

[Okular-devel] [okular] [Bug 151614] store annotations with documents

2013-02-24 Thread Sudhir Khanger
https://bugs.kde.org/show_bug.cgi?id=151614 Sudhir Khanger changed: What|Removed |Added CC||sud...@sudhirkhanger.com --- Comment #178 from