Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-30 Thread Jon Mease
> On Dec. 27, 2012, 3:22 p.m., Fabio D'Urso wrote: > > core/document.h, line 408 > > > > > > Wondering if "newProps" is redundant. I mean, isn't newProps always the > > same as annotation->getAnnotationPropertiesDo

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-30 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated Dec. 31, 2012, 3:12 a.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

2012-12-30 Thread Jaydeep Solanki
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107994/ --- (Updated Dec. 30, 2012, 11:09 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

2012-12-30 Thread Jaydeep Solanki
> On Dec. 28, 2012, 11:56 p.m., Albert Astals Cid wrote: > > Why did you add an "id"? What is that "id" supposed to mean? > > Jaydeep Solanki wrote: > because when the display name of two nodes are same, okular won't know > which one to expand & will end up expanding the wrong one at times.

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

2012-12-30 Thread Albert Astals Cid
> On Dec. 28, 2012, 11:56 p.m., Albert Astals Cid wrote: > > Why did you add an "id"? What is that "id" supposed to mean? > > Jaydeep Solanki wrote: > because when the display name of two nodes are same, okular won't know > which one to expand & will end up expanding the wrong one at times.

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

2012-12-30 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107994/#review24291 --- part.cpp

[Okular-devel] [Bug 312398] PDF: Buttons are out of function and have no button image

2012-12-30 Thread Ettore Atalan
https://bugs.kde.org/show_bug.cgi?id=312398 --- Comment #1 from Ettore Atalan --- Created attachment 76098 --> https://bugs.kde.org/attachment.cgi?id=76098&action=edit PDF -- You are receiving this mail because: You are the assignee for the bug. ___

[Okular-devel] [Bug 312398] New: PDF: Buttons are out of function and have no button image

2012-12-30 Thread Ettore Atalan
https://bugs.kde.org/show_bug.cgi?id=312398 Bug ID: 312398 Summary: PDF: Buttons are out of function and have no button image Classification: Unclassified Product: okular Version: 0.15.3 Hardware: Ubuntu Packages

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

2012-12-30 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=312188 Fabio D'Urso changed: What|Removed |Added Status|NEEDSINFO |RESOLVED CC|

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

2012-12-30 Thread OLDGUN
https://bugs.kde.org/show_bug.cgi?id=312188 --- Comment #8 from OLDGUN --- Sorry bout that but I am still rookie to gdb. The following is what I see after 'bt', at the last one it tells me to hit return to continue but the message starts to repeat so I guess this is all I could provide. BTW, I r

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

2012-12-30 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=312188 --- Comment #7 from Albert Astals Cid --- You forgot to do the "bt" command after making it crash, yes if you install the packages it suggests it will be better, but there is no need -- You are receiving this mail because: You are the assignee for the

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

2012-12-30 Thread Jaydeep Solanki
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107994/ --- (Updated Dec. 30, 2012, 4:32 p.m.) Review request for Okular. Changes --

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

2012-12-30 Thread OLDGUN
https://bugs.kde.org/show_bug.cgi?id=312188 --- Comment #6 from OLDGUN --- Yes I do see a pop-out dialog: " The window "Okular" is not responding. It belongs to the application okular (Process ID = 28834, hostname = localhost). Do you wish to terminate the application process including all of its

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

2012-12-30 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=312188 --- Comment #5 from Albert Astals Cid --- Interesting, you should be getting a dialog saying "This crashed blablabla", well, if you don't get that, just do gdb okular pathtomyfile run "make it crash" bt And paste the result of the bt command in

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

2012-12-30 Thread OLDGUN
https://bugs.kde.org/show_bug.cgi?id=312188 --- Comment #4 from OLDGUN --- Sorry I'm only rookie so how do I see the drkonqi Info? It crashes and pop out the PID, no backtrace info, but I guess it won't be too helpful . I tried to start it from konsole but it leaves no info at all. Do I need to

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

2012-12-30 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107994/#review24264 --- Can you please put the whole diff not just the new part? review

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

2012-12-30 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=312188 --- Comment #3 from Albert Astals Cid --- Can you attach a backtrace of the crash (as given by drkonqui)? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing li

Re: [Okular-devel] Regarding okular generators

2012-12-30 Thread Albert Astals Cid
El Diumenge, 30 de desembre de 2012, a les 01:30:49, Jaydeep Solanki va escriure: > On Sun, Dec 30, 2012 at 12:50 AM, Albert Astals Cid wrote: > > El Diumenge, 30 de desembre de 2012, a les 00:30:41, Jaydeep Solanki va > > > > escriure: > > > I'm aware about Textpage algorithms that regardless o