Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-27 Thread Jon Mease
On Dec. 27, 2012, 3:22 p.m., Jon Mease wrote: > > Sorry for the long delay, I've started to have a look at this new version. > > Apart from the minor issues I've noted, most code looks good to me. > > > > I'm not fully convinced by AnnotWindow changes, I've tested the code a bit > > and I've f

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

2012-12-27 Thread Albert Astals Cid
El Divendres, 28 de desembre de 2012, a les 01:48:55, Jaydeep Solanki va escriure: > I would like to give it a try, please point me to the source. You know where the source is ;-) Have you tried searching for where the code that is responsible of this before asking? > & in the case where the t

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

2012-12-27 Thread Jaydeep Solanki
I would like to give it a try, please point me to the source. & in the case where the toc is updated/changed, I guess that part should remain folded & the rest should restore to it's previous state. What's your opinion on this ?? btw is this for the reload action only, or is it about to store it &

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-27 Thread Fabio D'Urso
> On Dec. 27, 2012, 3:22 p.m., Fabio D'Urso wrote: > > core/document.cpp, line 2016 > > > > > > We need to check that uc is a TranslateAnnotationCommand too, don't we? > > (see example at > > http://qt-project.or

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

2012-12-27 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review24050 --- core/annotations.cpp