Re: [Okular-devel] Review Request: Allow the page number selector to be docked in a toolbar

2011-12-28 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103427/ --- (Updated Dec. 28, 2011, 8:21 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: Add greedy preloading option

2011-12-28 Thread Sebastian Rose
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103129/ --- (Updated Dec. 28, 2011, 8:32 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2011-12-28 Thread Albert Astals Cid
> On Aug. 28, 2011, 6:54 p.m., Albert Astals Cid wrote: > > Personally i do not like this kind of change because i've been already bit > > by Laurent blindly changing some code in KTuberling to "fix" this and the > > code stopping to work. > > > > I am not going to make the silly effort to mak

Re: [Okular-devel] Review Request: Allow the page number selector to be docked in a toolbar

2011-12-28 Thread Albert Astals Cid
> On Dec. 19, 2011, 7:30 p.m., Albert Astals Cid wrote: > > ui/pagesizelabel.cpp, line 71 > > > > > > This looks unrelated to the feature? > > Jonathan Marten wrote: > It was needed in an earlier version of this

Re: [Okular-devel] Review Request: Add greedy preloading option

2011-12-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103129/#review9333 --- Where did the changes to pageview.cpp go? Also you are still usi