https://bugs.kde.org/show_bug.cgi?id=279859
--- Comment #8 from sabik 2011-09-23 05:17:00 ---
BTW, the rectExtractText function is now only used in one place, so my
factoring it out may or may not still make sense...
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102358/
---
(Updated Sept. 23, 2011, 5:10 a.m.)
Review request for Okular.
Changes
-
https://bugs.kde.org/show_bug.cgi?id=279859
sabik changed:
What|Removed |Added
Attachment #63211|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=213251
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|
https://bugs.kde.org/show_bug.cgi?id=281813
Albert Astals Cid changed:
What|Removed |Added
CC||patrick.f...@fbc.ch
--- Comment #26 fro
https://bugs.kde.org/show_bug.cgi?id=213251
--- Comment #3 from Niels Ole Salscheider
2011-09-22 19:31:40 ---
fixed
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
https://bugs.kde.org/show_bug.cgi?id=281813
--- Comment #25 from Niels Ole Salscheider
2011-09-22 18:39:53 ---
Seems to be right now.
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
_
https://bugs.kde.org/show_bug.cgi?id=281813
--- Comment #24 from Albert Astals Cid 2011-09-22 18:21:46
---
Thanks for the review, i actually had a look at the code in the destructor and
for some reason overlooked the QFile::remove there and then m_filelist did not
make any sense anymore and
https://bugs.kde.org/show_bug.cgi?id=281813
--- Comment #23 from Niels Ole Salscheider
2011-09-22 18:06:21 ---
Thanks.
I have just noticed that you removed "m_filelist". This way, the temporary
files will not get deleted on destruction of the annotation window. Is this a
good idea?
--
Co
https://bugs.kde.org/show_bug.cgi?id=281813
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Version Fixed In|
https://bugs.kde.org/show_bug.cgi?id=281813
Niels Ole Salscheider changed:
What|Removed |Added
Attachment #63726|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=281813
--- Comment #21 from Niels Ole Salscheider
2011-09-22 09:44:23 ---
I think it is best to always display the button so that the user gets feedback
why his code does not work.
I attached a patch for that.
--
Configure bugmail: https://bugs.kde.org
https://bugs.kde.org/show_bug.cgi?id=281813
--- Comment #20 from Niels Ole Salscheider
2011-09-22 09:43:19 ---
Created an attachment (id=63851)
--> (http://bugs.kde.org/attachment.cgi?id=63851)
adds support for latex annotations to the annotation window
--
Configure bugmail: https://bugs
https://bugs.kde.org/show_bug.cgi?id=281813
Niels Ole Salscheider changed:
What|Removed |Added
Attachment #63725|0 |1
is obsolete|
14 matches
Mail list logo