Re: [PR] OAK-11433 : added OSGi config for setting max revision age for full gc [jackrabbit-oak]

2025-01-30 Thread via GitHub
rishabhdaim merged PR #2032: URL: https://github.com/apache/jackrabbit-oak/pull/2032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-30 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 32e9de191a7e40d7af0773676c7dfde228367934 / Rishabh Kumar OAK-11433 : added OSGi config for setting max revision age for full gc (#2032) * OA

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-30 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 4783eb2337bcac4166d8a447043ebc9ed6b08e6c / Rishabh Kumar OAK-11441 : removed usage of Guava Iterables.addAll with iterable.foreach() Report U

Re: [PR] OAK-11444 [full-gc] Save document id and empty properties names before deletion [jackrabbit-oak]

2025-01-30 Thread via GitHub
reschke commented on code in PR #2038: URL: https://github.com/apache/jackrabbit-oak/pull/2038#discussion_r1936721949 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Collection.java: ## @@ -99,8 +99,17 @@ public Document newDocument(DocumentStore s

Re: [PR] OAK-11439 : fixed trunk build [jackrabbit-oak]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #2040: URL: https://github.com/apache/jackrabbit-oak/pull/2040#issuecomment-2626378982 # Commit-Check ✔️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] OAK-11439 : fixed trunk build [jackrabbit-oak]

2025-01-30 Thread via GitHub
rishabhdaim opened a new pull request, #2040: URL: https://github.com/apache/jackrabbit-oak/pull/2040 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-11444 [full-gc] Save document id and empty properties names before deletion [jackrabbit-oak]

2025-01-30 Thread via GitHub
reschke commented on code in PR #2038: URL: https://github.com/apache/jackrabbit-oak/pull/2038#discussion_r1936722442 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Collection.java: ## @@ -99,8 +99,17 @@ public Document newDocument(DocumentStore s

Re: [PR] OAK-11441 : removed usage of Guava Iterables.addAll [jackrabbit-oak]

2025-01-30 Thread via GitHub
reschke commented on PR #2037: URL: https://github.com/apache/jackrabbit-oak/pull/2037#issuecomment-2624841429 Do we *really* need the null checks? If we have them, we get an NPE. If we don't, we get an NPE as well. Or am I missing something? The only difference is that p

Re: [PR] OAK-11445: Remove usage of Guava Files.toString() [jackrabbit-oak]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #2039: URL: https://github.com/apache/jackrabbit-oak/pull/2039#issuecomment-2625032332 # Commit-Check ✔️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] OAK-11445: Remove usage of Guava Files.toString() [jackrabbit-oak]

2025-01-30 Thread via GitHub
reschke opened a new pull request, #2039: URL: https://github.com/apache/jackrabbit-oak/pull/2039 See https://github.com/greenbytes/guavaVsJDKTests/blob/main/src/test/java/org/greenbytes/java/src/test/java/guavaVsJDKTests/io/FilesTest.java for why this replacement variant wa

Re: [PR] OAK-11441 : removed usage of Guava Iterables.addAll [jackrabbit-oak]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #2037: URL: https://github.com/apache/jackrabbit-oak/pull/2037#issuecomment-2624287375 # Commit-Check ✔️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] OAK-11441 : removed usage of Guava Iterables.addAll [jackrabbit-oak]

2025-01-30 Thread via GitHub
rishabhdaim opened a new pull request, #2037: URL: https://github.com/apache/jackrabbit-oak/pull/2037 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GH] (jackrabbit-oak): Workflow run "Commit Check" failed!

2025-01-30 Thread GitBox
The GitHub Actions job "Commit Check" on jackrabbit-oak.git has failed. Run started by GitHub user nfsantos (triggered by nfsantos). Head commit for run: edd76c92673e59e883bff338e27903d53e0f874b / Nuno Santos Merge remote-tracking branch 'upstream/trunk' into OAK-11438 Report URL: https://gith

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-30 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user nfsantos (triggered by nfsantos). Head commit for run: edd76c92673e59e883bff338e27903d53e0f874b / Nuno Santos Merge remote-tracking branch 'upstream/trunk' into OAK-11438 Report URL: https://github.com/

Re: [PR] OAK-11441 : removed usage of Guava Iterables.addAll [jackrabbit-oak]

2025-01-30 Thread via GitHub
sonarqubecloud[bot] commented on PR #2037: URL: https://github.com/apache/jackrabbit-oak/pull/2037#issuecomment-2624672181 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https

[GH] (jackrabbit-oak): Workflow run "Commit Check" is working again!

2025-01-30 Thread GitBox
The GitHub Actions job "Commit Check" on jackrabbit-oak.git has succeeded. Run started by GitHub user reschke (triggered by reschke). Head commit for run: 405720fae20b3aaf690b3b77d2ac6e1679778c17 / Julian Reschke OAK-11445: Remove usage of Guava Files.toString() - oak-run Report URL: https://g

[GH] (jackrabbit-oak): Workflow run "Build" is working again!

2025-01-30 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has succeeded. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 0063f98cd0d3b2c4dd02f21420771404a451416b / Rishabh Kumar OAK-11439 : set remaining full gc modes (#2036) Co-authored-by: Rishabh Kumar

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-30 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 3b3e6b838fbc387aa4448c8a3d5ede6ccfc50d90 / Rishabh Kumar OAK-11441 : removed usage of Guava Iterables.addAll Report URL: https://github.com/a

Re: [PR] OAK-11441 : removed usage of Guava Iterables.addAll [jackrabbit-oak]

2025-01-30 Thread via GitHub
rishabhdaim commented on PR #2037: URL: https://github.com/apache/jackrabbit-oak/pull/2037#issuecomment-2624327978 @reschke the replacement code is of one line but we need those `null` checks as well. That's why added the util. -- This is an automated message from the Apache Git Se

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-30 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user reschke (triggered by reschke). Head commit for run: 405720fae20b3aaf690b3b77d2ac6e1679778c17 / Julian Reschke OAK-11445: Remove usage of Guava Files.toString() - oak-run Report URL: https://github.com/

Re: [PR] OAK-11441 : removed usage of Guava Iterables.addAll [jackrabbit-oak]

2025-01-30 Thread via GitHub
rishabhdaim commented on PR #2037: URL: https://github.com/apache/jackrabbit-oak/pull/2037#issuecomment-2626271576 @reschke addressed the changes in https://github.com/apache/jackrabbit-oak/pull/2037/commits/4783eb2337bcac4166d8a447043ebc9ed6b08e6c. -- This is an automated message from th

Re: [PR] OAK-11440: Remove usage of Guava Files.touch() [jackrabbit-oak]

2025-01-30 Thread via GitHub
reschke merged PR #2035: URL: https://github.com/apache/jackrabbit-oak/pull/2035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jac

Re: [PR] OAK-11439 : set remaining full gc modes [jackrabbit-oak]

2025-01-30 Thread via GitHub
rishabhdaim merged PR #2036: URL: https://github.com/apache/jackrabbit-oak/pull/2036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

Re: [PR] OAK-11439 : set remaining full gc modes [jackrabbit-oak]

2025-01-30 Thread via GitHub
sonarqubecloud[bot] commented on PR #2036: URL: https://github.com/apache/jackrabbit-oak/pull/2036#issuecomment-2624041553 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https