Re: [PR] OAK-11395 : extracted out Set methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
sonarqubecloud[bot] commented on PR #1988: URL: https://github.com/apache/jackrabbit-oak/pull/1988#issuecomment-2592833471 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https

[GH] (jackrabbit-oak): Workflow run "Build" is working again!

2025-01-15 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has succeeded. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: e6fcad78083b71be5bbe791dad3cd32e64f68465 / Rishabh Kumar OAK-11395 : extracted out Set methods from CollectionUtils Report URL: https://gi

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-15 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user nfsantos (triggered by nfsantos). Head commit for run: f3f5e4cf76aef3116fb25ac79a2baaddd7c56c14 / Nuno Santos Avoid creation of iterator when creating a CompositeEditor. Small code cleanups. Report URL:

[GH] (jackrabbit-oak): Workflow run "Commit Check" is working again!

2025-01-15 Thread GitBox
The GitHub Actions job "Commit Check" on jackrabbit-oak.git has succeeded. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: e6fcad78083b71be5bbe791dad3cd32e64f68465 / Rishabh Kumar OAK-11395 : extracted out Set methods from CollectionUtils Report URL: htt

Re: [PR] OAK-11395 : extracted out Set methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
github-actions[bot] commented on PR #1988: URL: https://github.com/apache/jackrabbit-oak/pull/1988#issuecomment-2592321481 # Commit-Check ✔️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] OAK-11395 : extracted out Set methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
rishabhdaim opened a new pull request, #1988: URL: https://github.com/apache/jackrabbit-oak/pull/1988 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-11396 : removed usage of Guava's Preconditions.checkElementIndex [jackrabbit-oak]

2025-01-15 Thread via GitHub
rishabhdaim merged PR #1990: URL: https://github.com/apache/jackrabbit-oak/pull/1990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

Re: Proposal: Disable spotbugs

2025-01-15 Thread Julian Reschke
On 14.01.2025 11:44, Konrad Windszus wrote: Hi, Spotbugs is being used both with profile “pedantic” and “release”. However violations don’t fail the build: https://github.com/apache/jackrabbit-oak/blame/fe9c04c3b567386dfb5d262971a278cd2c634a86/oak-parent/pom.xml#L1065./ I get quite some violati

Re: Getting expanded form name from Item

2025-01-15 Thread Julian Reschke
On 15.01.2025 20:57, Konrad Windszus wrote: Hi, I am wondering what is the best way to get the expanded form name (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form) from a given javax.jcr.Item (Node or Property). T

Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

2025-01-15 Thread Julian Reschke
On 14.01.2025 11:18, Konrad Windszus wrote: Hi, I see lots of checkstyle errors during building: "[INFO] --- checkstyle:3.5.0:check (default) @ oak-jackrabbit-api --- [INFO] There are 761 errors reported by Checkstyle 9.3 with sun_checks.xml ruleset. [ERROR] src/main/java/org/apache/jackrabbit/

Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

2025-01-15 Thread Julian Reschke
On 14.01.2025 11:38, Konrad Windszus wrote: Hi Although the build was finally successfu it took 1 hour 24 minutes on my computer and emitted 31 MB of build log. I consider this a state we should definitely revisit. Yes. I am not in favour of releasing the code base in this state. However, I

[RESULT[ VOTE] Release Apache Jackrabbit Oak 1.74.0

2025-01-15 Thread Julian Reschke
On 12.01.2025 22:55, Julian Reschke wrote: ... Hi there, The vote passes as follows: +1 Jörg Hoh +1 Julian Reschke +1 Manfred Baedke +1 Rishabh Daim Thanks for voting. I'll push the release out. Best regards, Julian

Getting expanded form name from Item

2025-01-15 Thread Konrad Windszus
Hi, I am wondering what is the best way to get the expanded form name (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form) from a given javax.jcr.Item (Node or Property). There is no method exposed directly from http

Re: [PR] OAK-11388 : extracted out Map methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
reschke commented on code in PR #1989: URL: https://github.com/apache/jackrabbit-oak/pull/1989#discussion_r1916771786 ## oak-commons/src/test/java/org/apache/jackrabbit/oak/commons/collections/MapUtilsTest.java: ## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] OAK-11394 - Avoid creation of iterator when creating a CompositeEditor [jackrabbit-oak]

2025-01-15 Thread via GitHub
nfsantos merged PR #1987: URL: https://github.com/apache/jackrabbit-oak/pull/1987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@ja

Re: [PR] OAK-11388 : extracted out Map methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
github-actions[bot] commented on PR #1989: URL: https://github.com/apache/jackrabbit-oak/pull/1989#issuecomment-2593034913 # Commit-Check ✔️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] OAK-11395 : extracted out Set methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
rishabhdaim merged PR #1988: URL: https://github.com/apache/jackrabbit-oak/pull/1988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

[PR] OAK-11388 : extracted out Map methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
rishabhdaim opened a new pull request, #1989: URL: https://github.com/apache/jackrabbit-oak/pull/1989 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-11388 : extracted out Map methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
rishabhdaim commented on code in PR #1989: URL: https://github.com/apache/jackrabbit-oak/pull/1989#discussion_r1916797990 ## oak-commons/src/test/java/org/apache/jackrabbit/oak/commons/collections/MapUtilsTest.java: ## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software Fo

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-15 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 6f235a01364bad64ce426b873a1ddbc9cd4a62b6 / Rishabh Kumar OAK-11395 : extracted out Set methods from CollectionUtils (#1988) Co-authored-by:

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-15 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user nfsantos (triggered by nfsantos). Head commit for run: 80171773f4ae02b9245ffb3cbf8b80c91be3e205 / Nuno Santos OAK-11394 - Avoid creation of iterator when creating a CompositeEditor. (#1987) Report URL:

Re: Proposal: Disable checkstyle

2025-01-15 Thread Miroslav Smiljanic
+1 Regards, Miroslav On Tue, Jan 14, 2025 at 11:32 AM Konrad Windszus wrote: > Hi, > AFAIK we don’t leverage any automated formatters nor provide a clear > guidance on code formatting ( > https://jackrabbit.apache.org/oak/docs/participating.html#coding-style) > Still there is the checkstyle-mav

[GH] (jackrabbit-oak): Workflow run "Build" is working again!

2025-01-15 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has succeeded. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: f8a8713876507e121a42cc3b8e67cf674d7b0b1f / Rishabh Kumar OAK-11388 : extracted out Map methods from CollectionUtils Report URL: https://gi

Re: [PR] OAK-11388 : extracted out Map methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
sonarqubecloud[bot] commented on PR #1989: URL: https://github.com/apache/jackrabbit-oak/pull/1989#issuecomment-2593463124 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https

Re: [PR] OAK-11396 : removed usage of Guava's Preconditions.checkElementIndex [jackrabbit-oak]

2025-01-15 Thread via GitHub
github-actions[bot] commented on PR #1990: URL: https://github.com/apache/jackrabbit-oak/pull/1990#issuecomment-2593580031 # Commit-Check ✔️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] OAK-11396 : removed usage of Guava's Preconditions.checkElementIndex [jackrabbit-oak]

2025-01-15 Thread via GitHub
rishabhdaim opened a new pull request, #1990: URL: https://github.com/apache/jackrabbit-oak/pull/1990 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-11388 : extracted out Map methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
sonarqubecloud[bot] commented on PR #1989: URL: https://github.com/apache/jackrabbit-oak/pull/1989#issuecomment-2593502687 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https

Re: [PR] OAK-11388 : extracted out Map methods from CollectionUtils [jackrabbit-oak]

2025-01-15 Thread via GitHub
rishabhdaim merged PR #1989: URL: https://github.com/apache/jackrabbit-oak/pull/1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

[GH] (jackrabbit-oak): Workflow run "Build" failed!

2025-01-15 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 9e33e09df6e2b318c671212d1683797401229d56 / Rishabh Kumar OAK-11388 : extracted out Map methods from CollectionUtils (#1989) * OAK-11388 : ex

[GH] (jackrabbit-oak): Workflow run "Build" is working again!

2025-01-15 Thread GitBox
The GitHub Actions job "Build" on jackrabbit-oak.git has succeeded. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 43b81151c3f6c04540ee9431771966bdd531c595 / Rishabh Kumar OAK-11396 : removed usage of Guava's Preconditions.checkElementIndex Report URL:

Re: [PR] OAK-11396 : removed usage of Guava's Preconditions.checkElementIndex [jackrabbit-oak]

2025-01-15 Thread via GitHub
sonarqubecloud[bot] commented on PR #1990: URL: https://github.com/apache/jackrabbit-oak/pull/1990#issuecomment-2593978120 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https