[GH] (jackrabbit-oak): Workflow run "SonarCloud" is working again!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has succeeded. Run started by GitHub user shodaaan (triggered by rishabhdaim). Head commit for run: 252a66295be3d9ced6520dbb28d0660191bb2196 / shodaaan - fixed camel case Report URL: https://github.com/apache/jackrabbit-oak/actions/runs

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: a0294fdda242cbc553ad1dc066c9a7084e1cf695 / stefan-egli OAK-10843 : exclude a flaky test combination (#1554) Report URL: https://github.c

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user Joscorbe (triggered by Joscorbe). Head commit for run: a32c7dd5bd768174d8c3a9d0a2a80e6b6da8d324 / José Andrés Cordero Benítez OAK-10748: Added report indentation like in collect method Report URL:

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user Joscorbe (triggered by Joscorbe). Head commit for run: 66188405e2949aba3f4dc425e612c64f5afafebc / Jose Cordero Unneeded import. Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/964

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user Joscorbe (triggered by Joscorbe). Head commit for run: 1d700cfb1c6673593c2ec8be5f84d7d6e6236f25 / Jose Cordero OAK-10915: Avoid deleting expired checkpoints when running FullGC on a read-only NodeS

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user dulceanu (triggered by dulceanu). Head commit for run: 2b734cfba6e8300e9846097c459398c65d75cdb0 / Andrei Dulceanu OAK-10917 - Make persistent cache related arguments optional for Azure compaction

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: b1c9659fe6e8832987b20b805cfe3384573a8546 / Stefan Egli OAK-10843 : exclude a flaky test combination Report URL: https://github.com/apach

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user dulceanu (triggered by dulceanu). Head commit for run: 262973e58288f843f2bd76d0d69a7223f1580f7e / Andrei Dulceanu OAK-10917 - Make persistent cache related arguments optional for Azure compaction

Re: [PR] OAK-10843 : exclude a flaky test combination [jackrabbit-oak]

2024-06-24 Thread Arun Ram
Ccscsce@÷@÷e@ ÷se""÷csse,,ec,scce,se,cse,se,se,cse,csse,ccsce,ssse,cssce,se,csce,scce,e,cscc,sce,csccssess@ ÷÷@@ßeéwrŕrrrŕ On Mon, 24 Jun, 2024, 19:00 stefan-egli (via GitHub), wrote: > > stef

Re: [PR] OAK-10896: - Add OSGI configuration variable for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1651122982 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/util/UtilsTest.java: ## @@ -236,6 +237,30 @@ public void fullGCDisabledForRDB() {

Re: [PR] OAK-10896: - Add OSGI configuration variable for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1651122588 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -1009,6 +1009,16 @@ public static boolean isEmbeddedVerif

Re: [PR] OAK-10896: - Add OSGI configuration variable for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r165738 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -47,13 +47,13 @@ import org.apache.jackrabbit.oak.plugins.document.NodeDocu

[PR] OAK-10917 - Make persistent cache related arguments optional for Azur… [jackrabbit-oak]

2024-06-24 Thread via GitHub
dulceanu opened a new pull request, #1555: URL: https://github.com/apache/jackrabbit-oak/pull/1555 …e compaction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] OAK-10896: - Add OSGI configuration variable for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1651098372 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java: ## @@ -2603,7 +2605,7 @@ private void cleanOrphanedBranch

Re: [PR] OAK-10896: - Add OSGI configuration variable for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1651096514 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java: ## @@ -692,7 +694,7 @@ public int getMemory() {

Re: [PR] OAK-10896: - Add OSGI configuration variable for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1651080682 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -69,10 +69,11 @@ import static org.apache.jackrabbit.oak.plugins.documen

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: 512cf2f2c77f6656cf7ee72a5b7dc7ca1a02e500 / Stefan Egli OAK-10843 : exclude a flaky test combination Report URL: https://github.com/apach

[PR] OAK-10843 : exclude a flaky test combination [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli opened a new pull request, #1554: URL: https://github.com/apache/jackrabbit-oak/pull/1554 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 922d17ea5d15911837a58da877bb2de5b30b7eb5 / Rishabh Kumar Merge pull request #1551 from apache/OAK-10912 OAK-10912 : make fullGc include

[GH] (jackrabbit-oak): Workflow run "SonarCloud" is working again!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has succeeded. Run started by GitHub user shodaaan (triggered by rishabhdaim). Head commit for run: cda3b5c40513709599073a5844749906ea0032c4 / shodaaan - made some of the requested PR changes - reverted CommitBuilderTest to previous vers

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim merged PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

Re: [PR] OAK-10896: - Add OSGI configuration variable for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1650969435 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java: ## @@ -692,7 +694,7 @@ public int getMemory() {

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user Joscorbe (triggered by Joscorbe). Head commit for run: a32c7dd5bd768174d8c3a9d0a2a80e6b6da8d324 / José Andrés Cordero Benítez OAK-10748: Added report indentation like in collect method Report URL:

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user Joscorbe (triggered by Joscorbe). Head commit for run: d33dd23ae5569e84fe6b4fb4585685dd197f73d4 / José Andrés Cordero Benítez OAK-10748: Restore public on setStatisticsProvider method Report URL:

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: 9d4d35cf14c241e6474a513c22bf43327eee3a12 / stefan-egli Merge pull request #1553 from apache/OAK-10914-1 OAK-10914 : disable mongo-server

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: dc8bdb8c000d7c68d66dfcc1bb2ac4cb5f1c9ae4 / Stefan Egli OAK-10914 : disable mongo-server-side exclude paths until query performance is fi

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 55f310e2d65cfe3208ff7688ce93787eccb0cfba / Rishabh Kumar OAK-10912 : changed config names and updated documentation Report URL: https://

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650892053 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreServiceConfigurationTest.java: ## @@ -83,7 +84,9 @@ public vo

Re: [PR] OAK-10896: - Add feature toggle for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1650889773 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGCTest.java: ## @@ -531,6 +531,57 @@ public void testResetFullGCDryRunMode

Re: [PR] OAK-10896: - Add feature toggle for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1650887782 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -238,6 +239,8 @@ static DocumentStoreType fr

Re: [PR] OAK-10896: - Add feature toggle for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1650887172 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java: ## @@ -692,7 +694,7 @@ public int getMemory() {

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
Joscorbe commented on PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#issuecomment-2186350396 I will squash this PR into a single commit once approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] OAK-10914 : disable mongo-server-side exclude paths until query perfo… [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli merged PR #1553: URL: https://github.com/apache/jackrabbit-oak/pull/1553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
Joscorbe commented on code in PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#discussion_r1650867475 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -240,7 +240,21 @@ static FullGCMode getFullGc

Re: [PR] OAK-10914 : disable mongo-server-side exclude paths until query perfo… [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on PR #1553: URL: https://github.com/apache/jackrabbit-oak/pull/1553#issuecomment-2186346121 > I think we might need to update the test for this as well. Client-side incl/exclude always also applies (perhaps something to improve at some point), so if mongo doesn'

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650864494 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreServiceConfigurationTest.java: ## @@ -83,7 +84,9 @@ public vo

Re: [PR] OAK-10914 : disable mongo-server-side exclude paths until query perfo… [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on PR #1553: URL: https://github.com/apache/jackrabbit-oak/pull/1553#issuecomment-2186335794 I think we might need to update the test for this as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] OAK-10914 : disable mongo-server-side exclude paths until query perfo… [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli opened a new pull request, #1553: URL: https://github.com/apache/jackrabbit-oak/pull/1553 …rmance is fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
Joscorbe commented on PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#issuecomment-2186329449 > actually, there are compilation errors: > > ``` > [INFO] - > Error: COMPILATION ERROR : > [INFO]

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
Joscorbe commented on code in PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#discussion_r1650854809 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -535,8 +544,8 @@ private void collectDocument(RevisionsOptions options, Clo

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650849974 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java: ## @@ -260,6 +260,27 @@ "are separate

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650849122 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java: ## @@ -170,6 +174,8 @@ public class DocumentNod

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650825750 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java: ## @@ -260,6 +260,27 @@ "are separate

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#issuecomment-2186287106 actually, there are compilation errors: ``` [INFO] - Error: COMPILATION ERROR : [INFO] -

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on code in PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#discussion_r1650820289 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -535,8 +544,8 @@ private void collectDocument(RevisionsOptions options,

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650776449 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java: ## @@ -260,6 +260,27 @@ "are separate

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 167b46c5eaa518d39bad952853ac55bed2e0b7a5 / Rishabh Kumar OAK-10912 : unit cases for invalid paths Report URL: https://github.com/apache/

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 772c8559d4fdfa7e9fd8d251272f18606325ca04 / Rishabh Kumar OAK-10912 : removed the inValid paths Report URL: https://github.com/apache/jac

Re: [PR] OAK-10896: - Add feature toggle for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#issuecomment-2186194768 PS: I think we should adjust jira/pr titles to talk about osgi config instead of feature toggle (to avoid future confusion) -- This is an automated message from the Apache Gi

Re: [PR] OAK-10896: - Add feature toggle for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1650729569 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java: ## @@ -692,7 +694,7 @@ public int getMemory() {

[GH] (jackrabbit-oak): Workflow run "SonarCloud" is working again!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has succeeded. Run started by GitHub user shodaaan (triggered by stefan-egli). Head commit for run: 5d64cbaa050493ec2e7492885622ff0870974b50 / shodaaan - made requested PR changes - modified setFullGCMode method to set fullGCMode to defa

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650721462 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilderTest.java: ## @@ -67,6 +68,20 @@ public void fu

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650713278 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreServiceConfigurationTest.java: ## @@ -115,6 +118,22 @@ public

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650697389 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreServiceConfigurationTest.java: ## @@ -115,6 +118,22 @@ public

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650695069 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -499,6 +499,8 @@ private void configureBu

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650412061 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -499,6 +499,8 @@ private void configureBu

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-24 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650371659 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket, M

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user Joscorbe (triggered by Joscorbe). Head commit for run: 9c1b96d2698c2b9ad1e76d0f74d36736f9cf2437 / José Andrés Cordero Benítez Merge branch 'trunk' into OAK-10748 Report URL: https://github.com/apa

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-06-24 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user thomasmueller (triggered by thomasmueller). Head commit for run: 6e2e0791e23e924b72e03f8cc6dd846a7ed4a576 / Thomas Mueller OAK-10913 SQL-2 grammar: remove documentation for distinct Report URL: htt

Re: [PR] OAK-10742 : add support for defining include/exclude paths for fullGC [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on code in PR #1547: URL: https://github.com/apache/jackrabbit-oak/pull/1547#discussion_r1650518213 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoVersionGCSupport.java: ## @@ -132,6 +133,56 @@ public CloseableIter

[PR] OAK-10913 SQL-2 grammar: remove documentation for distinct [jackrabbit-oak]

2024-06-24 Thread via GitHub
thomasmueller opened a new pull request, #1552: URL: https://github.com/apache/jackrabbit-oak/pull/1552 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] OAK-10896: - Add feature toggle for removal of deleted properties and orphaned nodes [jackrabbit-oak]

2024-06-24 Thread via GitHub
shodaaan commented on code in PR #1539: URL: https://github.com/apache/jackrabbit-oak/pull/1539#discussion_r1650451430 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGCTest.java: ## @@ -531,6 +531,51 @@ public void testResetFullGCDryRunMode