[GH] (jackrabbit-oak): Workflow run "SonarCloud" is working again!

2024-06-23 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has succeeded. Run started by GitHub user nfsantos (triggered by nfsantos). Head commit for run: 32ef714ab78c4e6d141c1bc80d12b83e75c864cc / Nuno Santos Merge remote-tracking branch 'upstream/trunk' into OAK-10903 Report URL: https://git

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-23 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650412889 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreServiceConfigurationTest.java: ## @@ -115,6 +118,22 @@ public

Re: [PR] OAK-10912 : make fullGc include/exclude paths configurable via OSGI config [jackrabbit-oak]

2024-06-23 Thread via GitHub
rishabhdaim commented on code in PR #1551: URL: https://github.com/apache/jackrabbit-oak/pull/1551#discussion_r1650412061 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -499,6 +499,8 @@ private void configureBu

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650374514 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650374514 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650372569 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650372442 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650372015 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650371659 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket, M

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650371492 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket, M

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650350025 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650348764 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650348034 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650346400 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650340220 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650340383 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,