Re: [NDCTL PATCH v5 2/3] cxl: Enumerate major/minor of FWCTL char device

2025-04-11 Thread Dave Jiang
On 4/11/25 1:53 PM, Alison Schofield wrote: > On Fri, Apr 11, 2025 at 11:47:36AM -0700, Dave Jiang wrote: > > big snip... > >> +char path[CXL_PATH_MAX]; > > A bit of minutiae, not directly related to your patch- > > I see: > ndctl keys code, (ndctl/key.s,load-keys) simply use the PATH_MA

Re: [NDCTL PATCH v5 2/3] cxl: Enumerate major/minor of FWCTL char device

2025-04-11 Thread Alison Schofield
On Fri, Apr 11, 2025 at 11:47:36AM -0700, Dave Jiang wrote: big snip... > + char path[CXL_PATH_MAX]; A bit of minutiae, not directly related to your patch- I see: ndctl keys code, (ndctl/key.s,load-keys) simply use the PATH_MAX which I believe comes from limits.h The rest of ndctl is doing

[NDCTL PATCH v5 1/3] cxl: Add cxl_bus_get_by_provider()

2025-04-11 Thread Dave Jiang
Add helper function cxl_bus_get_by_provider() in order to support unit test that will utilize the API call. Signed-off-by: Dave Jiang --- v5: - Add documentation for API. (Alison) --- Documentation/cxl/lib/libcxl.txt | 2 ++ cxl/lib/libcxl.c | 11 +++ cxl/lib/libcxl.sym

[NDCTL PATCH v5 3/3] cxl/test: Add test for cxl features device

2025-04-11 Thread Dave Jiang
Add a unit test to verify the features ioctl commands. Test support added for locating a features device, retrieve and verify the supported features commands, retrieve specific feature command data, retrieve test feature data, and write and verify test feature data. Signed-off-by: Dave Jiang ---

[NDCTL PATCH v5 2/3] cxl: Enumerate major/minor of FWCTL char device

2025-04-11 Thread Dave Jiang
Add major/minor discovery for the FWCTL character device that is associated with supprting CXL Features under 'struct cxl_fwctl'. A 'struct cxl_fwctl' may be installed under cxl_memdev if CXL Features are supported and FWCTL is enabled. Add libcxl API functions to retrieve the major and minor of th

[NDCTL PATCH v5 0/3] ndctl: Add support and test for CXL Features support

2025-04-11 Thread Dave Jiang
v5: - Add documentation for exported symbols. (Alison) - Create 'struct cxl_fwctl' as object under cxl_memdev. (Dan) - Make command prep common code. (Alison) - Rename fwctl.c to cxl-features-control.c. (Alison) - See individual commits for specific changes from v4. v4: - Adjust to kernel changes