Re: [NDCTL PATCH v4 3/3] cxl/test: Add test for cxl features device

2025-04-09 Thread Dave Jiang
On 4/9/25 1:40 PM, Alison Schofield wrote: > On Tue, Feb 18, 2025 at 03:59:56PM -0700, Dave Jiang wrote: >> Add a unit test to verify the features ioctl commands. Test support added >> for locating a features device, retrieve and verify the supported features >> commands, retrieve specific featu

Re: [NDCTL PATCH v4 3/3] cxl/test: Add test for cxl features device

2025-04-09 Thread Dave Jiang
On 4/9/25 1:40 PM, Alison Schofield wrote: > On Tue, Feb 18, 2025 at 03:59:56PM -0700, Dave Jiang wrote: >> Add a unit test to verify the features ioctl commands. Test support added >> for locating a features device, retrieve and verify the supported features >> commands, retrieve specific featu

Re: [BUG Report] 6.15-rc1 RIP: 0010:__lruvec_stat_mod_folio+0x7e/0x250

2025-04-09 Thread Dan Williams
David Hildenbrand wrote: [..] > > However, raises the question if fixing it here is sufficient for other > > ZONE_DEVICE folio cases. I did not immediately find a place where other > > ZONE_DEVICE users might be calling prep_compound_page() and leaving > > stale tail page metadata lying around. Ali

Re: [BUG Report] 6.15-rc1 RIP: 0010:__lruvec_stat_mod_folio+0x7e/0x250

2025-04-09 Thread Alison Schofield
On Wed, Apr 09, 2025 at 10:25:18PM +0200, David Hildenbrand wrote: > On 09.04.25 22:08, Dan Williams wrote: > > David Hildenbrand wrote: > > [..] snip > > > Let me send an official patch tomorrow; maybe Alison can comment until then > if that fixes the issue. Either of the #ifdef's proposed res

Re: [NDCTL PATCH v4 3/3] cxl/test: Add test for cxl features device

2025-04-09 Thread Alison Schofield
On Tue, Feb 18, 2025 at 03:59:56PM -0700, Dave Jiang wrote: > Add a unit test to verify the features ioctl commands. Test support added > for locating a features device, retrieve and verify the supported features > commands, retrieve specific feature command data, retrieve test feature > data, and

Re: [BUG Report] 6.15-rc1 RIP: 0010:__lruvec_stat_mod_folio+0x7e/0x250

2025-04-09 Thread David Hildenbrand
On 09.04.25 22:08, Dan Williams wrote: David Hildenbrand wrote: [..] Maybe there is something missing in ZONE_DEVICE freeing/splitting code of large folios, where we should do the same, to make sure that all page->memcg_data is actually 0? I assume so. Let me dig. I suspect this should do th

Re: [BUG Report] 6.15-rc1 RIP: 0010:__lruvec_stat_mod_folio+0x7e/0x250

2025-04-09 Thread Dan Williams
David Hildenbrand wrote: [..] > > Maybe there is something missing in ZONE_DEVICE freeing/splitting code > > of large folios, where we should do the same, to make sure that all > > page->memcg_data is actually 0? > > > > I assume so. Let me dig. > > > > I suspect this should do the trick: > > d

Re: [BUG Report] 6.15-rc1 RIP: 0010:__lruvec_stat_mod_folio+0x7e/0x250

2025-04-09 Thread Dan Williams
David Hildenbrand wrote: [..] > > ^ That's different: locked|uptodate. Other page flags arriving here are > > not locked | uptodate. > > > > Git bisect says this is first bad patch (6.14 --> 6.15-rc1) > > 4996fc547f5b ("mm: let _folio_nr_pages overlay memcg_data in first tail > > page") > > > >