Re: [PATCH] btt: fix block integrity

2024-11-13 Thread Christoph Hellwig
On Wed, Nov 13, 2024 at 02:06:02PM -0800, Dan Williams wrote: > True, I think it is worth starting the deprecation process and see who > screams. It is easy enough to revive if there are still users out there > that have not since moved back to NVME for storage. Were there every any users? I've s

Re: [PATCH] nvdimm: rectify the illogical code within nd_dax_probe()

2024-11-13 Thread Dave Jiang
On 11/8/24 1:55 AM, Yi Yang wrote: > When nd_dax is NULL, nd_pfn is consequently NULL as well. Nevertheless, > it is inadvisable to perform pointer arithmetic or address-taking on a > NULL pointer. > Introduce the nd_dax_devinit() function to enhance the code's logic and > improve its readabilit

Re: [PATCH] btt: fix block integrity

2024-11-13 Thread Dan Williams
Jeff Moyer wrote: > Dan Williams writes: > > > Keith Busch wrote: > >> On Wed, Nov 13, 2024 at 01:03:58PM -0600, Ira Weiny wrote: > >> > Keith Busch wrote: > >> > > From: Keith Busch > >> > > > >> > > bip is NULL before bio_integrity_prep(). > >> > > >> > Did this fail in some way the user mig

Re: [PATCH] btt: fix block integrity

2024-11-13 Thread Jeff Moyer
Dan Williams writes: > Keith Busch wrote: >> On Wed, Nov 13, 2024 at 01:03:58PM -0600, Ira Weiny wrote: >> > Keith Busch wrote: >> > > From: Keith Busch >> > > >> > > bip is NULL before bio_integrity_prep(). >> > >> > Did this fail in some way the user might see? How was this found? >> >> I

Re: [PATCH] btt: fix block integrity

2024-11-13 Thread Dan Williams
Keith Busch wrote: > On Wed, Nov 13, 2024 at 01:03:58PM -0600, Ira Weiny wrote: > > Keith Busch wrote: > > > From: Keith Busch > > > > > > bip is NULL before bio_integrity_prep(). > > > > Did this fail in some way the user might see? How was this found? > > I think this means no one ever used

Re: [PATCH] btt: fix block integrity

2024-11-13 Thread Keith Busch
On Wed, Nov 13, 2024 at 01:03:58PM -0600, Ira Weiny wrote: > Keith Busch wrote: > > From: Keith Busch > > > > bip is NULL before bio_integrity_prep(). > > Did this fail in some way the user might see? How was this found? I think this means no one ever used block integrity with btt. :) I found

Re: [PATCH] btt: fix block integrity

2024-11-13 Thread Ira Weiny
Keith Busch wrote: > From: Keith Busch > > bip is NULL before bio_integrity_prep(). Did this fail in some way the user might see? How was this found? I think the code is correct but should this be backported to stable or anything? Ira > > Signed-off-by: Keith Busch > --- > drivers/nvdimm/