Re: [ndctl PATCH v2 4/6] cxl/region: Add creation of Dynamic capacity regions

2024-11-05 Thread Alison Schofield
On Mon, Nov 04, 2024 at 08:10:48PM -0600, Ira Weiny wrote: > From: Navneet Singh > > CXL Dynamic Capacity Devices (DCDs) optionally support dynamic capacity > with up to eight partitions (Regions) (dc0-dc7). CXL regions can now be > spare and defined as dynamic capacity (dc). > > Add support fo

Re: [ndctl PATCH v2 3/6] ndctl: Separate region mode from decoder mode

2024-11-05 Thread Fan Ni
On Mon, Nov 04, 2024 at 08:10:47PM -0600, Ira Weiny wrote: > With the introduction of DCD, region mode and decoder mode no longer > remain a 1:1 relation. An interleaved region may be made up of Dynamic > Capacity partitions with different indexes on each of the target > devices. > > Introduce a

Re: [ndctl PATCH v2 2/6] ndctl/cxl/region: Report max size for region creation

2024-11-05 Thread Fan Ni
On Mon, Nov 04, 2024 at 08:10:46PM -0600, Ira Weiny wrote: > When creating a region if the size exceeds the max an error is printed. > However, the max available space is not reported which makes it harder > to determine what is wrong. > > Add the max size available to the output error. > > Signe

Re: [ndctl PATCH v2 5/6] ndctl/cxl: Add extent output to region query

2024-11-05 Thread Ira Weiny
Dave Jiang wrote: [snip] > > +static void cxl_extents_init(struct cxl_region *region) > > +{ > > + const char *devname = cxl_region_get_devname(region); > > + struct cxl_ctx *ctx = cxl_region_get_ctx(region); > > + char *extent_path, *dax_region_path; > > + struct dirent *de; > > + DIR

Re: [ndctl PATCH v2 4/6] cxl/region: Add creation of Dynamic capacity regions

2024-11-05 Thread Ira Weiny
Dave Jiang wrote: > > > On 11/4/24 7:10 PM, ira.we...@intel.com wrote: > > From: Navneet Singh > > > > CXL Dynamic Capacity Devices (DCDs) optionally support dynamic capacity > > with up to eight partitions (Regions) (dc0-dc7). CXL regions can now be > > spare and defined as dynamic capacity (

Re: [ndctl PATCH v2 6/6] ndctl/cxl/test: Add Dynamic Capacity tests

2024-11-05 Thread Ira Weiny
Dave Jiang wrote: > > > On 11/4/24 7:10 PM, Ira Weiny wrote: > > cxl_test provides a good way to ensure quick smoke and regression > > testing. The complexity of DCD and the new sparse DAX regions required > > to use them benefits greatly with a series of smoke tests. > > > > The only part of t

Re: [ndctl PATCH v2 5/6] ndctl/cxl: Add extent output to region query

2024-11-05 Thread Dave Jiang
On 11/4/24 7:10 PM, Ira Weiny wrote: > DCD regions have 0 or more extents. The ability to list those and their > properties is useful to end users. > > Add extent output to region queries. > > Signed-off-by: Ira Weiny > --- > Documentation/cxl/cxl-list.txt | 4 ++ > cxl/filter.h

Re: [ndctl PATCH v2 6/6] ndctl/cxl/test: Add Dynamic Capacity tests

2024-11-05 Thread Dave Jiang
On 11/4/24 7:10 PM, Ira Weiny wrote: > cxl_test provides a good way to ensure quick smoke and regression > testing. The complexity of DCD and the new sparse DAX regions required > to use them benefits greatly with a series of smoke tests. > > The only part of the kernel stack which must be byp

Re: [ndctl PATCH v2 4/6] cxl/region: Add creation of Dynamic capacity regions

2024-11-05 Thread Dave Jiang
On 11/4/24 7:10 PM, ira.we...@intel.com wrote: > From: Navneet Singh > > CXL Dynamic Capacity Devices (DCDs) optionally support dynamic capacity > with up to eight partitions (Regions) (dc0-dc7). CXL regions can now be > spare and defined as dynamic capacity (dc). > > Add support for DCD dev

Re: [ndctl PATCH v2 3/6] ndctl: Separate region mode from decoder mode

2024-11-05 Thread Dave Jiang
On 11/4/24 7:10 PM, Ira Weiny wrote: > With the introduction of DCD, region mode and decoder mode no longer > remain a 1:1 relation. An interleaved region may be made up of Dynamic > Capacity partitions with different indexes on each of the target > devices. > > Introduce a new region mode enu

Re: [ndctl PATCH v2 2/6] ndctl/cxl/region: Report max size for region creation

2024-11-05 Thread Dave Jiang
On 11/4/24 7:10 PM, Ira Weiny wrote: > When creating a region if the size exceeds the max an error is printed. > However, the max available space is not reported which makes it harder > to determine what is wrong. > > Add the max size available to the output error. > > Signed-off-by: Ira Weiny

Re: [ndctl PATCH v2 1/6] ndctl/cxl-events: Don't fail test until event counts are reported

2024-11-05 Thread Dave Jiang
On 11/4/24 7:10 PM, Ira Weiny wrote: > In testing DCD event modifications a failed cxl-event test lacked > details on the event counts. This was because the greps were failing > the test rather than the check against the counts. > > Suppress the grep failure and rely on event count checks for