On Wed, 2024-08-21 at 15:02 -0700, alison.schofi...@intel.com wrote:
> From: Miroslav Suchy
>
> According to SPEC v2, the operator has to be in the upper case.
>
> Reposted here from github pull request:
> https://github.com/pmem/ndctl/pull/265/
>
> Signed-off-by: Miroslav Suchy
Looks good,
R
From: Miroslav Suchy
According to SPEC v2, the operator has to be in the upper case.
Reposted here from github pull request:
https://github.com/pmem/ndctl/pull/265/
Signed-off-by: Miroslav Suchy
---
ndctl.spec.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ndct
On 8/21/24 2:45 PM, alison.schofi...@intel.com wrote:
> From: Jerry James
>
> As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
> the expression "0%{?rhel}" evaluates to zero on Fedora, so the
> conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less
> than 9. The
On Wed, 2024-08-21 at 14:45 -0700, alison.schofi...@intel.com wrote:
> From: Jerry James
>
> As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
> the expression "0%{?rhel}" evaluates to zero on Fedora, so the
> conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less
>
On Tue, 2024-08-20 at 14:26 -0400, jmo...@redhat.com wrote:
> From: Jeff Moyer
>
> Static analysis points out that the cast of bus->major and bus->minor
> to a signed type in the call to parent_dev_path could result in a
> negative number. I sincerely doubt we'll see major and minor numbers
> th
On Tue, 2024-08-20 at 14:26 -0400, jmo...@redhat.com wrote:
> From: Jeff Moyer
>
> Static analysis points out that fd is leaked in some cases. The
> change to the while loop is optional. I only did that to make the
> code consistent.
>
> Signed-off-by: Jeff Moyer
Looks good,
Reviewed-by: Vis
From: Jerry James
As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
the expression "0%{?rhel}" evaluates to zero on Fedora, so the
conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less
than 9. The result is that ndctl builds for Fedora lack support for
libtraceeven
