Re: [ndctl PATCH v2 2/2] daxctl: Remove unimplemented create-device options

2024-05-31 Thread Alison Schofield
On Fri, May 31, 2024 at 02:29:59PM +0800, Li Zhijian wrote: > RECONFIG_OPTIONS and ZONE_OPTIONS are not implemented for create-device > and they will be ignored by create-device. Remove them so that the usage > message is identical to the manual. > > Signed-off-by: Li Zhijian The net effect of t

Re: [ndctl PATCH v2 1/2] daxctl: Fix create-device parameters parsing

2024-05-31 Thread Alison Schofield
On Fri, May 31, 2024 at 02:29:58PM +0800, Li Zhijian wrote: > Previously, the extra parameters will be ignored quietly, which is a bit > weird and confusing. It's just wrong. There is code to catch extra params, but it's being skipped because of the index setting that you mention below. Suggest re

Re: [ndctl PATCH v2 2/2] daxctl: Remove unimplemented create-device options

2024-05-31 Thread Dave Jiang
On 5/30/24 11:29 PM, Li Zhijian wrote: > RECONFIG_OPTIONS and ZONE_OPTIONS are not implemented for create-device > and they will be ignored by create-device. Remove them so that the usage > message is identical to the manual. > > Signed-off-by: Li Zhijian Reviewed-by: Dave Jiang > --- > V2:

Re: [ndctl PATCH v2 1/2] daxctl: Fix create-device parameters parsing

2024-05-31 Thread Dave Jiang
On 5/30/24 11:29 PM, Li Zhijian wrote: > Previously, the extra parameters will be ignored quietly, which is a bit > weird and confusing. > $ daxctl create-device region0 > [ > { > "chardev":"dax0.1", > "size":268435456, > "target_node":1, > "align":2097152, > "mode":"devdax

Re: [ndctl PATCH v2 2/2] daxctl: Remove unimplemented create-device options

2024-05-31 Thread Verma, Vishal L
On Fri, 2024-05-31 at 14:29 +0800, Li Zhijian wrote: > RECONFIG_OPTIONS and ZONE_OPTIONS are not implemented for create- > device > and they will be ignored by create-device. Remove them so that the > usage > message is identical to the manual. > > Signed-off-by: Li Zhijian Reviewed-by: Vishal V

Re: [ndctl PATCH v2 1/2] daxctl: Fix create-device parameters parsing

2024-05-31 Thread Verma, Vishal L
On Fri, 2024-05-31 at 14:29 +0800, Li Zhijian wrote: > Previously, the extra parameters will be ignored quietly, which is a bit > weird and confusing. > $ daxctl create-device region0 > [ >   { >     "chardev":"dax0.1", >     "size":268435456, >     "target_node":1, >     "align":2097152, >     "mo