Re: [ndctl PATCH v9 5/7] cxl/list: collect and parse media_error records

2024-03-04 Thread Dave Jiang
On 2/29/24 6:31 PM, alison.schofi...@intel.com wrote: > From: Alison Schofield > > Media_error records are logged as events in the kernel tracing > subsystem. To prepare the media_error records for cxl list, enable > tracing, trigger the poison list read, and parse the generated > cxl_poison e

Re: [ndctl PATCH v9 4/7] cxl/event_trace: add helpers to retrieve tep fields by type

2024-03-04 Thread Dave Jiang
On 2/29/24 6:31 PM, alison.schofi...@intel.com wrote: > From: Alison Schofield > > Add helpers to extract the value of an event record field given the > field name. This is useful when the user knows the name and format > of the field and simply needs to get it. > > Since this is in preparati

[NDCTL PATCH v9 4/4] ndctl: add test for qos_class in CXL test suite

2024-03-04 Thread Dave Jiang
Add tests in cxl-qos-class.sh to verify qos_class are set with the fake qos_class create by the kernel. Root decoders should have qos_class attribute set. Memory devices should have ram_qos_class or pmem_qos_class set depending on which partitions are valid. Signed-off-by: Dave Jiang --- test/c

[NDCTL PATCH v9 3/4] ndctl: cxl: add QoS class check for CXL region creation

2024-03-04 Thread Dave Jiang
The CFMWS provides a QTG ID. The kernel driver creates a root decoder that represents the CFMWS. A qos_class attribute is exported via sysfs for the root decoder. One or more qos_class tokens are retrieved via QTG ID _DSM from the ACPI0017 device for a CXL memory device. The input for the _DSM is

[NDCTL PATCH v9 2/4] ndctl: cxl: Add QoS class support for the memory device

2024-03-04 Thread Dave Jiang
Add libcxl API to retrieve the QoS class tokens for the memory devices. Two API calls are added. One for 'ram' or 'volatile' mode and another for 'pmem' or 'persistent' mode. Support also added for displaying the QoS class tokens through the 'cxl list' command. Reviewed-by: Alison Schofield Signe

[NDCTL PATCH v9 1/4] ndctl: cxl: Add QoS class retrieval for the root decoder

2024-03-04 Thread Dave Jiang
Add libcxl API to retrieve the QoS class for the root decoder. Also add support to display the QoS class for the root decoder through the 'cxl list' command. The qos_class is the QTG ID of the CFMWS window that represents the root decoder. Reviewed-by: Alison Schofield Signed-off-by: Dave Jiang

[NDCTL PATCH v9 0/4] ndctl: Add support of qos_class for CXL CLI

2024-03-04 Thread Dave Jiang
Hi Vishal, With the QoS class series merged to the v6.8 kernel, can you please review and apply this series to ndctl if acceptable? v9: - Rename cxl_region_qos_class_matches() to cxl_region_qos_class_mismatch() (Vishal) - Rename ->qos_enforce to ->enforce_qos (Vishal) - Rename json output qos_cla