[Numpy-discussion] Suggestion: add an pad parameter to np.memmap

2020-12-23 Thread Tom Swirly
Hello, and thanks for all your work on the amazing numpy. I'm using np.memmap() with great success for memory mapping WAV audio files, with one tiny blemish - the WAV spec wants me to sometimes put one byte after the list of samples that I'm memory mapping, which I can't do easily when writing a n

Re: [Numpy-discussion] Addition of new distributions: Polya-gamma

2020-12-27 Thread Tom Swirly
I'm just a lurker, but I spent a minute or two to look at that commit, which looks to be high quality. While I personally have not used this distribution, people I know use it all the time (for ML). A quibble: #define NPY_PI 3.141592653589793238462643383279502884 /* pi */ and the following def

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-06 Thread Tom Swirly
Well, I can tell you why it needs to be backward compatible! I use random numbers fairly frequently, and to unit test them I set a specific seed and then make sure I get the same answers. If your change went in (and I were using numpy normal distributions, which I am not) then my tests would brea