Re: [Numpy-discussion] __array_ufunc__ counting down to launch, T-24 hrs.

2017-03-31 Thread Marten van Kerkwijk
Hi Nathan, That is a good point: Yes, one can leave __array_prepare__ and __array_wrap__ in place: only for ufuncs will they be ignored if __array_ufunc__ is present; __array_wrap__ in particular will still be used by quite a lot of other numpy functions (other use of __array_prepare__ is usually

Re: [Numpy-discussion] __array_ufunc__ counting down to launch, T-24 hrs.

2017-03-31 Thread Nathan Goldbaum
Thanks for linking to the updated NEP, I've been looking for a good overview of this discussion. Up until now I haven't wanted to wade through the extensive discussion on this topic. I'm curious, if I want to simultaneously support older Numpy versions as well as newer versions, will I be able to

Re: [Numpy-discussion] __array_ufunc__ counting down to launch, T-24 hrs.

2017-03-31 Thread Marten van Kerkwijk
Hi All, Following Nathaniel's request, I have made a PR that changes the original NEP to describe the current implementation. * PR at https://github.com/charris/numpy/pull/9 * Rendered relevant page at http://www.astro.utoronto.ca/~mhvk/numpy-doc/neps/ufunc-overrides.html It may still be somewhat

Re: [Numpy-discussion] __array_ufunc__ counting down to launch, T-24 hrs.

2017-03-31 Thread Stephan Hoyer
I agree with Nathaniel -- let's finish the design doc first. On Thu, Mar 30, 2017 at 10:08 PM, Nathaniel Smith wrote: > On Thu, Mar 30, 2017 at 7:40 PM, Charles R Harris > wrote: > > Hi All, > > > > Just a note that the __array_ufunc__ PR is ready to merge. If you are > > interested, you can re

Re: [Numpy-discussion] __array_ufunc__ counting down to launch, T-24 hrs.

2017-03-30 Thread Nathaniel Smith
On Thu, Mar 30, 2017 at 7:40 PM, Charles R Harris wrote: > Hi All, > > Just a note that the __array_ufunc__ PR is ready to merge. If you are > interested, you can review here. I want to get this in too, but 24 hours seems like a very short deadline for getting feedback on such a large and complex