Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-13 Thread Ralf Gommers
On Thu, Jul 13, 2017 at 8:14 AM, Pauli Virtanen wrote: > Charles R Harris kirjoitti 12.07.2017 klo 13:53: > > In practice, that would generally be true, but the nose testing tools > > were 1, all nose imports were buried in functions that ran during > > testing. Whether or not that was by intent

Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-12 Thread Pauli Virtanen
Charles R Harris kirjoitti 12.07.2017 klo 13:53: > In practice, that would generally be true, but the nose testing tools > were 1, all nose imports were buried in functions that ran during > testing. Whether or not that was by intent I don't know. But having an > explicit consensus on 2, which seem

Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-12 Thread Pauli Virtanen
Charles R Harris kirjoitti 12.07.2017 klo 13:53: > In practice, that would generally be true, but the nose testing tools > were 1, all nose imports were buried in functions that ran during > testing. Whether or not that was by intent I don't know. But having an > explicit consensus on 2, which seem

Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-12 Thread Pauli Virtanen
Charles R Harris kirjoitti 12.07.2017 klo 13:53: > In practice, that would generally be true, but the nose testing tools > were 1, all nose imports were buried in functions that ran during > testing. Whether or not that was by intent I don't know. But having an > explicit consensus on 2, which seem

Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-12 Thread Charles R Harris
On Wed, Jul 12, 2017 at 1:26 AM, Ralf Gommers wrote: > > > On Wed, Jul 12, 2017 at 11:06 AM, Chris Barker > wrote: > >> >> >> On Tue, Jul 11, 2017 at 5:04 PM, Thomas Caswell >> wrote: >> >>> Going with option 2 is probably the best option so that you can use >>> pytest fixtures and parameteriza

Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-12 Thread Ralf Gommers
On Wed, Jul 12, 2017 at 11:06 AM, Chris Barker wrote: > > > On Tue, Jul 11, 2017 at 5:04 PM, Thomas Caswell > wrote: > >> Going with option 2 is probably the best option so that you can use >> pytest fixtures and parameterization. >> > > I agree -- those are worth a lot! > Maybe I'm dense, but

Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-11 Thread Chris Barker
On Tue, Jul 11, 2017 at 5:04 PM, Thomas Caswell wrote: > Going with option 2 is probably the best option so that you can use pytest > fixtures and parameterization. > I agree -- those are worth a lot! -CHB > Might be worth looking at how Matplotlib re-arranged things on our master > branch t

Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-11 Thread Thomas Caswell
Going with option 2 is probably the best option so that you can use pytest fixtures and parameterization. Might be worth looking at how Matplotlib re-arranged things on our master branch to maintain back-compatibility with nose-specific tools that were used by down-stream projects. Tom On Tue, J

Re: [Numpy-discussion] pytest and degrees of separation.

2017-07-11 Thread Sebastian Berg
On Tue, 2017-07-11 at 14:49 -0600, Charles R Harris wrote: > Hi All, > > Just looking for opinions and feedback on the need to keep NumPy from > having a hard nose/pytest dependency. The options as I see them are: > > pytest is never imported until the tests are run -- current practice > with nos

[Numpy-discussion] pytest and degrees of separation.

2017-07-11 Thread Charles R Harris
Hi All, Just looking for opinions and feedback on the need to keep NumPy from having a hard nose/pytest dependency. The options as I see them are: 1. pytest is never imported until the tests are run -- current practice with nose 2. pytest is never imported unless the testfiles are impor