Re: [PATCH v2 51/86] drm/ast: Run DRM default client setup

2024-08-21 Thread Jocelyn Falempe
fault if no format has been given, leave it out entirely. Thanks for this whole series. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 6 -- 1 file changed, 4 insertions(

Re: [PATCH v2 56/86] drm/mgag200: Run DRM default client setup

2024-08-21 Thread Jocelyn Falempe
On 21/08/2024 14:59, Thomas Zimmermann wrote: Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Thanks for this whole series. Reviewed-by: Jocelyn Fa

[PATCH v2 0/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-06 Thread Jocelyn Falempe
s. * Rework the tiling algorithm, using "swizzle" to compute the offset inside the block. Jocelyn Falempe (3): drm/panic: Add ABGR2101010 support drm/panic: add a private pointer to struct drm_scanout_buffer drm/nouveau: Add drm_panic support for nv50+ drivers/gpu/drm/drm

[PATCH v2 1/3] drm/panic: Add ABGR2101010 support

2024-09-06 Thread Jocelyn Falempe
Add support for ABGR2101010, used by the nouveau driver. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c index 74412b7bf936..0a9ecc1380d2 100644 --- a/drivers

[PATCH v2 2/3] drm/panic: add a private pointer to struct drm_scanout_buffer

2024-09-06 Thread Jocelyn Falempe
It can be set to a private structure in get_scanout_buffer(), and used later in set_pixel() or in panic_flush(). Signed-off-by: Jocelyn Falempe --- include/drm/drm_panic.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/drm_panic.h b/include/drm/drm_panic.h index

[PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-06 Thread Jocelyn Falempe
for other cards. Signed-off-by: Jocelyn Falempe --- v2: * Rebase and drop already merged patches. * Rework the tiling algorithm, using "swizzle" to compute the offset inside the block. drivers/gpu/drm/nouveau/dispnv50/wndw.c | 107 +++- 1 file changed, 105 insert

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-06 Thread Jocelyn Falempe
On 06/09/2024 14:53, Ilia Mirkin wrote: On Fri, Sep 6, 2024 at 6:05 AM Jocelyn Falempe <mailto:jfale...@redhat.com>> wrote: Add drm_panic support, for nv50+ cards. It's enough to get the panic screen while running Gnome/Wayland on a GTX 1650. It doesn't sup

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-11 Thread Jocelyn Falempe
dn't find the link, but I think I have enough information, thanks for your support. Best regards, -- Jocelyn Thanks, -James On 9/6/24 05:53, Ilia Mirkin wrote: On Fri, Sep 6, 2024 at 6:05 AM Jocelyn Falempe <mailto:jfale...@redhat.com>> wrote:     Add drm_panic support,

Re: [PATCH v2 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-09-12 Thread Jocelyn Falempe
On 11/09/2024 16:39, Ilia Mirkin wrote: On Wed, Sep 11, 2024 at 10:19 AM Jocelyn Falempe <mailto:jfale...@redhat.com>> wrote: On 06/09/2024 21:36, James Jones wrote: > Right, there are 3 iterations of block linear tiling actually. NV50 does > support scanout

[PATCH v3 0/2] drm/nouveau: Add drm_panic support for nv50+

2024-09-13 Thread Jocelyn Falempe
ling parameters. * Have 2 set_pixel() functions, depending on GPU family. Jocelyn Falempe (2): drm/panic: Add ABGR2101010 support drm/nouveau: Add drm_panic support for nv50+ drivers/gpu/drm/drm_panic.c | 10 ++ drivers/gpu/drm/nouveau/dispnv50/wndw.c | 139 +

[PATCH v3 1/2] drm/panic: Add ABGR2101010 support

2024-09-13 Thread Jocelyn Falempe
Add support for ABGR2101010, used by the nouveau driver. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c index 74412b7bf936..0a9ecc1380d2 100644 --- a/drivers

[PATCH v3 2/2] drm/nouveau: Add drm_panic support for nv50+

2024-09-13 Thread Jocelyn Falempe
for other cards. Signed-off-by: Jocelyn Falempe --- v2: * Rebase and drop already merged patches. * Rework the tiling algorithm, using "swizzle" to compute the offset inside the block. v3: * Fix support for Tesla GPU, which have simpler tiling. * Use nouveau_framebuffer_get

Re: [PATCH v3 1/2] drm/panic: Add ABGR2101010 support

2024-09-13 Thread Jocelyn Falempe
On 13/09/2024 09:22, Javier Martinez Canillas wrote: Jocelyn Falempe writes: Hello Jocelyn, Add support for ABGR2101010, used by the nouveau driver. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v3 2/2] drm/nouveau: Add drm_panic support for nv50+

2024-10-21 Thread Jocelyn Falempe
On 18/10/2024 23:50, Lyude Paul wrote: On Fri, 2024-09-13 at 09:03 +0200, Jocelyn Falempe wrote: Add drm_panic support, for nv50+ cards. It's enough to get the panic screen while running Gnome/Wayland on a GTX 1650. It doesn't support multi-plane or compressed format. Support for oth

[PATCH v4 2/3] drm/nouveau/disp: Move tiling functions to dispnv50/tile.h

2024-10-22 Thread Jocelyn Falempe
Refactor, and move the tiling geometry functions to dispnv50/tile.h, so they can be re-used by drm_panic. No functional impact. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/nouveau/dispnv50/tile.h | 63 +++ drivers/gpu/drm/nouveau/nouveau_display.c | 59

[PATCH v4 3/3] drm/nouveau: Add drm_panic support for nv50+

2024-10-22 Thread Jocelyn Falempe
ned-off-by: Jocelyn Falempe Reviewed-by: Lyude Paul --- v4: * Refactor get_scanout_buffer() to use the new dispnv50/tile.h * use drm_warn() instead of pr_warn() in get_scanout_buffer drivers/gpu/drm/nouveau/dispnv50/wndw.c | 129 +++- 1 file changed, 127 insertions(+), 2

[PATCH v4 0/3] drm/nouveau: Add drm_panic support for nv50+

2024-10-22 Thread Jocelyn Falempe
factor and move the tiling code from nouveau_display.c to dispnv50/tile.h, so that in can be re-used by drm_panic. (Lyude) * Refactor get_scanout_buffer() to use the new dispnv50/tile.h * use drm_warn() instead of pr_warn() in get_scanout_buffer Jocelyn Falempe (3): drm/panic: Add ABGR2101

[PATCH v4 1/3] drm/panic: Add ABGR2101010 support

2024-10-22 Thread Jocelyn Falempe
Add support for ABGR2101010, used by the nouveau driver. Signed-off-by: Jocelyn Falempe Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_panic.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c index

Re: [PATCH v4 0/3] drm/nouveau: Add drm_panic support for nv50+

2024-11-04 Thread Jocelyn Falempe
On 31/10/2024 21:29, Lyude Paul wrote: Reviewed-by: Lyude Paul I just pushed it to drm-misc-next. Thanks & Best regards, -- Jocelyn

Re: [PATCH v3 0/2] drm/nouveau: Add drm_panic support for nv50+

2024-09-24 Thread Jocelyn Falempe
On 13/09/2024 09:03, Jocelyn Falempe wrote: This series adds basic drm_panic support for nouveau. Patches 1 Add ABGR2101010 support in drm_panic. Patch 2 registers nouveau to drm_panic, and handle tiling. I've tested on a GTX1650 (Turing) and GF 8800 GT (Tesla), while running Gnome/Wa

Re: [PATCH v12 5/6] rust: enable `clippy::cast_lossless` lint

2025-06-18 Thread Jocelyn Falempe
inize. It also has the slight benefit of removing a degree of freedom on which to bikeshed. Thus apply the changes and enable the lint -- no functional change intended. Thanks, it looks good to me, for the drm_panic_qr.rs part. Acked-by: Jocelyn Falempe Link: https://rust-lang.github.io/rust-c